From 4f7b8f5cf31abfdc1951e1a9f39caeba5cecc68d Mon Sep 17 00:00:00 2001 From: Mikael Mengistu Date: Tue, 6 Feb 2018 09:40:57 -0800 Subject: [PATCH] Unskip Tests (#1410) --- .../HubConnectionTests.cs | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs b/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs index b7513dcd3f..3f624232e9 100644 --- a/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Client.FunctionalTests/HubConnectionTests.cs @@ -74,7 +74,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip = "https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task CanSendAndReceiveMessage(IHubProtocol protocol, TransportType transportType, string path) { @@ -103,7 +103,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip="https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task CanStopAndStartConnection(IHubProtocol protocol, TransportType transportType, string path) { @@ -215,7 +215,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip="https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task CanInvokeClientMethodFromServer(IHubProtocol protocol, TransportType transportType, string path) { @@ -317,7 +317,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip="https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task CanCloseStreamMethodEarly(IHubProtocol protocol, TransportType transportType, string path) { @@ -352,7 +352,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip="https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task StreamDoesNotStartIfTokenAlreadyCanceled(IHubProtocol protocol, TransportType transportType, string path) { @@ -383,7 +383,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip = "https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task ExceptionFromStreamingSentToClient(IHubProtocol protocol, TransportType transportType, string path) { @@ -411,7 +411,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip = "https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task ServerThrowsHubExceptionIfHubMethodCannotBeResolved(IHubProtocol hubProtocol, TransportType transportType, string hubPath) { @@ -465,7 +465,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip="https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task ServerThrowsHubExceptionOnHubMethodArgumentTypeMismatch(IHubProtocol hubProtocol, TransportType transportType, string hubPath) { @@ -492,7 +492,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip = "https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task ServerThrowsHubExceptionIfStreamingHubMethodCannotBeResolved(IHubProtocol hubProtocol, TransportType transportType, string hubPath) { @@ -549,7 +549,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.FunctionalTests } } - [Theory(Skip = "https://github.com/aspnet/SignalR/issues/1392")] + [Theory] [MemberData(nameof(HubProtocolsAndTransportsAndHubPaths))] public async Task ServerThrowsHubExceptionOnStreamingHubMethodArgumentTypeMismatch(IHubProtocol hubProtocol, TransportType transportType, string hubPath) {