huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Prevent modifying ContentLength after starting response #14056 (#15089)

This commit is contained in:
Chris Ross 2019-10-17 13:40:08 -07:00 committed by GitHub
parent 23f3a10965
commit 4dd9bfc492
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.cs
View File

@ -27,6 +27,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
get { return _contentLength; } get { return _contentLength; }
set set
{ {
if (_isReadOnly)
{
ThrowHeadersReadOnlyException();
}
if (value.HasValue && value.Value < 0) if (value.HasValue && value.Value < 0)
{ {
ThrowInvalidContentLengthException(value.Value); ThrowInvalidContentLengthException(value.Value);

9
src/Servers/Kestrel/Core/test/HttpResponseHeadersTests.cs
View File

@ -138,6 +138,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
Assert.Throws<InvalidOperationException>(() => ((IDictionary<string, StringValues>)headers).Add("my-header", new[] { "value" })); Assert.Throws<InvalidOperationException>(() => ((IDictionary<string, StringValues>)headers).Add("my-header", new[] { "value" }));
} }
[Fact]
public void ThrowsWhenSettingContentLengthPropertyAfterReadOnlyIsSet()
{
var headers = new HttpResponseHeaders();
headers.SetReadOnly();
Assert.Throws<InvalidOperationException>(() => headers.ContentLength = null);
}
[Fact] [Fact]
public void ThrowsWhenChangingHeaderAfterReadOnlyIsSet() public void ThrowsWhenChangingHeaderAfterReadOnlyIsSet()
{ {