API review - remove DefaultOrder

No change in behavior intended, removing this from our public API.

src/Microsoft.AspNet.Mvc.ApiExplorer/DefaultApiDescriptionProvider.cs

@@ -48,7 +48,7 @@ namespace Microsoft.AspNet.Mvc.ApiExplorer
         /// <inheritdoc />
         public int Order
         {
-            get { return DefaultOrder.DefaultFrameworkSortOrder; }
+            get { return -1000; }
         }
 
         /// <inheritdoc />

src/Microsoft.AspNet.Mvc.Core/ActionConstraints/DefaultActionConstraintProvider.cs

@@ -19,7 +19,7 @@ namespace Microsoft.AspNet.Mvc.ActionConstraints
         /// <inheritdoc />
         public int Order
         {
-            get { return DefaultOrder.DefaultFrameworkSortOrder; }
+            get { return -1000; }
         }
 
         /// <inheritdoc />

src/Microsoft.AspNet.Mvc.Core/Actions/ControllerActionDescriptorProvider.cs

@@ -27,7 +27,7 @@ namespace Microsoft.AspNet.Mvc.Actions
 
         public int Order
         {
-            get { return DefaultOrder.DefaultFrameworkSortOrder; }
+            get { return -1000; }
         }
 
         /// <inheritdoc />

src/Microsoft.AspNet.Mvc.Core/Actions/ControllerActionInvokerProvider.cs

@@ -54,7 +54,7 @@ namespace Microsoft.AspNet.Mvc.Actions
 
         public int Order
         {
-            get { return DefaultOrder.DefaultFrameworkSortOrder; }
+            get { return -1000; }
         }
 
         /// <inheritdoc />

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/AuthorizationApplicationModelProvider.cs

@@ -18,7 +18,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
             _authorizationOptions = authorizationOptionsAccessor.Value;
         }
 
-        public int Order {  get { return DefaultOrder.DefaultFrameworkSortOrder + 10; } }
+        public int Order {  get { return -1000 + 10; } }
 
         public void OnProvidersExecuted([NotNull]ApplicationModelProviderContext context)
         {

src/Microsoft.AspNet.Mvc.Core/ApplicationModels/DefaultApplicationModelProvider.cs

@@ -30,7 +30,7 @@ namespace Microsoft.AspNet.Mvc.ApplicationModels
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.Core/DefaultOrder.cs

@@ -1,21 +0,0 @@
-// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
-
-namespace Microsoft.AspNet.Mvc
-{
-    public static class DefaultOrder
-    {
-        /// <summary>
-        /// The default order for sorting is -1000. Other framework code
-        /// the depends on order should be ordered between -1 to -1999.
-        /// User code should order at bigger than 0 or smaller than -2000.
-        /// </summary>
-        public static readonly int DefaultFrameworkSortOrder = -1000;
-
-        /// <summary>
-        /// The default order for <c>CorsAuthorizationFilter</c>, <c>CorsAuthorizationFilterFactory</c>
-        /// and <c>DisableCorsAuthorizationFilter</c>
-        /// </summary>
-        public static readonly int DefaultCorsSortOrder = int.MaxValue - 100;
-    }
-}

src/Microsoft.AspNet.Mvc.Core/Filters/DefaultFilterProvider.cs

@@ -12,7 +12,7 @@ namespace Microsoft.AspNet.Mvc.Filters
     {
         public int Order
         {
-            get { return DefaultOrder.DefaultFrameworkSortOrder; }
+            get { return -1000; }
         }
 
         /// <inheritdoc />

src/Microsoft.AspNet.Mvc.Cors/CorsApplicationModelProvider.cs

@@ -10,7 +10,7 @@ namespace Microsoft.AspNet.Mvc.Cors
 {
     public class CorsApplicationModelProvider : IApplicationModelProvider
     {
-        public int Order {  get { return DefaultOrder.DefaultFrameworkSortOrder + 10; } }
+        public int Order {  get { return -1000 + 10; } }
 
         public void OnProvidersExecuted([NotNull]ApplicationModelProviderContext context)
         {

src/Microsoft.AspNet.Mvc.Cors/CorsAuthorizationFilter.cs

@@ -42,7 +42,7 @@ namespace Microsoft.AspNet.Mvc.Cors
         {
             get
             {
-                return DefaultOrder.DefaultCorsSortOrder;
+                return int.MaxValue - 100;
             }
         }
 

src/Microsoft.AspNet.Mvc.Cors/CorsAuthorizationFilterFactory.cs

@@ -29,7 +29,7 @@ namespace Microsoft.AspNet.Mvc.Cors
         {
             get
             {
-                return DefaultOrder.DefaultCorsSortOrder;
+                return int.MaxValue - 100;
             }
         }
 

src/Microsoft.AspNet.Mvc.Cors/DisableCorsAuthorizationFilter.cs

@@ -21,7 +21,7 @@ namespace Microsoft.AspNet.Mvc.Cors
         {
             get
             {
-                return DefaultOrder.DefaultCorsSortOrder;
+                return int.MaxValue - 100;
             }
         }
 

src/Microsoft.AspNet.Mvc.Razor/TagHelpers/UrlResolutionTagHelper.cs

@@ -97,7 +97,7 @@ namespace Microsoft.AspNet.Mvc.Razor.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder - 999;
+                return -1000 - 999;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/AnchorTagHelper.cs

@@ -47,7 +47,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/CacheTagHelper.cs

@@ -52,7 +52,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/EnvironmentTagHelper.cs

@@ -30,7 +30,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/FormTagHelper.cs

@@ -43,7 +43,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/ImageTagHelper.cs

@@ -54,7 +54,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/InputTagHelper.cs

@@ -77,7 +77,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/LabelTagHelper.cs

@@ -30,7 +30,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/LinkTagHelper.cs

@@ -115,7 +115,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/OptionTagHelper.cs

@@ -34,7 +34,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/ScriptTagHelper.cs

@@ -101,7 +101,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/SelectTagHelper.cs

@@ -46,7 +46,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/TextAreaTagHelper.cs

@@ -29,7 +29,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/ValidationMessageTagHelper.cs

@@ -31,7 +31,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

src/Microsoft.AspNet.Mvc.TagHelpers/ValidationSummaryTagHelper.cs

@@ -32,7 +32,7 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder;
+                return -1000;
             }
         }
 

test/Microsoft.AspNet.Mvc.Core.Test/Actions/ControllerActionInvokerTest.cs

@@ -2029,7 +2029,7 @@ namespace Microsoft.AspNet.Mvc.Actions
                           .Verifiable();
 
             filterProvider.SetupGet(fp => fp.Order)
-                          .Returns(DefaultOrder.DefaultFrameworkSortOrder);
+                          .Returns(-1000);
 
             var invoker = new TestControllerActionInvoker(
                 actionContext,

test/Microsoft.AspNet.Mvc.Core.Test/Routing/KnownRouteValueConstraintTests.cs

@@ -156,7 +156,7 @@ namespace Microsoft.AspNet.Mvc.Routing
 
             actionProvider
                 .SetupGet(p => p.Order)
-                .Returns(DefaultOrder.DefaultFrameworkSortOrder);
+                .Returns(-1000);
 
             actionProvider
                 .Setup(p => p.OnProvidersExecuting(It.IsAny<ActionDescriptorProviderContext>()))

test/WebSites/BasicWebSite/ActionDescriptorCreationCounter.cs

@@ -26,7 +26,7 @@ namespace BasicWebSite
         {
             get
             {
-                return DefaultOrder.DefaultFrameworkSortOrder - 100;
+                return -1000 - 100;
             }
         }