diff --git a/build/repo.targets b/build/repo.targets index 3285a78ab1..02cf9ad639 100644 --- a/build/repo.targets +++ b/build/repo.targets @@ -15,7 +15,7 @@ $(IntermediateDir)dependencies.g.props $(IntermediateDir)sources.g.props - $(PrepareDependsOn);VerifyPackageArtifactConfig;PrepareOutputPaths + SetTeamCityBuildNumberToVersion;$(PrepareDependsOn);VerifyPackageArtifactConfig;PrepareOutputPaths $(CleanDependsOn);CleanArtifacts;CleanUniverseArtifacts $(RestoreDependsOn);InstallDotNet;RestoreExternalDependencies $(CompileDependsOn);BuildRepositories diff --git a/build/tools/docker/rhel.7/Dockerfile b/build/tools/docker/rhel.7/Dockerfile index 73247d2809..331cb6335b 100644 --- a/build/tools/docker/rhel.7/Dockerfile +++ b/build/tools/docker/rhel.7/Dockerfile @@ -4,11 +4,7 @@ # # Dockerfile that creates a container suitable to build dotnet-cli -FROM microsoft/dotnet-buildtools-prereqs:rhel-7-rpmpkg-c982313-20174116044113 - -# Install from sudo main package TODO This package needs to be mirrored -RUN yum install -y https://www.sudo.ws/sudo/dist/packages/RHEL/7/sudo-1.8.20-3.el7.x86_64.rpm \ - && yum clean all +FROM microsoft/dotnet-buildtools-prereqs:rhel-7-rpmpkg-e1b4a89-20175311035359 # Setup User to match Host User, and give superuser permissions ARG USER_ID=0 diff --git a/build/tools/templates/RS.Manifest/RS.Manifest.csproj b/build/tools/templates/RS.Manifest/RS.Manifest.csproj deleted file mode 100644 index c0836b81dd..0000000000 --- a/build/tools/templates/RS.Manifest/RS.Manifest.csproj +++ /dev/null @@ -1,28 +0,0 @@ - - - - - - netcoreapp2.0 - $(DotNetRestoreSources) - - $(RestoreSources); - https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json; - https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json; - - - $(RestoreSources); - https://api.nuget.org/v3/index.json; - - - - - - - - - - - - - diff --git a/build/tools/templates/RS.References/RS.References.csproj b/build/tools/templates/RS.References/RS.References.csproj deleted file mode 100644 index d99ebef658..0000000000 --- a/build/tools/templates/RS.References/RS.References.csproj +++ /dev/null @@ -1,22 +0,0 @@ - - - - - - $(DotNetRestoreSources) - - $(RestoreSources); - https://dotnet.myget.org/F/aspnetcore-dev/api/v3/index.json; - https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json; - - - $(RestoreSources); - https://api.nuget.org/v3/index.json; - - netcoreapp2.0 - false - false - false - - - diff --git a/run.ps1 b/run.ps1 index cab9fbe6e7..29f826e9aa 100644 --- a/run.ps1 +++ b/run.ps1 @@ -44,6 +44,9 @@ The path to the configuration file that stores values. Defaults to korebuild.jso .PARAMETER RestoreSources (optional) Semi-colon delimited list of additional NuGet feeds to use as part of restore. +.PARAMETER ProductBuildId +(optional) The product build ID for correlation with orchestrated builds. + .PARAMETER MSBuildArguments Additional MSBuild arguments to be passed through. @@ -83,6 +86,7 @@ param( [string]$AccessTokenSuffix = $null, [string]$RestoreSources = $null, [string]$AssetRootUrl = $null, + [string]$ProductBuildId = $null, [Parameter(ValueFromRemainingArguments = $true)] [string[]]$MSBuildArguments ) @@ -221,6 +225,10 @@ if ($AccessTokenSuffix) { $MSBuildArguments += "-p:DotNetAssetRootAccessTokenSuffix=$AccessTokenSuffix" } +if ($ProductBuildId) { + $MSBuildArguments += "-p:DotNetProductBuildId=$ProductBuildId" +} + # Execute $korebuildPath = Get-KoreBuild diff --git a/run.sh b/run.sh index 8f861cf149..2be18220d0 100755 --- a/run.sh +++ b/run.sh @@ -22,6 +22,7 @@ package_version_props_url='' asset_root_url='' access_token_suffix='' restore_sources='' +product_build_id='' msbuild_args=() # @@ -44,6 +45,7 @@ __usage() { echo " --package-version-props-url The url of the package versions props path containing dependency versions." echo " --access-token The query string to append to any blob store access for PackageVersionPropsUrl, if any." echo " --restore-sources Semi-colon delimited list of additional NuGet feeds to use as part of restore." + echo " --product-build-id The product build ID for correlation with orchestrated builds." echo " -u|--update Update to the latest KoreBuild even if the lock file is present." echo " --reinstall Reinstall KoreBuild." echo "" @@ -202,6 +204,12 @@ while [[ $# -gt 0 ]]; do [ -z "${1+x}" ] && __error "Missing value for parameter --asset-root-url" && __usage asset_root_url="$1" ;; + --product-build-id|-ProductBuildId) + shift + # This parameter can be an empty string, but it should be set + [ -z "${1+x}" ] && __error "Missing value for parameter --product-build-id" && __usage + product_build_id="$1" + ;; -u|--update|-Update) update=true ;; @@ -272,6 +280,10 @@ if [ ! -z "$access_token_suffix" ]; then msbuild_args[${#msbuild_args[*]}]="-p:DotNetAssetRootAccessTokenSuffix=$access_token_suffix" fi +if [ ! -z "$product_build_id" ]; then + msbuild_args[${#msbuild_args[*]}]="-p:DotNetProductBuildId=$product_build_id" +fi + [ -z "$channel" ] && channel='dev' [ -z "$tools_source" ] && tools_source='https://aspnetcore.blob.core.windows.net/buildtools' diff --git a/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj b/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj index e200628429..2b1325dd79 100644 --- a/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj +++ b/src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj @@ -29,7 +29,7 @@ - + diff --git a/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets b/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets index 4bc0305379..abc3cf0fbb 100644 --- a/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets +++ b/src/Microsoft.AspNetCore.All/build/netcoreapp2.1/Microsoft.AspNetCore.All.targets @@ -1,7 +1,7 @@ - - + + diff --git a/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj b/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj index 71ab3a1e61..bba0f0f8bc 100644 --- a/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj +++ b/src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj @@ -24,6 +24,7 @@ + diff --git a/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets b/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets new file mode 100644 index 0000000000..22fd71eb25 --- /dev/null +++ b/src/Microsoft.AspNetCore.App/build/netcoreapp2.1/Microsoft.AspNetCore.App.targets @@ -0,0 +1,7 @@ + + + + + diff --git a/version.props b/version.props index 3419b31a1a..9464a7a507 100644 --- a/version.props +++ b/version.props @@ -9,4 +9,5 @@ master +