Only publish artifacts on successful builds and fix code-signing for the SiteExtension package (#7199)
This commit is contained in:
Nate McMaster
GitHub
parent
61bc18fee3
commit
4c4a1effcd
|
|
@ -44,24 +44,33 @@ jobs:
|
|||
- script: "echo ##vso[build.addbuildtag]release-candidate"
|
||||
condition: and(ne(variables['Build.Reason'], 'PullRequest'), eq(variables['IsFinalBuild'], 'true'))
|
||||
displayName: 'Set CI tags'
|
||||
# TODO: make it possible to build for one Windows architecture at a time
|
||||
# This is going to actually build x86 native assets
|
||||
# !!! NOTE !!! Some of these steps have disabled code signing.
|
||||
# This is intentional to workaround https://github.com/dotnet/arcade/issues/1957 which always re-submits for code-signing, even
|
||||
# if they have already been signed. This results in slower builds due to re-submitting the same .nupkg many times for signing.
|
||||
# The sign settings have been configured to
|
||||
|
||||
# Intentionally does not code-sign because the next step will code sign the same files.
|
||||
# Skipping signing avoids duplicate sign requests.
|
||||
- script: ./eng/scripts/cibuild.cmd -arch x64 /p:SignType=
|
||||
- script: ./eng/scripts/cibuild.cmd -arch x64 /p:DisableCodeSigning=true
|
||||
displayName: Build x64
|
||||
# TODO: make it possible to build for one Windows architecture at a time
|
||||
# This is going to actually build x86 native assets. See https://github.com/aspnet/AspNetCore/issues/7196
|
||||
|
||||
# Build the x86 shared framework
|
||||
# Set DisableSignCheck because we'll run sign check in an explicit step after installers build
|
||||
- script: ./eng/scripts/cibuild.cmd -arch x86 /t:BuildSharedFx /p:SignType=$(_SignType) /p:DisableSignCheck=true
|
||||
- script: ./eng/scripts/cibuild.cmd -arch x86 /t:BuildSharedFx /p:DisableCodeSigning=true
|
||||
displayName: Build x86
|
||||
|
||||
# This is in a separate build step with -forceCoreMsbuild to workaround MAX_PATH limitations - https://github.com/Microsoft/msbuild/issues/53
|
||||
- script: ./build.cmd -ci -sign -forceCoreMsbuild /p:DisableCodeSigning=true -projects ./src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
|
||||
displayName: Build SiteExtension
|
||||
|
||||
# Windows installers bundle both x86 and x64 assets
|
||||
- powershell: ./src/Installers/Windows/build.ps1 -ci /p:SignType=$(_SignType)
|
||||
displayName: Build Installers
|
||||
- powershell: ./build.ps1 -ci -sign -forceCoreMsbuild -projects ./src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj
|
||||
displayName: Build SiteExtension
|
||||
- script: ./build.cmd -ci -sign /t:SignCheck /p:SignType=$(_SignType)
|
||||
displayName: Run signcheck
|
||||
|
||||
# This runs code-signing on all outputs as defined in build/CodeSign.targets. If https://github.com/dotnet/arcade/issues/1957 is resolved,
|
||||
# consider running code-signing inline with the other previous steps.
|
||||
- script: ./build.cmd -ci -sign /t:CodeSign /t:SignCheck /p:SignType=$(_SignType)
|
||||
displayName: Code sign packages
|
||||
artifacts:
|
||||
- name: Windows_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -73,6 +82,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Windows_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
|
||||
# Build Windows ARM
|
||||
- template: jobs/default-build.yml
|
||||
|
|
@ -98,6 +108,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Windows_arm_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
|
||||
# Build MacOS
|
||||
- template: jobs/default-build.yml
|
||||
|
|
@ -111,7 +122,8 @@ jobs:
|
|||
afterBuild:
|
||||
# Remove packages that are not rid-specific.
|
||||
# TODO add a flag so macOS/Linux builds only produce runtime packages
|
||||
- script: find artifacts/packages/ -type f -not -name 'runtime.*' -delete
|
||||
- script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -delete; fi
|
||||
condition: always()
|
||||
artifacts:
|
||||
- name: MacOS_x64_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -121,6 +133,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: MacOS_x64_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
- template: jobs/codesign-xplat.yml
|
||||
parameters:
|
||||
inputName: MacOS_x64
|
||||
|
|
@ -160,7 +173,8 @@ jobs:
|
|||
afterBuild:
|
||||
# Remove packages that are not rid-specific.
|
||||
# TODO add a flag so macOS/Linux builds only produce runtime packages
|
||||
- script: find artifacts/packages/ -type f -not -name 'runtime.*' -delete
|
||||
- script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -delete; fi
|
||||
condition: always()
|
||||
artifacts:
|
||||
- name: Linux_x64_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -170,6 +184,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Linux_x64_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
- template: jobs/codesign-xplat.yml
|
||||
parameters:
|
||||
inputName: Linux_x64
|
||||
|
|
@ -186,7 +201,8 @@ jobs:
|
|||
afterBuild:
|
||||
# Remove packages that are not rid-specific.
|
||||
# TODO add a flag so macOS/Linux builds only produce runtime packages
|
||||
- script: find artifacts/packages/ -type f -not -name 'runtime.*' -delete
|
||||
- script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -delete; fi
|
||||
condition: always()
|
||||
artifacts:
|
||||
- name: Linux_arm_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -196,6 +212,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Linux_arm_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
- template: jobs/codesign-xplat.yml
|
||||
parameters:
|
||||
inputName: Linux_arm
|
||||
|
|
@ -212,7 +229,8 @@ jobs:
|
|||
afterBuild:
|
||||
# Remove packages that are not rid-specific.
|
||||
# TODO add a flag so macOS/Linux builds only produce runtime packages
|
||||
- script: find artifacts/packages/ -type f -not -name 'runtime.*' -delete
|
||||
- script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -delete; fi
|
||||
condition: always()
|
||||
artifacts:
|
||||
- name: Linux_arm64_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -222,6 +240,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Linux_arm64_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
- template: jobs/codesign-xplat.yml
|
||||
parameters:
|
||||
inputName: Linux_arm64
|
||||
|
|
@ -238,7 +257,8 @@ jobs:
|
|||
afterBuild:
|
||||
# Remove packages that are not rid-specific.
|
||||
# TODO add a flag so macOS/Linux builds only produce runtime packages
|
||||
- script: find artifacts/packages/ -type f -not -name 'runtime.*' -delete
|
||||
- script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -delete; fi
|
||||
condition: always()
|
||||
artifacts:
|
||||
- name: Linux_musl_x64_Packages
|
||||
path: artifacts/packages/
|
||||
|
|
@ -248,6 +268,7 @@ jobs:
|
|||
path: artifacts/installers/
|
||||
- name: Linux_musl_x64_Logs
|
||||
path: artifacts/logs/
|
||||
publishOnError: true
|
||||
- template: jobs/codesign-xplat.yml
|
||||
parameters:
|
||||
inputName: Linux_musl_x64
|
||||
|
|
|
|||
|
|
@ -160,7 +160,7 @@ jobs:
|
|||
- ${{ each artifact in parameters.artifacts }}:
|
||||
- task: PublishBuildArtifacts@1
|
||||
displayName: Upload artifacts from ${{ artifact.path }}
|
||||
condition: or(eq(variables['system.pullrequest.isfork'], false), eq('${{ artifact.includeForks }}', 'true'))
|
||||
condition: and(or(succeeded(), eq('${{ artifact.publishOnError }}', 'true')), or(eq(variables['system.pullrequest.isfork'], false), eq('${{ artifact.includeForks }}', 'true')))
|
||||
continueOnError: true
|
||||
inputs:
|
||||
${{ if eq(parameters.buildDirectory, '') }}:
|
||||
|
|
|
|||
Loading…
Reference in New Issue