From 73e6742ba2a1226b4954bcd69deae6514106795d Mon Sep 17 00:00:00 2001
From: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
Date: Wed, 29 Aug 2018 12:53:17 -0700
Subject: [PATCH 1/3] Use gradle to detect java (#2888)

---
 build/repo.targets | 47 ++++++++++++++++++++++++----------------------
 1 file changed, 25 insertions(+), 22 deletions(-)

diff --git a/build/repo.targets b/build/repo.targets
index 85e3b13e5a..ffd96ceae7 100644
--- a/build/repo.targets
+++ b/build/repo.targets
@@ -10,29 +10,15 @@
     </NPMPackage>
   </ItemGroup>
 
-  <PropertyGroup Condition="'$(JAVA_HOME)' != ''">
-    <!-- Determine the path we need to search to find javac.exe -->
-    <JavacPath Condition="'$(OS)' == 'Windows_NT'">$(JAVA_HOME)\bin\javac.exe</JavacPath>
-    <JavacPath Condition="'$(OS)' != 'Windows_NT'">$(JAVA_HOME)/bin/javac</JavacPath>
-
-    <HasJdk Condition="Exists('$(JavacPath)')">true</HasJdk>
-
+  <PropertyGroup>
     <!-- Pass the Java Package Version down to Gradle -->
     <GradleOptions>-PpackageVersion="$(JavaPackageVersion)"</GradleOptions>
     <!-- Disable gradle daemon on CI since the CI seems to try to wait for the daemon to shut down, which it doesn't do :) -->
     <GradleOptions Condition="'$(CI)' == 'true'">$(GradleOptions) -Dorg.gradle.daemon=false</GradleOptions>
+
+    <RequireJava Condition="'$(CI)' == 'true'">true</RequireJava>
   </PropertyGroup>
 
-  <Target Name="EnsureJdkInstalled" BeforeTargets="GetToolsets" Condition=" '$(SkipJavaClient)' != 'true' ">
-    <Error Text="The JDK is required to build the SignalR repo on CI. Set the JAVA_HOME environment variable to the installation of the JDK"
-            Condition="'$(HasJdk)' != 'true' AND '$(CI)' == 'true' " />
-    
-    <Warning Text="The JDK is required to build the SignalR Java client. No JDK could be found so this will be skipped. Set the JAVA_HOME environment variable to the installation of the JDK"
-        Condition="'$(HasJdk)' != 'true' AND '$(CI)' != 'true' " />
-
-    <Message Text="Using Java from $(JavacPath)" Importance="high" />
-  </Target>
-
   <PropertyGroup>
     <RestoreDependsOn>$(RestoreDependsOn);RestoreNpm</RestoreDependsOn>
   </PropertyGroup>
@@ -58,7 +44,7 @@
     <Exec Command="npm run test:inner -- --no-color --configuration $(Configuration)" WorkingDirectory="$(RepositoryRoot)clients/ts/FunctionalTests" IgnoreStandardErrorWarningFormat="true" />
   </Target>
 
-  <Target Name="RunJavaTests" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
+  <Target Name="RunJavaTests" Condition="'$(HaveJava)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
     <Message Text="Running Java client tests" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) test" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) test" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" IgnoreStandardErrorWarningFormat="true" />
@@ -66,7 +52,6 @@
 
   <PropertyGroup>
     <GetArtifactInfoDependsOn>$(GetArtifactInfoDependsOn);GetNpmArtifactInfo;GetJavaArtifactInfo</GetArtifactInfoDependsOn>
-    <PrepareDependsOn>$(PrepareDependsOn);GetNpmArtifactInfo;GetJavaArtifactInfo</PrepareDependsOn>
   </PropertyGroup>
 
   <Target Name="GetNpmArtifactInfo">
@@ -91,7 +76,7 @@
   </Target>
 
   <Target Name="GetJavaArtifactInfo">
-    <ItemGroup Condition=" '$(SkipJavaClient)' != 'true' ">
+    <ItemGroup Condition="'$(SkipJavaClient)' != 'true'">
       <ArtifactInfo Include="$(BuildDir)\%(Jars.Identity)">
         <ArtifactType>JavaJar</ArtifactType>
         <Version>$(JavaClientVersion)</Version>
@@ -108,6 +93,24 @@
     </ItemGroup>
   </Target>
 
+  <PropertyGroup>
+    <PrepareDependsOn>DetectJava;$(PrepareDependsOn)</PrepareDependsOn>
+  </PropertyGroup>
+  <Target Name="DetectJava">
+    <Exec Command="./gradlew $(GradleOptions)" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" IgnoreExitCode="true" IgnoreStandardErrorWarningFormat="true">
+      <Output TaskParameter="ExitCode" PropertyName="JavaDetectExitCode" />
+    </Exec>
+
+    <Error Text="Failed to detect Java Runtime Environment (JRE)" Condition="'$(JavaDetectExitCode)' != 0 And '$(RequireJava)' == 'true'" />
+    <Message Text="Failed to detect Java Runtime Environment (JRE). Skipping Java client build." Importance="high" Condition="'$(JavaDetectExitCode)' != 0 And '$(RequireJava)' != 'true'" />
+    <Message Text="Successfully detected Java Runtime Environment (JRE)" Importance="high" Condition="'$(JavaDetectExitCode)' == 0" />
+    <!-- The build could still fail if the JDK isn't installed, but we can't reliably detect that without a bunch more code -->
+
+    <PropertyGroup Condition="'$(JavaDetectExitCode)' == '0'">
+      <HaveJava>true</HaveJava>
+    </PropertyGroup>
+  </Target>
+
   <PropertyGroup>
     <CompileDependsOn>Restore;BuildNPMPackages;$(CompileDependsOn);BuildJavaClient</CompileDependsOn>
   </PropertyGroup>
@@ -118,7 +121,7 @@
     <Exec Command="npm run build" WorkingDirectory="$(RepositoryRoot)clients/ts/FunctionalTests" IgnoreStandardErrorWarningFormat="true" />
   </Target>
 
-  <Target Name="BuildJavaClient" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' " DependsOnTargets="GetJavaArtifactInfo">
+  <Target Name="BuildJavaClient" Condition="'$(HaveJava)' == 'true' AND '$(SkipJavaClient)' != 'true' " DependsOnTargets="GetJavaArtifactInfo">
     <Message Text="Building Java client" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) compileJava" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) compileJava" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" />
@@ -143,7 +146,7 @@
     <JavaBuildFiles Include="@(Jars);@(PomFile)"/>
   </ItemGroup>
 
-  <Target Name="PackJavaClient" Condition="'$(HasJdk)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
+  <Target Name="PackJavaClient" Condition="'$(HaveJava)' == 'true' AND '$(SkipJavaClient)' != 'true' ">
     <Message Text="Packing Java client" Importance="high" />
     <Message Text="> gradlew $(GradleOptions) createPackage" Importance="high" />
     <Exec Command="./gradlew $(GradleOptions) createPackage" WorkingDirectory="$(RepositoryRoot)clients/java/signalr" />

From e2cc0e2a19f8cb87789cba953bb13afdcc331d05 Mon Sep 17 00:00:00 2001
From: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
Date: Wed, 29 Aug 2018 12:55:19 -0700
Subject: [PATCH 2/3] add --no-restore when building functional test proj
 (#2889)

---
 clients/ts/FunctionalTests/package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clients/ts/FunctionalTests/package.json b/clients/ts/FunctionalTests/package.json
index 34ab4d831e..bc2d8bb23a 100644
--- a/clients/ts/FunctionalTests/package.json
+++ b/clients/ts/FunctionalTests/package.json
@@ -39,7 +39,7 @@
     "build:lint": "node ../common/node_modules/tslint/bin/tslint -c ../tslint.json -p ./tsconfig.json",
     "build:webpack": "node ../common/node_modules/webpack-cli/bin/cli.js",
     "build:parent": "cd .. && npm run build",
-    "pretest": "npm run build:parent && npm run build && dotnet build",
+    "pretest": "npm run build:parent && npm run build && dotnet build --no-restore",
     "test": "npm run test:local --",
     "test:inner": "npm run build && dotnet build && npm run test:local --",
     "test:local": "ts-node --project ./scripts/tsconfig.json ./scripts/run-tests.ts",

From f91ba389077b43fcab85a9a31e5678229093295a Mon Sep 17 00:00:00 2001
From: Andrew Stanton-Nurse <andrew@stanton-nurse.com>
Date: Wed, 29 Aug 2018 12:55:57 -0700
Subject: [PATCH 3/3] fix chrome headless lag on Win7 (#2890)

---
 clients/ts/FunctionalTests/scripts/karma.local.conf.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/clients/ts/FunctionalTests/scripts/karma.local.conf.js b/clients/ts/FunctionalTests/scripts/karma.local.conf.js
index d9751a447b..3c127435b9 100644
--- a/clients/ts/FunctionalTests/scripts/karma.local.conf.js
+++ b/clients/ts/FunctionalTests/scripts/karma.local.conf.js
@@ -56,7 +56,9 @@ try {
       customLaunchers: {
         ChromeHeadlessNoSandbox: {
           base: 'ChromeHeadless',
-          flags: ['--no-sandbox']
+
+          // ChromeHeadless runs about 10x slower on Windows 7 machines without the --proxy switches below. Why? ¯\_(ツ)_/¯
+          flags: ["--no-sandbox", "--proxy-server='direct://'", "--proxy-bypass-list=*"]
         }
       },
     });