huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Skipping flaky test" 

This reverts commit 680c069554fd2a184b8a3030711aed35d4293c4b.
This commit is contained in:
Pranav K 2019-03-01 11:40:58 -08:00
parent 0add673139
commit 44c66c8314
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs
View File

@ -23,6 +23,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
protected override HttpClient Client { get; } protected override HttpClient Client { get; }
[Theory] [Theory]
[InlineData(ChunkingCookieManager.DefaultChunkSize)] [InlineData(ChunkingCookieManager.DefaultChunkSize)]
[InlineData(ChunkingCookieManager.DefaultChunkSize * 1.5)] [InlineData(ChunkingCookieManager.DefaultChunkSize * 1.5)]

18
src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs
View File

@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
{ {
protected abstract HttpClient Client { get; } protected abstract HttpClient Client { get; }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task PersistsJustForNextRequest() public async Task PersistsJustForNextRequest()
{ {
// Arrange // Arrange
@ -47,7 +47,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task ViewRendersTempData() public async Task ViewRendersTempData()
{ {
// Arrange // Arrange
@ -66,7 +66,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal("Foo", body); Assert.Equal("Foo", body);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task Redirect_RetainsTempData_EvenIfAccessed() public async Task Redirect_RetainsTempData_EvenIfAccessed()
{ {
// Arrange // Arrange
@ -97,7 +97,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal("Foo", body); Assert.Equal("Foo", body);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task Peek_RetainsTempData() public async Task Peek_RetainsTempData()
{ {
// Arrange // Arrange
@ -130,7 +130,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal("Foo", body); Assert.Equal("Foo", body);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task ValidTypes_RoundTripProperly() public async Task ValidTypes_RoundTripProperly()
{ {
// Arrange // Arrange
@ -162,7 +162,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal($"Foo 10 3 10/10/2010 00:00:00 {testGuid.ToString()}", body); Assert.Equal($"Foo 10 3 10/10/2010 00:00:00 {testGuid.ToString()}", body);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task ResponseWrite_DoesNotCrashSaveTempDataFilter() public async Task ResponseWrite_DoesNotCrashSaveTempDataFilter()
{ {
// Arrange // Arrange
@ -176,7 +176,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
var response = await Client.GetAsync("/TempData/SetTempDataResponseWrite"); var response = await Client.GetAsync("/TempData/SetTempDataResponseWrite");
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task SetInActionResultExecution_AvailableForNextRequest() public async Task SetInActionResultExecution_AvailableForNextRequest()
{ {
// Arrange // Arrange
@ -207,7 +207,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task SaveTempDataFilter_DoesNotSaveTempData_OnUnhandledException() public async Task SaveTempDataFilter_DoesNotSaveTempData_OnUnhandledException()
{ {
// Arrange & Act // Arrange & Act
@ -225,7 +225,7 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode); Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
} }
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")] [Fact]
public async Task SaveTempDataFilter_DoesNotSaveTempData_OnHandledExceptions() public async Task SaveTempDataFilter_DoesNotSaveTempData_OnHandledExceptions()
{ {
// Arrange & Act // Arrange & Act