diff --git a/src/Security/Authentication/Cookies/src/CookieExtensions.cs b/src/Security/Authentication/Cookies/src/CookieExtensions.cs index 4c41f54a9c..7763e6a624 100644 --- a/src/Security/Authentication/Cookies/src/CookieExtensions.cs +++ b/src/Security/Authentication/Cookies/src/CookieExtensions.cs @@ -26,6 +26,7 @@ namespace Microsoft.Extensions.DependencyInjection public static AuthenticationBuilder AddCookie(this AuthenticationBuilder builder, string authenticationScheme, string displayName, Action configureOptions) { builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton, PostConfigureCookieAuthenticationOptions>()); + builder.Services.AddOptions(authenticationScheme).Validate(o => o.Cookie.Expiration == null, "Cookie.Expiration is ignored, use ExpireTimeSpan instead."); return builder.AddScheme(authenticationScheme, displayName, configureOptions); } } diff --git a/src/Security/Authentication/test/CookieTests.cs b/src/Security/Authentication/test/CookieTests.cs index 504a264b41..4a72567844 100644 --- a/src/Security/Authentication/test/CookieTests.cs +++ b/src/Security/Authentication/test/CookieTests.cs @@ -17,6 +17,7 @@ using Microsoft.AspNetCore.Http; using Microsoft.AspNetCore.TestHost; using Microsoft.AspNetCore.Testing.xunit; using Microsoft.Extensions.DependencyInjection; +using Microsoft.Extensions.Options; using Xunit; namespace Microsoft.AspNetCore.Authentication.Cookies @@ -140,20 +141,15 @@ namespace Microsoft.AspNetCore.Authentication.Cookies } [Fact] - public async Task CookieExpirationOptionIsIgnored() + public void SettingCookieExpirationOptionThrows() { - var server = CreateServerWithServices(s => s.AddAuthentication().AddCookie(o => + var services = new ServiceCollection(); + services.AddAuthentication().AddCookie(o => { - o.Cookie.Name = "TestCookie"; - // this is currently ignored. Users should set o.ExpireTimeSpan instead o.Cookie.Expiration = TimeSpan.FromDays(10); - }), SignInAsAlice); - - var transaction = await SendAsync(server, "http://example.com/testpath"); - - var setCookie = transaction.SetCookie; - Assert.StartsWith("TestCookie=", setCookie); - Assert.DoesNotContain("; expires=", setCookie); + }); + var options = services.BuildServiceProvider().GetRequiredService>(); + Assert.Throws(() => options.Get(CookieAuthenticationDefaults.AuthenticationScheme)); } [Fact]