React to aspnet/Configuration #194

This commit is contained in:
Kirthi Krishnamraju 2015-05-22 04:58:56 -07:00
parent 2168176149
commit 4289542996
5 changed files with 20 additions and 13 deletions

View File

@ -23,14 +23,16 @@ namespace Microsoft.AspNet.Hosting
public void Main(string[] args) public void Main(string[] args)
{ {
// Allow the location of the ini file to be specfied via a --config command line arg // Allow the location of the ini file to be specfied via a --config command line arg
var tempConfig = new ConfigurationSection().AddCommandLine(args); var tempBuilder = new ConfigurationBuilder().AddCommandLine(args);
var tempConfig = tempBuilder.Build();
var configFilePath = tempConfig[ConfigFileKey] ?? HostingIniFile; var configFilePath = tempConfig[ConfigFileKey] ?? HostingIniFile;
var appBasePath = _serviceProvider.GetRequiredService<IApplicationEnvironment>().ApplicationBasePath; var appBasePath = _serviceProvider.GetRequiredService<IApplicationEnvironment>().ApplicationBasePath;
var config = new ConfigurationSection(appBasePath); var builder = new ConfigurationBuilder(appBasePath);
config.AddIniFile(configFilePath, optional: true); builder.AddIniFile(configFilePath, optional: true);
config.AddEnvironmentVariables(); builder.AddEnvironmentVariables();
config.AddCommandLine(args); builder.AddCommandLine(args);
var config = builder.Build();
var host = new WebHostBuilder(_serviceProvider, config).Build(); var host = new WebHostBuilder(_serviceProvider, config).Build();
using (host.Start()) using (host.Start())

View File

@ -42,7 +42,8 @@ namespace Microsoft.AspNet.Hosting
private string _serverFactoryLocation; private string _serverFactoryLocation;
private IServerFactory _serverFactory; private IServerFactory _serverFactory;
public WebHostBuilder([NotNull] IServiceProvider services) : this(services, config: new ConfigurationSection()) { } public WebHostBuilder([NotNull] IServiceProvider services)
: this(services, config: new ConfigurationBuilder().Build()) { }
public WebHostBuilder([NotNull] IServiceProvider services, [NotNull] IConfiguration config) public WebHostBuilder([NotNull] IServiceProvider services, [NotNull] IConfiguration config)
{ {

View File

@ -79,7 +79,7 @@ namespace Microsoft.AspNet.TestHost
{ {
return new WebHostBuilder( return new WebHostBuilder(
services ?? CallContextServiceLocator.Locator.ServiceProvider, services ?? CallContextServiceLocator.Locator.ServiceProvider,
config ?? new ConfigurationSection()); config ?? new ConfigurationBuilder().Build());
} }
public static WebHostBuilder CreateBuilder() public static WebHostBuilder CreateBuilder()

View File

@ -50,8 +50,9 @@ namespace Microsoft.AspNet.Hosting
{ "server", "Microsoft.AspNet.Hosting.Tests" } { "server", "Microsoft.AspNet.Hosting.Tests" }
}; };
var config = new ConfigurationSection() var builder = new ConfigurationBuilder()
.Add(new MemoryConfigurationSource(vals)); .Add(new MemoryConfigurationSource(vals));
var config = builder.Build();
var host = CreateBuilder(config).Build(); var host = CreateBuilder(config).Build();
host.Start(); host.Start();
Assert.NotNull(host.ApplicationServices.GetRequiredService<IHostingEnvironment>()); Assert.NotNull(host.ApplicationServices.GetRequiredService<IHostingEnvironment>());
@ -65,8 +66,9 @@ namespace Microsoft.AspNet.Hosting
{ "Hosting:Server", "Microsoft.AspNet.Hosting.Tests" } { "Hosting:Server", "Microsoft.AspNet.Hosting.Tests" }
}; };
var config = new ConfigurationSection() var builder = new ConfigurationBuilder()
.Add(new MemoryConfigurationSource(vals)); .Add(new MemoryConfigurationSource(vals));
var config = builder.Build();
var host = CreateBuilder(config).Build(); var host = CreateBuilder(config).Build();
host.Start(); host.Start();
Assert.NotNull(host.ApplicationServices.GetRequiredService<IHostingEnvironment>()); Assert.NotNull(host.ApplicationServices.GetRequiredService<IHostingEnvironment>());
@ -155,8 +157,9 @@ namespace Microsoft.AspNet.Hosting
{ "ASPNET_ENV", "Staging" } { "ASPNET_ENV", "Staging" }
}; };
var config = new ConfigurationSection() var builder = new ConfigurationBuilder()
.Add(new MemoryConfigurationSource(vals)); .Add(new MemoryConfigurationSource(vals));
var config = builder.Build();
var engine = CreateBuilder(config).Build(); var engine = CreateBuilder(config).Build();
var env = engine.ApplicationServices.GetRequiredService<IHostingEnvironment>(); var env = engine.ApplicationServices.GetRequiredService<IHostingEnvironment>();
@ -171,8 +174,9 @@ namespace Microsoft.AspNet.Hosting
{ "Hosting:Environment", "Staging" } { "Hosting:Environment", "Staging" }
}; };
var config = new ConfigurationSection() var builder = new ConfigurationBuilder()
.Add(new MemoryConfigurationSource(vals)); .Add(new MemoryConfigurationSource(vals));
var config = builder.Build();
var engine = CreateBuilder(config).Build(); var engine = CreateBuilder(config).Build();
var env = engine.ApplicationServices.GetRequiredService<IHostingEnvironment>(); var env = engine.ApplicationServices.GetRequiredService<IHostingEnvironment>();
@ -382,7 +386,7 @@ namespace Microsoft.AspNet.Hosting
{ {
return new WebHostBuilder( return new WebHostBuilder(
CallContextServiceLocator.Locator.ServiceProvider, CallContextServiceLocator.Locator.ServiceProvider,
config ?? new ConfigurationSection()); config ?? new ConfigurationBuilder().Build());
} }
public IServerInformation Initialize(IConfiguration configuration) public IServerInformation Initialize(IConfiguration configuration)

View File

@ -37,7 +37,7 @@ namespace Microsoft.AspNet.TestHost
Assert.Throws<InvalidOperationException>( Assert.Throws<InvalidOperationException>(
() => TestServer.Create( () => TestServer.Create(
services, services,
new ConfigurationSection(), new Startup().Configure, configureServices: null)); new ConfigurationBuilder().Build(), new Startup().Configure, configureServices: null));
} }
[Fact] [Fact]