From 406d8f9a8102e9f35f724629633a766491dddecc Mon Sep 17 00:00:00 2001 From: Ben Adams Date: Mon, 9 Apr 2018 07:28:37 +0100 Subject: [PATCH] readonly readonly structs (#1908) --- src/Common/ForceAsyncAwaiter.cs | 4 ++-- .../Internal/TaskExtensions.cs | 2 +- .../Internal/AwaitableThreadPool.cs | 2 +- src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Common/ForceAsyncAwaiter.cs b/src/Common/ForceAsyncAwaiter.cs index 4c0a66da68..670fa00786 100644 --- a/src/Common/ForceAsyncAwaiter.cs +++ b/src/Common/ForceAsyncAwaiter.cs @@ -26,7 +26,7 @@ namespace System.Threading.Tasks } } - internal struct ForceAsyncAwaiter : ICriticalNotifyCompletion + internal readonly struct ForceAsyncAwaiter : ICriticalNotifyCompletion { private readonly Task _task; @@ -50,7 +50,7 @@ namespace System.Threading.Tasks } } - internal struct ForceAsyncAwaiter : ICriticalNotifyCompletion + internal readonly struct ForceAsyncAwaiter : ICriticalNotifyCompletion { private readonly Task _task; diff --git a/src/Microsoft.AspNetCore.Http.Connections.Client/Internal/TaskExtensions.cs b/src/Microsoft.AspNetCore.Http.Connections.Client/Internal/TaskExtensions.cs index c79e2f66c4..c0c6965542 100644 --- a/src/Microsoft.AspNetCore.Http.Connections.Client/Internal/TaskExtensions.cs +++ b/src/Microsoft.AspNetCore.Http.Connections.Client/Internal/TaskExtensions.cs @@ -14,7 +14,7 @@ namespace System.Threading.Tasks } } - internal struct NoThrowAwaiter : ICriticalNotifyCompletion + internal readonly struct NoThrowAwaiter : ICriticalNotifyCompletion { private readonly Task _task; public NoThrowAwaiter(Task task) { _task = task; } diff --git a/src/Microsoft.AspNetCore.Http.Connections/Internal/AwaitableThreadPool.cs b/src/Microsoft.AspNetCore.Http.Connections/Internal/AwaitableThreadPool.cs index 81c6108189..d4b14df268 100644 --- a/src/Microsoft.AspNetCore.Http.Connections/Internal/AwaitableThreadPool.cs +++ b/src/Microsoft.AspNetCore.Http.Connections/Internal/AwaitableThreadPool.cs @@ -16,7 +16,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal return new Awaitable(); } - public struct Awaitable : ICriticalNotifyCompletion + public readonly struct Awaitable : ICriticalNotifyCompletion { public void GetResult() { diff --git a/src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs b/src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs index c1b311d7dd..606533ed58 100644 --- a/src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs +++ b/src/Microsoft.AspNetCore.SignalR.Client.Core/HubConnection.cs @@ -807,7 +807,7 @@ namespace Microsoft.AspNetCore.SignalR.Client } } - private struct InvocationHandler + private readonly struct InvocationHandler { public Type[] ParameterTypes { get; } private readonly Func _callback;