diff --git a/Mvc.sln b/Mvc.sln
index 92a04cd37c..f6a565c1a7 100644
--- a/Mvc.sln
+++ b/Mvc.sln
@@ -13,6 +13,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "test", "test", "{3BA657BF-2
ProjectSection(SolutionItems) = preProject
test\Directory.Build.props = test\Directory.Build.props
test\Directory.Build.targets = test\Directory.Build.targets
+ test\MvcTests.ruleset = test\MvcTests.ruleset
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc", "src\Microsoft.AspNetCore.Mvc\Microsoft.AspNetCore.Mvc.csproj", "{079EFA1F-0B0A-4853-B27B-5780D111CD85}"
diff --git a/build/dependencies.props b/build/dependencies.props
index 13696ffdb4..9db4a00489 100644
--- a/build/dependencies.props
+++ b/build/dependencies.props
@@ -14,8 +14,9 @@
2.0.0-*
2.3.1
2.0.0-*
- 15.3.0-*
+ 15.3.0
5.2.2
- 2.3.0-beta2-*
+ 2.3.0-beta4-build3742
+ 0.6.1
diff --git a/test/Directory.Build.props b/test/Directory.Build.props
index 3d7bd86234..ec72533796 100644
--- a/test/Directory.Build.props
+++ b/test/Directory.Build.props
@@ -3,5 +3,7 @@
false
+ xUnit1026:$(WarningsNotAsErrors)
+ $(MSBuildThisFileDirectory)MvcTests.ruleset
diff --git a/test/Directory.Build.targets b/test/Directory.Build.targets
index f6198dfe39..5c49d2f8a3 100644
--- a/test/Directory.Build.targets
+++ b/test/Directory.Build.targets
@@ -9,6 +9,7 @@
+
diff --git a/test/Microsoft.AspNetCore.Mvc.Abstractions.Test/ModelBinding/ModelStateDictionaryTest.cs b/test/Microsoft.AspNetCore.Mvc.Abstractions.Test/ModelBinding/ModelStateDictionaryTest.cs
index dd69d69f1c..90abb75dd2 100644
--- a/test/Microsoft.AspNetCore.Mvc.Abstractions.Test/ModelBinding/ModelStateDictionaryTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Abstractions.Test/ModelBinding/ModelStateDictionaryTest.cs
@@ -1037,13 +1037,13 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
dictionary.ClearValidationState("Property4");
// Assert
- Assert.Equal(0, dictionary["Property1"].Errors.Count);
+ Assert.Empty(dictionary["Property1"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property1"].ValidationState);
- Assert.Equal(0, dictionary["Property2"].Errors.Count);
+ Assert.Empty(dictionary["Property2"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property2"].ValidationState);
- Assert.Equal(1, dictionary["Property3"].Errors.Count);
+ Assert.Single(dictionary["Property3"].Errors);
Assert.Equal(ModelValidationState.Invalid, dictionary["Property3"].ValidationState);
- Assert.Equal(0, dictionary["Property4"].Errors.Count);
+ Assert.Empty(dictionary["Property4"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property4"].ValidationState);
}
@@ -1064,19 +1064,19 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
dictionary.ClearValidationState("Product");
// Assert
- Assert.Equal(0, dictionary["Product"].Errors.Count);
+ Assert.Empty(dictionary["Product"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail1"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail1"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail1"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail2[0]"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail2[0]"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail2[0]"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail2[1]"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail2[1]"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail2[1]"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail2[2]"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail2[2]"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail2[2]"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail3"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail3"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail3"].ValidationState);
- Assert.Equal(1, dictionary["ProductName"].Errors.Count);
+ Assert.Single(dictionary["ProductName"].Errors);
Assert.Equal(ModelValidationState.Invalid, dictionary["ProductName"].ValidationState);
}
@@ -1095,9 +1095,9 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
// Assert
Assert.Equal(ModelValidationState.Valid, dictionary["Product"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail1"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail1"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail1"].ValidationState);
- Assert.Equal(0, dictionary["Product.Detail1.Name"].Errors.Count);
+ Assert.Empty(dictionary["Product.Detail1.Name"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Product.Detail1.Name"].ValidationState);
Assert.Equal(ModelValidationState.Skipped, dictionary["Product.Detail1Name"].ValidationState);
}
@@ -1118,13 +1118,13 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
dictionary.ClearValidationState(modelKey);
// Assert
- Assert.Equal(0, dictionary["Property1"].Errors.Count);
+ Assert.Empty(dictionary["Property1"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property1"].ValidationState);
- Assert.Equal(0, dictionary["Property2"].Errors.Count);
+ Assert.Empty(dictionary["Property2"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property2"].ValidationState);
- Assert.Equal(0, dictionary["Property3"].Errors.Count);
+ Assert.Empty(dictionary["Property3"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property3"].ValidationState);
- Assert.Equal(0, dictionary["Property4"].Errors.Count);
+ Assert.Empty(dictionary["Property4"].Errors);
Assert.Equal(ModelValidationState.Unvalidated, dictionary["Property4"].ValidationState);
}
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Authorization/AuthorizeFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Authorization/AuthorizeFilterTest.cs
index f1979a60ea..3429bad91e 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Authorization/AuthorizeFilterTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Authorization/AuthorizeFilterTest.cs
@@ -23,7 +23,7 @@ namespace Microsoft.AspNetCore.Mvc.Authorization
public void InvalidUser()
{
var authorizationContext = GetAuthorizationContext();
- Assert.True(authorizationContext.HttpContext.User.Identities.Any(i => i.IsAuthenticated));
+ Assert.Contains(authorizationContext.HttpContext.User.Identities, i => i.IsAuthenticated);
}
[Fact]
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/BadRequestObjectResultTests.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/BadRequestObjectResultTests.cs
index 153cfc27d0..453575e5bf 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/BadRequestObjectResultTests.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/BadRequestObjectResultTests.cs
@@ -30,7 +30,7 @@ namespace Microsoft.AspNetCore.Mvc
// Assert
Assert.Equal(StatusCodes.Status400BadRequest, badRequestObjecResult.StatusCode);
var errors = Assert.IsType(badRequestObjecResult.Value);
- Assert.Equal(0, errors.Count);
+ Assert.Empty(errors);
}
}
}
\ No newline at end of file
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/ControllerBaseTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/ControllerBaseTest.cs
index 11a35576cf..b2b9e5c339 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/ControllerBaseTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/ControllerBaseTest.cs
@@ -1987,7 +1987,7 @@ namespace Microsoft.AspNetCore.Mvc.Core.Test
Assert.IsType(result);
Assert.Equal(StatusCodes.Status400BadRequest, result.StatusCode);
var errors = Assert.IsType(result.Value);
- Assert.Equal(0, errors.Count);
+ Assert.Empty(errors);
}
[Theory]
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/FileResultTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/FileResultTest.cs
index 55c86fd3cc..a16d207956 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/FileResultTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/FileResultTest.cs
@@ -153,7 +153,7 @@ namespace Microsoft.AspNetCore.Mvc
await result.ExecuteResultAsync(actionContext);
// Assert
- Assert.Equal(1, loggerSink.Writes.Count);
+ Assert.Single(loggerSink.Writes);
}
public static TheoryData ContentDispositionData
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatFilterTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatFilterTest.cs
index ee1268d2fd..be2a8d01a3 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatFilterTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatFilterTest.cs
@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var objectResult = Assert.IsType(resultExecutingContext.Result);
- Assert.Equal(1, objectResult.ContentTypes.Count);
+ Assert.Single(objectResult.ContentTypes);
MediaTypeAssert.Equal(mediaType, objectResult.ContentTypes[0]);
}
@@ -100,7 +100,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var objectResult = Assert.IsType(resultExecutingContext.Result);
- Assert.Equal(1, objectResult.ContentTypes.Count);
+ Assert.Single(objectResult.ContentTypes);
MediaTypeAssert.Equal(mediaType, objectResult.ContentTypes[0]);
}
@@ -132,7 +132,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var objectResult = Assert.IsType(resultExecutingContext.Result);
- Assert.Equal(1, objectResult.ContentTypes.Count);
+ Assert.Single(objectResult.ContentTypes);
MediaTypeAssert.Equal(mediaType, objectResult.ContentTypes[0]);
}
@@ -336,7 +336,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var result = Assert.IsType(resultExecutingContext.Result);
- Assert.Equal(1, result.ContentTypes.Count);
+ Assert.Single(result.ContentTypes);
MediaTypeAssert.Equal(mediaType, result.ContentTypes[0]);
}
@@ -371,7 +371,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var result = Assert.IsType(resultExecutingContext.Result);
- Assert.Equal(0, result.ContentTypes.Count);
+ Assert.Empty(result.ContentTypes);
}
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatterCollectionTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatterCollectionTest.cs
index 79922d1d62..81b532a3ad 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatterCollectionTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/FormatterCollectionTest.cs
@@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var formatter = Assert.Single(collection);
- Assert.IsType(typeof(AnotherTestOutputFormatter), formatter);
+ Assert.IsType(formatter);
}
[Fact]
@@ -45,7 +45,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
// Assert
var formatter = Assert.Single(collection);
- Assert.IsType(typeof(AnotherTestOutputFormatter), formatter);
+ Assert.IsType(formatter);
}
private class TestOutputFormatter : TextOutputFormatter
diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/MediaTypeTest.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/MediaTypeTest.cs
index 1b6524085c..28591cf017 100644
--- a/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/MediaTypeTest.cs
+++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/Formatters/MediaTypeTest.cs
@@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters
Assert.Equal(new StringSegment("json"), result.SubType);
}
- public static IEnumerable MediaTypesWithSuffixes
+ public static IEnumerable