huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Unquarantine some tests (#24075) 

* Unquarantine some tests

* Quarantine

* Link issue
This commit is contained in:
Ajay Bhargav B 2020-07-17 16:33:19 -07:00 committed by GitHub
parent a8bc7ba612
commit 39859c0c18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Analyzers/Internal.AspNetCore.Analyzers/test/PubternabilityAnalyzerTests.cs
View File

@ -34,7 +34,7 @@ namespace A.Internal.Namespace
[Theory] [Theory]
[MemberData(nameof(PublicMemberDefinitions))] [MemberData(nameof(PublicMemberDefinitions))]
[QuarantinedTest] [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/22440")]
public async Task PublicExposureOfPubternalTypeProducesPUB0001(string member) public async Task PublicExposureOfPubternalTypeProducesPUB0001(string member)
{ {
var code = GetSourceFromNamespaceDeclaration($@" var code = GetSourceFromNamespaceDeclaration($@"

2
src/Hosting/Hosting/test/WebHostTests.cs
View File

@ -198,7 +198,6 @@ namespace Microsoft.AspNetCore.Hosting
} }
[ConditionalFact] [ConditionalFact]
[QuarantinedTest]
public async Task WebHostStopAsyncUsesDefaultTimeoutIfGivenTokenDoesNotFire() public async Task WebHostStopAsyncUsesDefaultTimeoutIfGivenTokenDoesNotFire()
{ {
var data = new Dictionary<string, string> var data = new Dictionary<string, string>
@ -313,7 +312,6 @@ namespace Microsoft.AspNetCore.Hosting
} }
[ConditionalFact] [ConditionalFact]
[QuarantinedTest]
public void WebHostApplicationLifetimeEventsOrderedCorrectlyDuringShutdown() public void WebHostApplicationLifetimeEventsOrderedCorrectlyDuringShutdown()
{ {
using (var host = CreateBuilder() using (var host = CreateBuilder()

2
src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs
View File

@ -109,7 +109,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
} }
[Theory] [Theory]
[MemberData(nameof(LargeUploadData))] [MemberData(nameof(LargeUploadData))]
[QuarantinedTest] [QuarantinedTest] // This is inherently flaky and should never be unquarantined.
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause) public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
{ {
// Parameters // Parameters