From 39164eeb40df48279f5f2b4da63b75ca9ac1e934 Mon Sep 17 00:00:00 2001 From: Cesar Blum Silveira Date: Wed, 5 Apr 2017 11:23:54 -0700 Subject: [PATCH] Simplify WebHostBuilderTests.CanUseCustomLoggerFactory. - Keep all the code in the test itself, instead of in an extension method. Makes it easier to understand what's happening without having to look up the extension method's definition. --- .../Fakes/CustomLoggerFactory.cs | 10 ---------- .../WebHostBuilderTests.cs | 3 ++- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/test/Microsoft.AspNetCore.Hosting.Tests/Fakes/CustomLoggerFactory.cs b/test/Microsoft.AspNetCore.Hosting.Tests/Fakes/CustomLoggerFactory.cs index c09d42a579..9fa7cf2151 100644 --- a/test/Microsoft.AspNetCore.Hosting.Tests/Fakes/CustomLoggerFactory.cs +++ b/test/Microsoft.AspNetCore.Hosting.Tests/Fakes/CustomLoggerFactory.cs @@ -18,16 +18,6 @@ namespace Microsoft.AspNetCore.Hosting.Fakes public void Dispose() { } } - public static class CustomLoggerFactoryExtensions - { - public static IWebHostBuilder ConfigureCustomLogger(this IWebHostBuilder builder, Action configureLogger) - { - builder.UseLoggerFactory(_ => new CustomLoggerFactory()); - builder.ConfigureLogging(configureLogger); - return builder; - } - } - public class SubLoggerFactory : CustomLoggerFactory { } public class NonSubLoggerFactory : ILoggerFactory diff --git a/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs b/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs index f8e8a4d89b..36211ed450 100644 --- a/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs +++ b/test/Microsoft.AspNetCore.Hosting.Tests/WebHostBuilderTests.cs @@ -294,7 +294,8 @@ namespace Microsoft.AspNetCore.Hosting public void CanUseCustomLoggerFactory() { var hostBuilder = new WebHostBuilder() - .ConfigureCustomLogger(factory => + .UseLoggerFactory(_ => new CustomLoggerFactory()) + .ConfigureLogging(factory => { factory.CustomConfigureMethod(); })