From 383a272f36c26befbdcdb478c7d2b724c0096fd8 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Fri, 7 Aug 2020 16:16:53 -0700 Subject: [PATCH] Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents (#24691) * Quarantine falky test ServerEventTest.EventDuringBatchRendering_CanTriggerDOMEvents Blazor's E2E testing uses a much shorter timeout after a test failure. This test run had several test failures, but most of these appear to be the result of an incredibly short timeot. This PR quarantines the one test that appears to be a genuine failure and also increases the timeout duration for after test failure. * Quarantine ServerExecutionTests.ServerGlobalizationTest.CanSetCultureAndParseCultureSensitiveNumbersAndDates --- .../ServerExecutionTests/ServerEventTest.cs | 28 +++++++++++++++++++ .../ServerGlobalizationTest.cs | 10 +++++++ .../ServerExecutionTests/TestSubclasses.cs | 8 ------ .../test/E2ETest/Tests/EventTest.cs | 2 +- .../test/E2ETest/Tests/GlobalizationTest.cs | 2 +- src/Shared/E2ETesting/E2ETestOptions.cs | 2 +- 6 files changed, 41 insertions(+), 11 deletions(-) create mode 100644 src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs new file mode 100644 index 0000000000..25dc2dc71f --- /dev/null +++ b/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs @@ -0,0 +1,28 @@ +// Copyright (c) .NET Foundation. All rights reserved. +// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. + +using BasicTestApp; +using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; +using Microsoft.AspNetCore.Components.E2ETest.Tests; +using Microsoft.AspNetCore.E2ETesting; +using Microsoft.AspNetCore.Testing; +using Xunit; +using Xunit.Abstractions; + +namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests +{ + public class ServerEventTest : EventTest + { + public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture serverFixture, ITestOutputHelper output) + : base(browserFixture, serverFixture.WithServerExecution(), output) + { + } + + [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24688")] + public override void EventDuringBatchRendering_CanTriggerDOMEvents() + { + base.EventDuringBatchRendering_CanTriggerDOMEvents(); + } + } +} diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs index 96f2aa67a2..c0b473267d 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/ServerGlobalizationTest.cs @@ -6,6 +6,7 @@ using BasicTestApp; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.Components.E2ETests.Tests; using Microsoft.AspNetCore.E2ETesting; +using Microsoft.AspNetCore.Testing; using OpenQA.Selenium; using OpenQA.Selenium.Support.UI; using TestServer; @@ -33,6 +34,15 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests Browser.Exists(By.Id("culture-selector")); } + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/24692")] + [Theory] + [InlineData("en-US")] + [InlineData("fr-FR")] + public override void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture) + { + base.CanSetCultureAndParseCultureSensitiveNumbersAndDates(culture); + } + protected override void SetCulture(string culture) { var selector = new SelectElement(Browser.FindElement(By.Id("culture-selector"))); diff --git a/src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs b/src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs index dbd84edfa6..c418d9e7b5 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/TestSubclasses.cs @@ -25,14 +25,6 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests } } - public class ServerEventTest : EventTest - { - public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture serverFixture, ITestOutputHelper output) - : base(browserFixture, serverFixture.WithServerExecution(), output) - { - } - } - public class ServerInteropTest : InteropTest { public ServerInteropTest(BrowserFixture browserFixture, ToggleExecutionModeServerFixture serverFixture, ITestOutputHelper output) diff --git a/src/Components/test/E2ETest/Tests/EventTest.cs b/src/Components/test/E2ETest/Tests/EventTest.cs index 7a22cd2366..dc79d8097a 100644 --- a/src/Components/test/E2ETest/Tests/EventTest.cs +++ b/src/Components/test/E2ETest/Tests/EventTest.cs @@ -258,7 +258,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests } [Fact] - public void EventDuringBatchRendering_CanTriggerDOMEvents() + public virtual void EventDuringBatchRendering_CanTriggerDOMEvents() { Browser.MountTestComponent(); diff --git a/src/Components/test/E2ETest/Tests/GlobalizationTest.cs b/src/Components/test/E2ETest/Tests/GlobalizationTest.cs index 2428dd744c..3576c4de90 100644 --- a/src/Components/test/E2ETest/Tests/GlobalizationTest.cs +++ b/src/Components/test/E2ETest/Tests/GlobalizationTest.cs @@ -26,7 +26,7 @@ namespace Microsoft.AspNetCore.Components.E2ETests.Tests [Theory] [InlineData("en-US")] [InlineData("fr-FR")] - public void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture) + public virtual void CanSetCultureAndParseCultureSensitiveNumbersAndDates(string culture) { var cultureInfo = CultureInfo.GetCultureInfo(culture); SetCulture(culture); diff --git a/src/Shared/E2ETesting/E2ETestOptions.cs b/src/Shared/E2ETesting/E2ETestOptions.cs index 328623c122..07d87a9a3b 100644 --- a/src/Shared/E2ETesting/E2ETestOptions.cs +++ b/src/Shared/E2ETesting/E2ETestOptions.cs @@ -55,7 +55,7 @@ namespace Microsoft.AspNetCore.E2ETesting public string ScreenShotsPath { get; set; } - public double DefaultAfterFailureWaitTimeoutInSeconds { get; set; } = 3; + public double DefaultAfterFailureWaitTimeoutInSeconds { get; set; } = 10; public bool SauceTest { get; set; }