From 36674b5d24d35cb5c07f0f53e54488d188650af9 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Tue, 7 Nov 2017 12:43:40 -0800 Subject: [PATCH] Fix failing tests * Specify RIDs for SimpleApp * Default to the RID \ PlatformTarget that the SDK chooses (viz win7-x86 for .NET Framework) * Default Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj to win7-x86 and remove extraneous project under the tools directory to simplify the build. --- RazorViewCompilation.sln | 15 ----------- ...spNetCore.Mvc.Razor.ViewCompilation.csproj | 26 +++++++++++++++---- ...Core.Mvc.Razor.ViewCompilation.Test.csproj | 1 - ...ionUsingPrecompiledViewClassLibrary.csproj | 1 - .../ApplicationUsingRelativePaths.csproj | 1 - .../ApplicationWithConfigureMvc.csproj | 1 - .../ApplicationWithCustomInputFiles.csproj | 1 - .../ApplicationWithParseErrors.csproj | 1 - .../ApplicationWithTagHelpers.csproj | 1 - .../ClassLibraryWithPrecompiledViews.csproj | 1 - testapps/Directory.Build.targets | 2 +- .../PublishWithEmbedViewSources.csproj | 1 - testapps/RazorPagesApp/RazorPagesApp.csproj | 1 - testapps/SimpleApp/SimpleApp.csproj | 2 +- .../SimpleAppWithAssemblyRename.csproj | 1 - testapps/StrongNamedApp/StrongNamedApp.csproj | 1 - tools/Directory.Build.props | 7 ----- ...tCore.Mvc.Razor.ViewCompilation-x86.csproj | 23 ---------------- 18 files changed, 23 insertions(+), 64 deletions(-) delete mode 100644 tools/Directory.Build.props delete mode 100644 tools/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.csproj diff --git a/RazorViewCompilation.sln b/RazorViewCompilation.sln index 7f3dba7315..a9acbeaa16 100644 --- a/RazorViewCompilation.sln +++ b/RazorViewCompilation.sln @@ -67,8 +67,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tools", "tools", "{75244EBD tools\Directory.Build.props = tools\Directory.Build.props EndProjectSection EndProject -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86", "tools\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.csproj", "{DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}" -EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Tasks", "src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Tasks\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Tasks.csproj", "{996D4DEB-1701-435E-8048-1E65790C2050}" EndProject Global @@ -273,18 +271,6 @@ Global {779BACC4-B20E-4F73-A9C7-350443CF1941}.Release|x64.Build.0 = Release|Any CPU {779BACC4-B20E-4F73-A9C7-350443CF1941}.Release|x86.ActiveCfg = Release|Any CPU {779BACC4-B20E-4F73-A9C7-350443CF1941}.Release|x86.Build.0 = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|Any CPU.Build.0 = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|x64.ActiveCfg = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|x64.Build.0 = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|x86.ActiveCfg = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Debug|x86.Build.0 = Debug|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|Any CPU.ActiveCfg = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|Any CPU.Build.0 = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|x64.ActiveCfg = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|x64.Build.0 = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|x86.ActiveCfg = Release|Any CPU - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D}.Release|x86.Build.0 = Release|Any CPU {996D4DEB-1701-435E-8048-1E65790C2050}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {996D4DEB-1701-435E-8048-1E65790C2050}.Debug|Any CPU.Build.0 = Debug|Any CPU {996D4DEB-1701-435E-8048-1E65790C2050}.Debug|x64.ActiveCfg = Debug|Any CPU @@ -318,7 +304,6 @@ Global {037F4B73-75FB-4570-A38A-9109B580168C} = {0DC7C88C-E3DB-46DF-B47E-AC5ECB2A16B7} {08552602-37E7-48A7-95A2-BB1A1F57C804} = {0DC7C88C-E3DB-46DF-B47E-AC5ECB2A16B7} {779BACC4-B20E-4F73-A9C7-350443CF1941} = {0DC7C88C-E3DB-46DF-B47E-AC5ECB2A16B7} - {DFB86DBD-17DA-4A97-A4FD-00D6E5160B3D} = {75244EBD-DFBD-4C4B-9543-C135AC142C7F} {996D4DEB-1701-435E-8048-1E65790C2050} = {02F7AA35-91AF-491E-9F0E-03CFAF86C720} EndGlobalSection GlobalSection(ExtensibilityGlobals) = postSolution diff --git a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj index 013353650c..1acbdc3bd8 100644 --- a/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj +++ b/src/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.csproj @@ -4,17 +4,24 @@ Build-time references required to enable Razor view compilation as part of building the application. netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 + cshtml;razor;compilation;precompilation;aspnetcore true exe - ..\..\tools\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86\ ..\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Tasks\ false + + win7-x86;win7-x64 + x86 + $(AssemblyName)-$(PlatformTarget) + false + bin\$(Configuration)\net461\win7-$(PlatformTarget) + obj\$(Configuration)\net461\win7-$(PlatformTarget) + + - @@ -30,8 +37,17 @@ - - + + + + + diff --git a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj index eae45ac67b..74c0b9d161 100644 --- a/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj +++ b/test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.Test.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 diff --git a/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj b/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj index 8f1b7d628f..9478314e47 100644 --- a/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj +++ b/testapps/ApplicationUsingPrecompiledViewClassLibrary/ApplicationUsingPrecompiledViewClassLibrary.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 ..\ClassLibraryWithPrecompiledViews\ClassLibraryWithPrecompiledViews.csproj diff --git a/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj b/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj index 3e094792f4..85a0a8df38 100644 --- a/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj +++ b/testapps/ApplicationUsingRelativePaths/ApplicationUsingRelativePaths.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true diff --git a/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj b/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj index f56ce8b676..4aee9fb627 100644 --- a/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj +++ b/testapps/ApplicationWithConfigureMvc/ApplicationWithConfigureMvc.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true $(DefineConstants);TEST123 diff --git a/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj b/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj index ec3f89e303..95c4f130ad 100644 --- a/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj +++ b/testapps/ApplicationWithCustomInputFiles/ApplicationWithCustomInputFiles.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true true diff --git a/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj b/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj index 3e094792f4..85a0a8df38 100644 --- a/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj +++ b/testapps/ApplicationWithParseErrors/ApplicationWithParseErrors.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true diff --git a/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj b/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj index 5b14e4f5ab..c6c8b6e41c 100644 --- a/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj +++ b/testapps/ApplicationWithTagHelpers/ApplicationWithTagHelpers.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true diff --git a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj index b4d8fab4d4..4ba7c2f5c3 100644 --- a/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj +++ b/testapps/ClassLibraryWithPrecompiledViews/ClassLibraryWithPrecompiledViews.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 obj\precompiled\$(TargetFramework) true diff --git a/testapps/Directory.Build.targets b/testapps/Directory.Build.targets index cfb86134ad..a56638ed5c 100644 --- a/testapps/Directory.Build.targets +++ b/testapps/Directory.Build.targets @@ -20,7 +20,7 @@ Condition="'$(TestIncludeViewCompilationTargets)'=='true'"> <_MvcViewCompilationBinaryPath Condition="'$(TargetFramework)'=='netcoreapp2.0'">$(MSBuildProjectDirectory)\$(OutputPath)Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.dll - <_MvcViewCompilationBinaryPath Condition="'$(TargetFramework)'=='net461'">$(MSBuildProjectDirectory)\$(OutputPath)Microsoft.AspNetCore.Mvc.Razor.ViewCompilation.exe + <_MvcViewCompilationBinaryPath Condition="'$(TargetFramework)'=='net461'">$(MSBuildProjectDirectory)\$(OutputPath)Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.exe diff --git a/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj b/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj index 8d5f02ce7f..9f3dc47490 100644 --- a/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj +++ b/testapps/PublishWithEmbedViewSources/PublishWithEmbedViewSources.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true true diff --git a/testapps/RazorPagesApp/RazorPagesApp.csproj b/testapps/RazorPagesApp/RazorPagesApp.csproj index aa8358b01f..9c7c5ab6b0 100644 --- a/testapps/RazorPagesApp/RazorPagesApp.csproj +++ b/testapps/RazorPagesApp/RazorPagesApp.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true diff --git a/testapps/SimpleApp/SimpleApp.csproj b/testapps/SimpleApp/SimpleApp.csproj index 3e094792f4..f5f65c45ca 100644 --- a/testapps/SimpleApp/SimpleApp.csproj +++ b/testapps/SimpleApp/SimpleApp.csproj @@ -3,7 +3,7 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 + win7-x86;debian-x64 true diff --git a/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj b/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj index 50dada77b1..bee405d99b 100644 --- a/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj +++ b/testapps/SimpleAppWithAssemblyRename/SimpleAppWithAssemblyRename.csproj @@ -4,7 +4,6 @@ NewAssemblyName netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true diff --git a/testapps/StrongNamedApp/StrongNamedApp.csproj b/testapps/StrongNamedApp/StrongNamedApp.csproj index 59da78d54e..d72479411d 100644 --- a/testapps/StrongNamedApp/StrongNamedApp.csproj +++ b/testapps/StrongNamedApp/StrongNamedApp.csproj @@ -3,7 +3,6 @@ netcoreapp2.0;net461 netcoreapp2.0 - win7-x64 true true true diff --git a/tools/Directory.Build.props b/tools/Directory.Build.props deleted file mode 100644 index 1e0980f663..0000000000 --- a/tools/Directory.Build.props +++ /dev/null @@ -1,7 +0,0 @@ - - - - - - - diff --git a/tools/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.csproj b/tools/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.csproj deleted file mode 100644 index 511e0d7839..0000000000 --- a/tools/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86/Microsoft.AspNetCore.Mvc.Razor.ViewCompilation-x86.csproj +++ /dev/null @@ -1,23 +0,0 @@ - - - - Build-time references required to enable Razor view compilation as part of building the application. - net461 - win7-x86 - exe - ..\..\src\Microsoft.AspNetCore.Mvc.Razor.ViewCompilation - - - - - - - - - - - - - - -