From 34ee0212d0c6de76a40609b70df77545dbdde3bf Mon Sep 17 00:00:00 2001 From: Hao Kung Date: Fri, 10 Jun 2016 15:37:08 -0700 Subject: [PATCH] Fix misc feedback --- .../AuthorizationHandlerContext.cs | 2 +- .../AuthorizationOptions.cs | 2 +- .../AuthorizationPolicy.cs | 6 +++--- .../AuthorizationServiceExtensions.cs | 8 ++++---- .../DefaultAuthorizationService.cs | 6 +++--- .../Infrastructure/AssertionRequirement.cs | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/Microsoft.AspNetCore.Authorization/AuthorizationHandlerContext.cs b/src/Microsoft.AspNetCore.Authorization/AuthorizationHandlerContext.cs index 65aafa2bb6..5dc57c278a 100644 --- a/src/Microsoft.AspNetCore.Authorization/AuthorizationHandlerContext.cs +++ b/src/Microsoft.AspNetCore.Authorization/AuthorizationHandlerContext.cs @@ -55,7 +55,7 @@ namespace Microsoft.AspNetCore.Authorization public object Resource { get; } /// - /// Gets the requirements that have not yet been succeeded. + /// Gets the requirements that have not yet been marked as succeeded. /// public IEnumerable PendingRequirements { get { return _pendingRequirements; } } diff --git a/src/Microsoft.AspNetCore.Authorization/AuthorizationOptions.cs b/src/Microsoft.AspNetCore.Authorization/AuthorizationOptions.cs index 5031c68b9e..fa9e9ef1ee 100644 --- a/src/Microsoft.AspNetCore.Authorization/AuthorizationOptions.cs +++ b/src/Microsoft.AspNetCore.Authorization/AuthorizationOptions.cs @@ -14,7 +14,7 @@ namespace Microsoft.AspNetCore.Authorization private IDictionary PolicyMap { get; } = new Dictionary(StringComparer.OrdinalIgnoreCase); /// - /// Gets or sets the default authoization policy. + /// Gets or sets the default authorization policy. /// /// /// The default policy is to require any authenticated user. diff --git a/src/Microsoft.AspNetCore.Authorization/AuthorizationPolicy.cs b/src/Microsoft.AspNetCore.Authorization/AuthorizationPolicy.cs index 41eb7aadeb..3fe0cdd070 100644 --- a/src/Microsoft.AspNetCore.Authorization/AuthorizationPolicy.cs +++ b/src/Microsoft.AspNetCore.Authorization/AuthorizationPolicy.cs @@ -52,7 +52,7 @@ namespace Microsoft.AspNetCore.Authorization public IReadOnlyList Requirements { get; } /// - /// Gets a readonly list of rhe authentication schemes the + /// Gets a readonly list of the authentication schemes the /// are evaluated against. /// public IReadOnlyList AuthenticationSchemes { get; } @@ -100,13 +100,13 @@ namespace Microsoft.AspNetCore.Authorization /// /// Combines the provided by the specified - /// + /// . /// /// A which provides the policies to combine. /// A collection of authorization data used to apply authorization to a resource. /// /// A new which represents the combination of the - /// authorization policies provided by specified . + /// authorization policies provided by the specified . /// public static async Task CombineAsync(IAuthorizationPolicyProvider policyProvider, IEnumerable authorizeData) { diff --git a/src/Microsoft.AspNetCore.Authorization/AuthorizationServiceExtensions.cs b/src/Microsoft.AspNetCore.Authorization/AuthorizationServiceExtensions.cs index 197e89cf8d..3b78c952eb 100644 --- a/src/Microsoft.AspNetCore.Authorization/AuthorizationServiceExtensions.cs +++ b/src/Microsoft.AspNetCore.Authorization/AuthorizationServiceExtensions.cs @@ -22,7 +22,7 @@ namespace Microsoft.AspNetCore.Authorization /// The requirement to evaluate the policy against. /// /// A flag indicating whether requirement evaluation has succeeded or failed. - /// This value is true when the user fulfills the policy otherwise false. + /// This value is true when the user fulfills the policy, otherwise false. /// public static Task AuthorizeAsync(this IAuthorizationService service, ClaimsPrincipal user, object resource, IAuthorizationRequirement requirement) { @@ -48,7 +48,7 @@ namespace Microsoft.AspNetCore.Authorization /// The policy to evaluate. /// /// A flag indicating whether policy evaluation has succeeded or failed. - /// This value is true when the user fulfills the policy otherwise false. + /// This value is true when the user fulfills the policy, otherwise false. /// public static Task AuthorizeAsync(this IAuthorizationService service, ClaimsPrincipal user, object resource, AuthorizationPolicy policy) { @@ -73,7 +73,7 @@ namespace Microsoft.AspNetCore.Authorization /// The policy to evaluate. /// /// A flag indicating whether policy evaluation has succeeded or failed. - /// This value is true when the user fulfills the policy otherwise false. + /// This value is true when the user fulfills the policy, otherwise false. /// public static Task AuthorizeAsync(this IAuthorizationService service, ClaimsPrincipal user, AuthorizationPolicy policy) { @@ -98,7 +98,7 @@ namespace Microsoft.AspNetCore.Authorization /// The name of the policy to evaluate. /// /// A flag indicating whether policy evaluation has succeeded or failed. - /// This value is true when the user fulfills the policy otherwise false. + /// This value is true when the user fulfills the policy, otherwise false. /// public static Task AuthorizeAsync(this IAuthorizationService service, ClaimsPrincipal user, string policyName) { diff --git a/src/Microsoft.AspNetCore.Authorization/DefaultAuthorizationService.cs b/src/Microsoft.AspNetCore.Authorization/DefaultAuthorizationService.cs index 4ac87eff45..6665204eee 100644 --- a/src/Microsoft.AspNetCore.Authorization/DefaultAuthorizationService.cs +++ b/src/Microsoft.AspNetCore.Authorization/DefaultAuthorizationService.cs @@ -24,7 +24,7 @@ namespace Microsoft.AspNetCore.Authorization /// Creates a new instance of . /// /// The used to provide policies. - /// The handlers used to fufills s. + /// The handlers used to fulfill s. /// The logger used to log messages, warnings and errors. public DefaultAuthorizationService(IAuthorizationPolicyProvider policyProvider, IEnumerable handlers, ILogger logger) { @@ -47,7 +47,7 @@ namespace Microsoft.AspNetCore.Authorization } /// - /// Checks if a user meets a specific set of requirements for the specified resource + /// Checks if a user meets a specific set of requirements for the specified resource. /// /// The user to evaluate the requirements against. /// The resource to evaluate the requirements against. @@ -104,7 +104,7 @@ namespace Microsoft.AspNetCore.Authorization } /// - /// Checks if a user meets a specific authorization policy + /// Checks if a user meets a specific authorization policy. /// /// The user to check the policy against. /// The resource the policy should be checked with. diff --git a/src/Microsoft.AspNetCore.Authorization/Infrastructure/AssertionRequirement.cs b/src/Microsoft.AspNetCore.Authorization/Infrastructure/AssertionRequirement.cs index 1c38b800e9..5fa452b733 100644 --- a/src/Microsoft.AspNetCore.Authorization/Infrastructure/AssertionRequirement.cs +++ b/src/Microsoft.AspNetCore.Authorization/Infrastructure/AssertionRequirement.cs @@ -8,7 +8,7 @@ namespace Microsoft.AspNetCore.Authorization.Infrastructure { /// /// Implements an and - /// that takes an user specified assertion. + /// that takes a user specified assertion. /// public class AssertionRequirement : IAuthorizationHandler, IAuthorizationRequirement {