React to delayed Configure in Hosting (#1118)

This commit is contained in:
BrennanConroy 2017-11-14 14:43:56 -08:00 committed by GitHub
parent 18f308fb05
commit 34b0445dd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 9 deletions

View File

@ -14,7 +14,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
{ {
var ex = Assert.Throws<NotSupportedException>(() => var ex = Assert.Throws<NotSupportedException>(() =>
{ {
var builder = new WebHostBuilder() using (var builder = new WebHostBuilder()
.UseKestrel() .UseKestrel()
.ConfigureServices(services => .ConfigureServices(services =>
{ {
@ -24,7 +24,10 @@ namespace Microsoft.AspNetCore.SignalR.Tests
{ {
app.UseSignalR(options => options.MapHub<InvalidHub>("overloads")); app.UseSignalR(options => options.MapHub<InvalidHub>("overloads"));
}) })
.Build(); .Build())
{
builder.Start();
}
}); });
Assert.Equal("Duplicate definitions of 'OverloadedMethod'. Overloading is not supported.", ex.Message); Assert.Equal("Duplicate definitions of 'OverloadedMethod'. Overloading is not supported.", ex.Message);
@ -34,7 +37,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
public void MapHubFindsAuthAttributeOnHub() public void MapHubFindsAuthAttributeOnHub()
{ {
var authCount = 0; var authCount = 0;
var builder = new WebHostBuilder() using (var builder = new WebHostBuilder()
.UseKestrel() .UseKestrel()
.ConfigureServices(services => .ConfigureServices(services =>
{ {
@ -47,7 +50,10 @@ namespace Microsoft.AspNetCore.SignalR.Tests
authCount += httpSocketOptions.AuthorizationData.Count; authCount += httpSocketOptions.AuthorizationData.Count;
})); }));
}) })
.Build(); .Build())
{
builder.Start();
}
Assert.Equal(1, authCount); Assert.Equal(1, authCount);
} }
@ -56,7 +62,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
public void MapHubFindsAuthAttributeOnInheritedHub() public void MapHubFindsAuthAttributeOnInheritedHub()
{ {
var authCount = 0; var authCount = 0;
var builder = new WebHostBuilder() using (var builder = new WebHostBuilder()
.UseKestrel() .UseKestrel()
.ConfigureServices(services => .ConfigureServices(services =>
{ {
@ -69,7 +75,10 @@ namespace Microsoft.AspNetCore.SignalR.Tests
authCount += httpSocketOptions.AuthorizationData.Count; authCount += httpSocketOptions.AuthorizationData.Count;
})); }));
}) })
.Build(); .Build())
{
builder.Start();
}
Assert.Equal(1, authCount); Assert.Equal(1, authCount);
} }
@ -78,7 +87,7 @@ namespace Microsoft.AspNetCore.SignalR.Tests
public void MapHubFindsMultipleAuthAttributesOnDoubleAuthHub() public void MapHubFindsMultipleAuthAttributesOnDoubleAuthHub()
{ {
var authCount = 0; var authCount = 0;
var builder = new WebHostBuilder() using (var builder = new WebHostBuilder()
.UseKestrel() .UseKestrel()
.ConfigureServices(services => .ConfigureServices(services =>
{ {
@ -91,9 +100,12 @@ namespace Microsoft.AspNetCore.SignalR.Tests
authCount += httpSocketOptions.AuthorizationData.Count; authCount += httpSocketOptions.AuthorizationData.Count;
})); }));
}) })
.Build(); .Build())
{
builder.Start();
}
Assert.Equal(2, authCount); Assert.Equal(2, authCount);
} }
private class InvalidHub : Hub private class InvalidHub : Hub