diff --git a/test/Microsoft.AspNetCore.SignalR.Client.Tests/HttpConnectionTests.ConnectionLifecycle.cs b/test/Microsoft.AspNetCore.SignalR.Client.Tests/HttpConnectionTests.ConnectionLifecycle.cs index 894e84177d..a688fcee4c 100644 --- a/test/Microsoft.AspNetCore.SignalR.Client.Tests/HttpConnectionTests.ConnectionLifecycle.cs +++ b/test/Microsoft.AspNetCore.SignalR.Client.Tests/HttpConnectionTests.ConnectionLifecycle.cs @@ -327,31 +327,23 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests [Fact] public async Task SSEWontStartIfSuccessfulConnectionIsNotEstablished() { - bool ExpectedErrors(WriteContext writeContext) - { - return writeContext.LoggerName == typeof(HttpConnection).FullName && - writeContext.EventId.Name == "ErrorStartingTransport"; - } + // TODO: Add logging https://github.com/aspnet/SignalR/issues/2879 + var httpHandler = new TestHttpMessageHandler(); - using (StartVerifiableLog(out var loggerFactory, LogLevel.Trace, expectedErrorsFilter: ExpectedErrors)) + httpHandler.OnGet("/?id=00000000-0000-0000-0000-000000000000", (_, __) => { - var httpHandler = new TestHttpMessageHandler(loggerFactory); + return Task.FromResult(ResponseUtils.CreateResponse(HttpStatusCode.InternalServerError)); + }); - httpHandler.OnGet("/?id=00000000-0000-0000-0000-000000000000", (_, __) => + var sse = new ServerSentEventsTransport(new HttpClient(httpHandler)); + + await WithConnectionAsync( + CreateConnection(httpHandler, transport: sse), + async (connection) => { - return Task.FromResult(ResponseUtils.CreateResponse(HttpStatusCode.InternalServerError)); + await Assert.ThrowsAsync( + () => connection.StartAsync(TransferFormat.Text).OrTimeout()); }); - - var sse = new ServerSentEventsTransport(new HttpClient(httpHandler), loggerFactory); - - await WithConnectionAsync( - CreateConnection(httpHandler, loggerFactory: loggerFactory, transport: sse), - async (connection) => - { - await Assert.ThrowsAsync( - () => connection.StartAsync(TransferFormat.Text).OrTimeout()); - }); - } } [Fact] diff --git a/test/Microsoft.AspNetCore.SignalR.Client.Tests/ServerSentEventsTransportTests.cs b/test/Microsoft.AspNetCore.SignalR.Client.Tests/ServerSentEventsTransportTests.cs index 89954fa254..835b180665 100644 --- a/test/Microsoft.AspNetCore.SignalR.Client.Tests/ServerSentEventsTransportTests.cs +++ b/test/Microsoft.AspNetCore.SignalR.Client.Tests/ServerSentEventsTransportTests.cs @@ -165,12 +165,7 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests [Fact] public async Task SSETransportStopsWithErrorIfSendingMessageFails() { - bool ExpectedErrors(WriteContext writeContext) - { - return writeContext.LoggerName == typeof(ServerSentEventsTransport).FullName && - writeContext.EventId.Name == "ErrorSending"; - } - + // TODO: Add logging https://github.com/aspnet/SignalR/issues/2879 var eventStreamTcs = new TaskCompletionSource(); var copyToAsyncTcs = new TaskCompletionSource(); @@ -199,9 +194,8 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests }); using (var httpClient = new HttpClient(mockHttpHandler.Object)) - using (StartVerifiableLog(out var loggerFactory, LogLevel.Trace, expectedErrorsFilter: ExpectedErrors)) { - var sseTransport = new ServerSentEventsTransport(httpClient, loggerFactory); + var sseTransport = new ServerSentEventsTransport(httpClient); await sseTransport.StartAsync( new Uri("http://fakeuri.org"), TransferFormat.Text).OrTimeout();