From 2d8cd179a11b77df73c592b233ffb29b26af5a99 Mon Sep 17 00:00:00 2001 From: Justin Kotalik Date: Mon, 26 Aug 2019 14:07:31 -0700 Subject: [PATCH] Skip default port tests (#12983) --- .../BindTests/AddressRegistrationTests.cs | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs index 6d294edd00..205bdbbe5f 100644 --- a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs +++ b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs @@ -46,9 +46,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests await RegisterAddresses_Success(addressInput, testUrl); } - [Theory] + [ConditionalTheory] [MemberData(nameof(AddressRegistrationDataIPv4Port5000Default))] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] + [SkipOnCI] public async Task RegisterAddresses_IPv4Port5000Default_Success(string addressInput, string testUrl) { if (!CanBindToEndpoint(IPAddress.Loopback, 5000)) @@ -59,9 +59,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests await RegisterAddresses_Success(addressInput, testUrl, 5000); } - [Theory] + [ConditionalTheory] [MemberData(nameof(AddressRegistrationDataIPv4Port80))] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] + [SkipOnCI] public async Task RegisterAddresses_IPv4Port80_Success(string addressInput, string testUrl) { if (!CanBindToEndpoint(IPAddress.Loopback, 80)) @@ -415,8 +415,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests } } - [Fact] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] + [ConditionalFact] + [SkipOnCI] public Task DefaultsServerAddress_BindsToIPv4() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000)) @@ -429,7 +429,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] + [SkipOnCI] public Task DefaultsServerAddress_BindsToIPv6() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)) @@ -440,8 +440,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests return RegisterDefaultServerAddresses_Success(new[] { "http://127.0.0.1:5000", "http://[::1]:5000" }); } - [Fact] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/2711", FlakyOn.AzP.All)] + [ConditionalFact] + [SkipOnCI] public Task DefaultsServerAddress_BindsToIPv4WithHttps() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.Loopback, 5001)) @@ -455,7 +455,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [IPv6SupportedCondition] - [Flaky("https://github.com/aspnet/AspNetCore-Internal/issues/1756", FlakyOn.AzP.All)] + [SkipOnCI] public Task DefaultsServerAddress_BindsToIPv6WithHttps() { if (!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)