Fixes spell across test classes and comments (#14958)
This commit is contained in:
parent
64349f1eae
commit
288bedd9a3
|
|
@ -379,7 +379,7 @@ namespace Microsoft.AspNetCore.Antiforgery
|
||||||
/// <param name="httpContext">The <see cref="HttpContext"/>.</param>
|
/// <param name="httpContext">The <see cref="HttpContext"/>.</param>
|
||||||
protected virtual void SetDoNotCacheHeaders(HttpContext httpContext)
|
protected virtual void SetDoNotCacheHeaders(HttpContext httpContext)
|
||||||
{
|
{
|
||||||
// Since antifogery token generation is not very obvious to the end users (ex: MVC's form tag generates them
|
// Since antiforgery token generation is not very obvious to the end users (ex: MVC's form tag generates them
|
||||||
// by default), log a warning to let users know of the change in behavior to any cache headers they might
|
// by default), log a warning to let users know of the change in behavior to any cache headers they might
|
||||||
// have set explicitly.
|
// have set explicitly.
|
||||||
LogCacheHeaderOverrideWarning(httpContext.Response);
|
LogCacheHeaderOverrideWarning(httpContext.Response);
|
||||||
|
|
|
||||||
|
|
@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Antiforgery.Internal
|
||||||
public void DefaultUniqueClaimTypes_NotPresent_SerializesAllClaimTypes()
|
public void DefaultUniqueClaimTypes_NotPresent_SerializesAllClaimTypes()
|
||||||
{
|
{
|
||||||
var identity = new ClaimsIdentity("someAuthentication");
|
var identity = new ClaimsIdentity("someAuthentication");
|
||||||
identity.AddClaim(new Claim(ClaimTypes.Email, "someone@antifrogery.com"));
|
identity.AddClaim(new Claim(ClaimTypes.Email, "someone@antiforgery.com"));
|
||||||
identity.AddClaim(new Claim(ClaimTypes.GivenName, "some"));
|
identity.AddClaim(new Claim(ClaimTypes.GivenName, "some"));
|
||||||
identity.AddClaim(new Claim(ClaimTypes.Surname, "one"));
|
identity.AddClaim(new Claim(ClaimTypes.Surname, "one"));
|
||||||
identity.AddClaim(new Claim(ClaimTypes.NameIdentifier, string.Empty));
|
identity.AddClaim(new Claim(ClaimTypes.NameIdentifier, string.Empty));
|
||||||
|
|
|
||||||
|
|
@ -626,7 +626,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
|
||||||
Browser.Exists(incompleteItemsSelector);
|
Browser.Exists(incompleteItemsSelector);
|
||||||
|
|
||||||
// Mark first item as done; observe the remaining incomplete item appears unchecked
|
// Mark first item as done; observe the remaining incomplete item appears unchecked
|
||||||
// because the diff algoritm explicitly unchecks it
|
// because the diff algorithm explicitly unchecks it
|
||||||
appElement.FindElement(By.CssSelector(".incomplete-items .item-isdone")).Click();
|
appElement.FindElement(By.CssSelector(".incomplete-items .item-isdone")).Click();
|
||||||
Browser.True(() =>
|
Browser.True(() =>
|
||||||
{
|
{
|
||||||
|
|
@ -636,7 +636,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.Tests
|
||||||
});
|
});
|
||||||
|
|
||||||
// Mark first done item as not done; observe the remaining complete item appears checked
|
// Mark first done item as not done; observe the remaining complete item appears checked
|
||||||
// because the diff algoritm explicitly re-checks it
|
// because the diff algorithm explicitly re-checks it
|
||||||
appElement.FindElement(By.CssSelector(".complete-items .item-isdone")).Click();
|
appElement.FindElement(By.CssSelector(".complete-items .item-isdone")).Click();
|
||||||
Browser.True(() =>
|
Browser.True(() =>
|
||||||
{
|
{
|
||||||
|
|
|
||||||
|
|
@ -265,7 +265,7 @@ namespace Microsoft.AspNetCore.Routing
|
||||||
{
|
{
|
||||||
if (_logger != null)
|
if (_logger != null)
|
||||||
{
|
{
|
||||||
// Multiple threads might have tried to accquire the lock at the same time. Technically
|
// Multiple threads might have tried to acquire the lock at the same time. Technically
|
||||||
// there is nothing wrong if things get reinitialized by a second thread, but its easy
|
// there is nothing wrong if things get reinitialized by a second thread, but its easy
|
||||||
// to prevent by just rechecking and returning here.
|
// to prevent by just rechecking and returning here.
|
||||||
return;
|
return;
|
||||||
|
|
|
||||||
|
|
@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.WebUtilities
|
||||||
/// Defaults to 32kb.
|
/// Defaults to 32kb.
|
||||||
/// </param>
|
/// </param>
|
||||||
/// <param name="bufferLimit">
|
/// <param name="bufferLimit">
|
||||||
/// The maximum amouont of bytes that the <see cref="FileBufferingWriteStream"/> is allowed to buffer.
|
/// The maximum amount of bytes that the <see cref="FileBufferingWriteStream"/> is allowed to buffer.
|
||||||
/// </param>
|
/// </param>
|
||||||
/// <param name="tempFileDirectoryAccessor">Provides the location of the directory to write buffered contents to.
|
/// <param name="tempFileDirectoryAccessor">Provides the location of the directory to write buffered contents to.
|
||||||
/// When unspecified, uses the value specified by the environment variable <c>ASPNETCORE_TEMP</c> if available, otherwise
|
/// When unspecified, uses the value specified by the environment variable <c>ASPNETCORE_TEMP</c> if available, otherwise
|
||||||
|
|
@ -117,7 +117,7 @@ namespace Microsoft.AspNetCore.WebUtilities
|
||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
// If the MemoryStream is incapable of accomodating the content to be written
|
// If the MemoryStream is incapable of accommodating the content to be written
|
||||||
// spool to disk.
|
// spool to disk.
|
||||||
EnsureFileStream();
|
EnsureFileStream();
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -159,7 +159,7 @@ namespace Microsoft.AspNetCore.Mvc.ApiExplorer
|
||||||
// 2. When a type is specified, use GetSupportedContentTypes to expand wildcards and get the range of content-types formatters support.
|
// 2. When a type is specified, use GetSupportedContentTypes to expand wildcards and get the range of content-types formatters support.
|
||||||
// 3. When no formatter supports the specified content-type, use the user specified value as is. This is useful in actions where the user
|
// 3. When no formatter supports the specified content-type, use the user specified value as is. This is useful in actions where the user
|
||||||
// dictates the content-type.
|
// dictates the content-type.
|
||||||
// e.g. [Produces("application/pdf")] Action() => FileStream("somefile.pdf", "applicaiton/pdf");
|
// e.g. [Produces("application/pdf")] Action() => FileStream("somefile.pdf", "application/pdf");
|
||||||
|
|
||||||
foreach (var apiResponse in responseTypes)
|
foreach (var apiResponse in responseTypes)
|
||||||
{
|
{
|
||||||
|
|
|
||||||
|
|
@ -123,7 +123,7 @@ namespace Microsoft.AspNetCore.Mvc.Formatters.Json
|
||||||
// Overflow buffer is always empty when we get here and we can use it's full length to write contents to.
|
// Overflow buffer is always empty when we get here and we can use it's full length to write contents to.
|
||||||
Utf8.FromUtf16(_charBuffer, _overflowBuffer.Array, out var overFlowChars, out var overflowBytes, isFinalBlock: false);
|
Utf8.FromUtf16(_charBuffer, _overflowBuffer.Array, out var overFlowChars, out var overflowBytes, isFinalBlock: false);
|
||||||
|
|
||||||
Debug.Assert(overflowBytes > 0 && overFlowChars > 0, "We expect writes to the overflow buffer to always succeed since it is large enough to accomodate at least one char.");
|
Debug.Assert(overflowBytes > 0 && overFlowChars > 0, "We expect writes to the overflow buffer to always succeed since it is large enough to accommodate at least one char.");
|
||||||
|
|
||||||
_charBuffer = _charBuffer.Slice(overFlowChars);
|
_charBuffer = _charBuffer.Slice(overFlowChars);
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -77,7 +77,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
|
||||||
[InlineData("invalid address")]
|
[InlineData("invalid address")]
|
||||||
[InlineData("")]
|
[InlineData("")]
|
||||||
[InlineData(null)]
|
[InlineData(null)]
|
||||||
public void OverridingIServerAdressesFeatureWithDirectConfiguration_WarnsOnStart(string serverAddress)
|
public void OverridingIServerAddressesFeatureWithDirectConfiguration_WarnsOnStart(string serverAddress)
|
||||||
{
|
{
|
||||||
var overrideAddress = "http://localhost:11002/";
|
var overrideAddress = "http://localhost:11002/";
|
||||||
|
|
||||||
|
|
@ -94,7 +94,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys
|
||||||
}
|
}
|
||||||
|
|
||||||
[ConditionalFact]
|
[ConditionalFact]
|
||||||
public void UseIServerAdressesFeature_WhenNoDirectConfiguration()
|
public void UseIServerAddressesFeature_WhenNoDirectConfiguration()
|
||||||
{
|
{
|
||||||
var serverAddress = "http://localhost:11001/";
|
var serverAddress = "http://localhost:11001/";
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -153,7 +153,7 @@ namespace Microsoft.Extensions.Internal
|
||||||
}
|
}
|
||||||
|
|
||||||
[TestActivate]
|
[TestActivate]
|
||||||
public static int StaticActivatablProperty { get; set; }
|
public static int StaticActivatableProperty { get; set; }
|
||||||
}
|
}
|
||||||
|
|
||||||
private class TestClassWithPropertyVisiblity
|
private class TestClassWithPropertyVisiblity
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue