huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Quarantine a hosting test that failed 

This test failed overnight on linux. The part that failed was checking the exit code
of `kill` which is a little surprising. This implies that `kill` itself was also
forcibly killed - so we're increasing the timeout before we kill `kill`. 👍
This commit is contained in:
Ryan Nowak 2020-04-03 11:20:04 -07:00
parent 8fac70750e
commit 2883a47542
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Hosting/test/FunctionalTests/ShutdownTests.cs
View File

@ -32,6 +32,7 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run"); await ExecuteShutdownTest(nameof(ShutdownTestRun), "Run");
} }
[QuarantinedTest]
[ConditionalFact] [ConditionalFact]
[OSSkipCondition(OperatingSystems.Windows)] [OSSkipCondition(OperatingSystems.Windows)]
[OSSkipCondition(OperatingSystems.MacOSX)] [OSSkipCondition(OperatingSystems.MacOSX)]
@ -133,7 +134,7 @@ namespace Microsoft.AspNetCore.Hosting.FunctionalTests
private static void WaitForExitOrKill(Process process) private static void WaitForExitOrKill(Process process)
{ {
process.WaitForExit(1000); process.WaitForExit(5 * 1000);
if (!process.HasExited) if (!process.HasExited)
{ {
process.Kill(); process.Kill();