huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove RestoreOnPublish parameter (#1533)

This commit is contained in:
Pavel Krymets 2018-10-09 10:41:52 -07:00 committed by GitHub
parent dd2056ae1a
commit 27e4e1aca3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNetCore.Server.IntegrationTesting/ApplicationPublisher.cs
View File

@ -35,9 +35,7 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
+ $" --output \"{publishDirectory.FullName}\"" + $" --output \"{publishDirectory.FullName}\""
+ $" --framework {deploymentParameters.TargetFramework}" + $" --framework {deploymentParameters.TargetFramework}"
+ $" --configuration {deploymentParameters.Configuration}" + $" --configuration {deploymentParameters.Configuration}"
+ (deploymentParameters.RestoreOnPublish + " --no-restore -p:VerifyMatchingImplicitPackageVersion=false";
? string.Empty
: " --no-restore -p:VerifyMatchingImplicitPackageVersion=false");
// Set VerifyMatchingImplicitPackageVersion to disable errors when Microsoft.NETCore.App's version is overridden externally // Set VerifyMatchingImplicitPackageVersion to disable errors when Microsoft.NETCore.App's version is overridden externally
// This verification doesn't matter if we are skipping restore during tests. // This verification doesn't matter if we are skipping restore during tests.

5
src/Microsoft.AspNetCore.Server.IntegrationTesting/CachingApplicationPublisher.cs
View File

@ -35,11 +35,6 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
throw new InvalidOperationException("DeploymentParameters.PublishedApplicationRootPath not supported"); throw new InvalidOperationException("DeploymentParameters.PublishedApplicationRootPath not supported");
} }
if (deploymentParameters.RestoreOnPublish)
{
throw new InvalidOperationException("DeploymentParameters.RestoreOnPublish not supported");
}
var dotnetPublishParameters = new DotnetPublishParameters var dotnetPublishParameters = new DotnetPublishParameters
{ {
TargetFramework = deploymentParameters.TargetFramework, TargetFramework = deploymentParameters.TargetFramework,

5
src/Microsoft.AspNetCore.Server.IntegrationTesting/Common/DeploymentParameters.cs
View File

@ -147,11 +147,6 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting
/// </summary> /// </summary>
public string AdditionalPublishParameters { get; set; } public string AdditionalPublishParameters { get; set; }
/// <summary>
/// Publish restores by default, this property opts out by default.
/// </summary>
public bool RestoreOnPublish { get; set; }
/// <summary> /// <summary>
/// To publish the application before deployment. /// To publish the application before deployment.
/// </summary> /// </summary>