Remove additional explict 'netcoreapp3.1' mentions (#14226)
- e.g. use netcoreappX.Y in comments
This commit is contained in:
parent
2e4609a02b
commit
26f160d164
|
|
@ -9,7 +9,7 @@
|
||||||
<!-- Reference base shared framework at incoming dependency flow version, not bundled sdk version. -->
|
<!-- Reference base shared framework at incoming dependency flow version, not bundled sdk version. -->
|
||||||
<FrameworkReference
|
<FrameworkReference
|
||||||
Update="Microsoft.NETCore.App"
|
Update="Microsoft.NETCore.App"
|
||||||
Condition="'$(TargetFramework)' == 'netcoreapp3.1'"
|
Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'"
|
||||||
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimeVersion)"
|
RuntimeFrameworkVersion="$(MicrosoftNETCoreAppRuntimeVersion)"
|
||||||
TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
|
TargetingPackVersion="$(MicrosoftNETCoreAppRefPackageVersion)"
|
||||||
/>
|
/>
|
||||||
|
|
|
||||||
|
|
@ -2,7 +2,7 @@
|
||||||
|
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<OutputType>Exe</OutputType>
|
<OutputType>Exe</OutputType>
|
||||||
<TargetFramework>netcoreapp3.1</TargetFramework>
|
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
|
||||||
<StartArguments>-s https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json</StartArguments>
|
<StartArguments>-s https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json</StartArguments>
|
||||||
<StartWorkingDirectory>$(MSBuildThisFileDirectory)../../</StartWorkingDirectory>
|
<StartWorkingDirectory>$(MSBuildThisFileDirectory)../../</StartWorkingDirectory>
|
||||||
</PropertyGroup>
|
</PropertyGroup>
|
||||||
|
|
|
||||||
|
|
@ -1,7 +1,7 @@
|
||||||
<Project Sdk="Microsoft.NET.Sdk">
|
<Project Sdk="Microsoft.NET.Sdk">
|
||||||
|
|
||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<TargetFrameworks>netcoreapp3.1</TargetFrameworks>
|
<TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks>
|
||||||
<TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net472</TargetFrameworks>
|
<TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net472</TargetFrameworks>
|
||||||
<DefineConstants Condition="'$(TargetFramework)' == 'net472'">$(DefineConstants);BUILD_MSI_TASKS</DefineConstants>
|
<DefineConstants Condition="'$(TargetFramework)' == 'net472'">$(DefineConstants);BUILD_MSI_TASKS</DefineConstants>
|
||||||
<Optimize>false</Optimize>
|
<Optimize>false</Optimize>
|
||||||
|
|
@ -16,7 +16,7 @@
|
||||||
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.1.0" />
|
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.1.0" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
<ItemGroup Condition="'$(TargetFramework)' == 'netcoreapp3.1'">
|
<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">
|
||||||
<PackageReference Include="Microsoft.Build.Framework" Version="15.8.166" />
|
<PackageReference Include="Microsoft.Build.Framework" Version="15.8.166" />
|
||||||
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="15.8.166" />
|
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="15.8.166" />
|
||||||
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.8.166" />
|
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="15.8.166" />
|
||||||
|
|
|
||||||
|
|
@ -25,7 +25,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant
|
||||||
<BaseRuntimeVersionFileName>aspnetcore_base_runtime.version</BaseRuntimeVersionFileName>
|
<BaseRuntimeVersionFileName>aspnetcore_base_runtime.version</BaseRuntimeVersionFileName>
|
||||||
<BaseRuntimeVersionFileOutputPath>$(InstallersOutputPath)$(BaseRuntimeVersionFileName)</BaseRuntimeVersionFileOutputPath>
|
<BaseRuntimeVersionFileOutputPath>$(InstallersOutputPath)$(BaseRuntimeVersionFileName)</BaseRuntimeVersionFileOutputPath>
|
||||||
|
|
||||||
<!-- NuGet appends target framework to this value. Example: runtimes/win-x64/lib/netcoreapp3.1/ -->
|
<!-- NuGet appends target framework to this value. Example: runtimes/win-x64/lib/netcoreappX.Y/ -->
|
||||||
<BuildOutputTargetFolder>runtimes/$(RuntimeIdentifier)/lib/</BuildOutputTargetFolder>
|
<BuildOutputTargetFolder>runtimes/$(RuntimeIdentifier)/lib/</BuildOutputTargetFolder>
|
||||||
<!-- We still need the native path to these assets though for the RuntimeList.xml manifest -->
|
<!-- We still need the native path to these assets though for the RuntimeList.xml manifest -->
|
||||||
<ManagedAssetsPackagePath>$(BuildOutputTargetFolder)$(DefaultNetCoreTargetFramework)</ManagedAssetsPackagePath>
|
<ManagedAssetsPackagePath>$(BuildOutputTargetFolder)$(DefaultNetCoreTargetFramework)</ManagedAssetsPackagePath>
|
||||||
|
|
|
||||||
|
|
@ -36,7 +36,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
@ -93,7 +93,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -36,7 +36,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -134,7 +134,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync(packageOptions: packageOptions);
|
var buildResult = await Project.RunDotNetBuildAsync(packageOptions: packageOptions);
|
||||||
|
|
|
||||||
|
|
@ -48,7 +48,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
@ -116,7 +116,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -33,7 +33,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
@ -52,7 +52,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -45,7 +45,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, createResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, createResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
@ -115,7 +115,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -76,7 +76,7 @@ namespace Templates.Test.SpaTemplateTest
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
using var buildResult = await Project.RunDotNetBuildAsync();
|
using var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -36,7 +36,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -32,7 +32,7 @@ namespace Templates.Test
|
||||||
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
Assert.True(0 == publishResult.ExitCode, ErrorMessages.GetFailedProcessMessage("publish", Project, publishResult));
|
||||||
|
|
||||||
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
// Run dotnet build after publish. The reason is that one uses Config = Debug and the other uses Config = Release
|
||||||
// The output from publish will go into bin/Release/netcoreapp3.1/publish and won't be affected by calling build
|
// The output from publish will go into bin/Release/netcoreappX.Y/publish and won't be affected by calling build
|
||||||
// later, while the opposite is not true.
|
// later, while the opposite is not true.
|
||||||
|
|
||||||
var buildResult = await Project.RunDotNetBuildAsync();
|
var buildResult = await Project.RunDotNetBuildAsync();
|
||||||
|
|
|
||||||
|
|
@ -51,7 +51,7 @@ namespace Microsoft.AspNetCore.Server.IntegrationTesting.IIS
|
||||||
// Start timer
|
// Start timer
|
||||||
StartTimer();
|
StartTimer();
|
||||||
|
|
||||||
// For an unpublished application the dllroot points pre-built dlls like projectdir/bin/debug/netcoreapp3.1/
|
// For an unpublished application the dllroot points pre-built dlls like projectdir/bin/debug/netcoreappX.Y/
|
||||||
// and contentRoot points to the project directory so you get things like static assets.
|
// and contentRoot points to the project directory so you get things like static assets.
|
||||||
// For a published app both point to the publish directory.
|
// For a published app both point to the publish directory.
|
||||||
var dllRoot = CheckIfPublishIsRequired();
|
var dllRoot = CheckIfPublishIsRequired();
|
||||||
|
|
|
||||||
|
|
@ -155,7 +155,8 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal.Transports
|
||||||
var memory = _application.Output.GetMemory();
|
var memory = _application.Output.GetMemory();
|
||||||
|
|
||||||
var receiveResult = await socket.ReceiveAsync(memory, token);
|
var receiveResult = await socket.ReceiveAsync(memory, token);
|
||||||
// Need to check again for netcoreapp3.1 because a close can happen between a 0-byte read and the actual read
|
|
||||||
|
// Need to check again for netcoreapp3.0 and later because a close can happen between a 0-byte read and the actual read
|
||||||
if (receiveResult.MessageType == WebSocketMessageType.Close)
|
if (receiveResult.MessageType == WebSocketMessageType.Close)
|
||||||
{
|
{
|
||||||
return;
|
return;
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue