Unquarantine Tests (#23098)

Found a bunch of tests running for 30+ days with 100% pass rate.
This commit is contained in:
Tanay Parikh 2020-06-22 17:54:52 -07:00 committed by GitHub
parent 7b707c9006
commit 26cc3b43a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
16 changed files with 1 additions and 28 deletions

View File

@ -766,7 +766,6 @@ namespace Microsoft.AspNetCore.Components.Rendering
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task InvokeAsync_SyncWorkInAsyncTaskIsCompletedFirst() public async Task InvokeAsync_SyncWorkInAsyncTaskIsCompletedFirst()
{ {
// Simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext // Simplified version of ServerComponentRenderingTest.CanDispatchAsyncWorkToSyncContext

View File

@ -1450,7 +1450,6 @@ namespace Microsoft.AspNetCore.Identity.Test
/// </summary> /// </summary>
/// <returns>Task</returns> /// <returns>Task</returns>
[Fact] [Fact]
[QuarantinedTest]
public async Task ChangePhoneNumberFailsWithWrongPhoneNumber() public async Task ChangePhoneNumberFailsWithWrongPhoneNumber()
{ {
var manager = CreateManager(); var manager = CreateManager();
@ -1471,7 +1470,6 @@ namespace Microsoft.AspNetCore.Identity.Test
/// </summary> /// </summary>
/// <returns>Task</returns> /// <returns>Task</returns>
[Fact] [Fact]
[QuarantinedTest]
public async Task CanVerifyPhoneNumber() public async Task CanVerifyPhoneNumber()
{ {
var manager = CreateManager(); var manager = CreateManager();
@ -1519,7 +1517,6 @@ namespace Microsoft.AspNetCore.Identity.Test
/// </summary> /// </summary>
/// <returns>Task</returns> /// <returns>Task</returns>
[Fact] [Fact]
[QuarantinedTest]
public async Task CanChangeEmailOnlyIfEmailSame() public async Task CanChangeEmailOnlyIfEmailSame()
{ {
var manager = CreateManager(); var manager = CreateManager();

View File

@ -887,7 +887,6 @@ namespace Microsoft.AspNetCore.Mvc.TagHelpers
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task ProcessAsync_AwaitersUseTheResultOfExecutor() public async Task ProcessAsync_AwaitersUseTheResultOfExecutor()
{ {
// Arrange // Arrange

View File

@ -34,7 +34,6 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests
.WithAllHostingModels(); .WithAllHostingModels();
[ConditionalTheory] [ConditionalTheory]
[QuarantinedTest]
[MemberData(nameof(TestVariants))] [MemberData(nameof(TestVariants))]
[MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)] [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win8)]
public Task HttpsNoClientCert_NoClientCert(TestVariant variant) public Task HttpsNoClientCert_NoClientCert(TestVariant variant)

View File

@ -300,7 +300,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task StreamPool_MultipleStreamsInSequence_PooledStreamReused() public async Task StreamPool_MultipleStreamsInSequence_PooledStreamReused()
{ {
TaskCompletionSource appDelegateTcs = null; TaskCompletionSource appDelegateTcs = null;
@ -365,7 +364,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task StreamPool_StreamIsInvalidState_DontReturnedToPool() public async Task StreamPool_StreamIsInvalidState_DontReturnedToPool()
{ {
var serverTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); var serverTcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);
@ -4010,7 +4008,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
[Theory] [Theory]
[InlineData(true)] [InlineData(true)]
[InlineData(false)] [InlineData(false)]
[QuarantinedTest]
public async Task CONTINUATION_Received_WithTrailers_Available(bool sendData) public async Task CONTINUATION_Received_WithTrailers_Available(bool sendData)
{ {
await InitializeConnectionAsync(_readTrailersApplication); await InitializeConnectionAsync(_readTrailersApplication);

View File

@ -371,7 +371,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task DATA_Sent_TooSlowlyDueToFlowControlOnSmallWrite_AbortsConnectionAfterGracePeriod() public async Task DATA_Sent_TooSlowlyDueToFlowControlOnSmallWrite_AbortsConnectionAfterGracePeriod()
{ {
var mockSystemClock = _serviceContext.MockSystemClock; var mockSystemClock = _serviceContext.MockSystemClock;
@ -426,7 +425,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task DATA_Sent_TooSlowlyDueToOutputFlowControlOnLargeWrite_AbortsConnectionAfterRateTimeout() public async Task DATA_Sent_TooSlowlyDueToOutputFlowControlOnLargeWrite_AbortsConnectionAfterRateTimeout()
{ {
var mockSystemClock = _serviceContext.MockSystemClock; var mockSystemClock = _serviceContext.MockSystemClock;

View File

@ -220,7 +220,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
[Fact] [Fact]
[Repeat(20)] [Repeat(20)]
[QuarantinedTest]
public async Task DoesNotThrowObjectDisposedExceptionFromWriteAsyncAfterConnectionIsAborted() public async Task DoesNotThrowObjectDisposedExceptionFromWriteAsyncAfterConnectionIsAborted()
{ {
var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

View File

@ -23,7 +23,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
[InlineData(5, 0)] [InlineData(5, 0)]
[InlineData(5, 1)] [InlineData(5, 1)]
[InlineData(5, 1337)] [InlineData(5, 1337)]
[QuarantinedTest]
public async Task ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(int headerCount, int extraLimit) public async Task ServerAcceptsRequestWithHeaderTotalSizeWithinLimit(int headerCount, int extraLimit)
{ {
var headers = MakeHeaders(headerCount); var headers = MakeHeaders(headerCount);

View File

@ -559,7 +559,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task TraceIdentifierIsUnique() public async Task TraceIdentifierIsUnique()
{ {
const int identifierLength = 22; const int identifierLength = 22;

View File

@ -13,7 +13,6 @@ namespace Microsoft.AspNetCore.SignalR.Client.Tests
public class TimerAwaitableTests public class TimerAwaitableTests
{ {
[Fact] [Fact]
[QuarantinedTest]
public async Task FinalizerRunsIfTimerAwaitableReferencesObject() public async Task FinalizerRunsIfTimerAwaitableReferencesObject()
{ {
var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); var tcs = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously);

View File

@ -20,7 +20,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task ChangeFileInDependency() public async Task ChangeFileInDependency()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();

View File

@ -23,7 +23,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task RunsWithDotnetWatchEnvVariable() public async Task RunsWithDotnetWatchEnvVariable()
{ {
Assert.True(string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_WATCH")), "DOTNET_WATCH cannot be set already when this test is running"); Assert.True(string.IsNullOrEmpty(Environment.GetEnvironmentVariable("DOTNET_WATCH")), "DOTNET_WATCH cannot be set already when this test is running");
@ -36,7 +35,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task RunsWithIterationEnvVariable() public async Task RunsWithIterationEnvVariable()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();

View File

@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
[Theory] [Theory]
[InlineData(true)] [InlineData(true)]
[InlineData(false)] [InlineData(false)]
[QuarantinedTest]
public async Task ChangeCompiledFile(bool usePollingWatcher) public async Task ChangeCompiledFile(bool usePollingWatcher)
{ {
_app.UsePollingWatcher = usePollingWatcher; _app.UsePollingWatcher = usePollingWatcher;
@ -43,7 +42,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task DeleteCompiledFile() public async Task DeleteCompiledFile()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();
@ -60,7 +58,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task DeleteSourceFolder() public async Task DeleteSourceFolder()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();
@ -77,7 +74,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task RenameCompiledFile() public async Task RenameCompiledFile()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();
@ -90,7 +86,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task ChangeExcludedFile() public async Task ChangeExcludedFile()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();

View File

@ -77,7 +77,6 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task SingleTfm() public async Task SingleTfm()
{ {
_tempDir _tempDir

View File

@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task RestartProcessOnFileChange() public async Task RestartProcessOnFileChange()
{ {
await _app.StartWatcherAsync(new[] { "--no-exit" }); await _app.StartWatcherAsync(new[] { "--no-exit" });
@ -43,7 +42,6 @@ namespace Microsoft.DotNet.Watcher.Tools.FunctionalTests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task RestartProcessThatTerminatesAfterFileChange() public async Task RestartProcessThatTerminatesAfterFileChange()
{ {
await _app.StartWatcherAsync(); await _app.StartWatcherAsync();

View File

@ -24,7 +24,6 @@ namespace Microsoft.DotNet.Watcher.Tools.Tests
} }
[Fact] [Fact]
[QuarantinedTest]
public async Task ConsoleCancelKey() public async Task ConsoleCancelKey()
{ {
_tempDir _tempDir