From 243404766399005c5ddabab3de7ab199c13a38b0 Mon Sep 17 00:00:00 2001 From: Artak <34246760+mkArtakMSFT@users.noreply.github.com> Date: Tue, 16 Jun 2020 21:22:17 -0700 Subject: [PATCH] Quarantined tests which were not running (skipped on Helix) (#23023) --- .../WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs | 2 +- src/Hosting/Hosting/test/WebHostTests.cs | 4 ++-- src/ProjectTemplates/test/ByteOrderMarkTest.cs | 4 ++-- .../HttpSys/test/FunctionalTests/Listener/ServerTests.cs | 2 +- .../IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs | 2 +- .../Kestrel/test/BindTests/AddressRegistrationTests.cs | 4 ++-- .../Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Components/WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs b/src/Components/WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs index 424800f75a..6fba8b34d9 100644 --- a/src/Components/WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs +++ b/src/Components/WebAssembly/Build/test/RuntimeDependenciesResolverTest.cs @@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Components.WebAssembly.Build public class RuntimeDependenciesResolverTest { [Fact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10426")] + [QuarantinedTest] public void FindsReferenceAssemblyGraph_ForStandaloneApp() { // Arrange diff --git a/src/Hosting/Hosting/test/WebHostTests.cs b/src/Hosting/Hosting/test/WebHostTests.cs index 8b7e73c5b4..07ddd8cc56 100644 --- a/src/Hosting/Hosting/test/WebHostTests.cs +++ b/src/Hosting/Hosting/test/WebHostTests.cs @@ -198,7 +198,7 @@ namespace Microsoft.AspNetCore.Hosting } [ConditionalFact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7291")] + [QuarantinedTest] public async Task WebHostStopAsyncUsesDefaultTimeoutIfGivenTokenDoesNotFire() { var data = new Dictionary @@ -313,7 +313,7 @@ namespace Microsoft.AspNetCore.Hosting } [ConditionalFact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7291")] + [QuarantinedTest] public void WebHostApplicationLifetimeEventsOrderedCorrectlyDuringShutdown() { using (var host = CreateBuilder() diff --git a/src/ProjectTemplates/test/ByteOrderMarkTest.cs b/src/ProjectTemplates/test/ByteOrderMarkTest.cs index a85077f6ee..7b5137bdc6 100644 --- a/src/ProjectTemplates/test/ByteOrderMarkTest.cs +++ b/src/ProjectTemplates/test/ByteOrderMarkTest.cs @@ -22,7 +22,7 @@ namespace Templates.Test } [ConditionalTheory] - [SkipOnHelix("missing files")] + [QuarantinedTest] [InlineData("Web.ProjectTemplates")] [InlineData("Web.Spa.ProjectTemplates")] public void JSAndJSONInAllTemplates_ShouldNotContainBOM(string projectName) @@ -64,7 +64,7 @@ namespace Templates.Test } [ConditionalFact] - [SkipOnHelix("missing files")] + [QuarantinedTest] public void RazorFilesInWebProjects_ShouldContainBOM() { var projectName = "Web.ProjectTemplates"; diff --git a/src/Servers/HttpSys/test/FunctionalTests/Listener/ServerTests.cs b/src/Servers/HttpSys/test/FunctionalTests/Listener/ServerTests.cs index 04cc3c6944..adc3472688 100644 --- a/src/Servers/HttpSys/test/FunctionalTests/Listener/ServerTests.cs +++ b/src/Servers/HttpSys/test/FunctionalTests/Listener/ServerTests.cs @@ -126,7 +126,7 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener } [ConditionalFact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/pull/20718#issuecomment-618758634")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/pull/20718#issuecomment-618758634")] public void Server_RegisterUnavailablePrefix_ThrowsActionableHttpSysException() { var options = new HttpSysOptions(); diff --git a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs index b33b2d31de..71ac04c80c 100644 --- a/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs +++ b/src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/StartupTests.cs @@ -119,7 +119,7 @@ namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests.InProcess [SkipIfNotAdmin] [RequiresNewShim] [RequiresIIS(IISCapability.PoolEnvironmentVariables)] - [SkipOnHelix("https://github.com/dotnet/aspnetcore-internal/issues/2221")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore-internal/issues/2221")] public async Task StartsWithDotnetInstallLocation(RuntimeArchitecture runtimeArchitecture) { var deploymentParameters = Fixture.GetBaseDeploymentParameters(); diff --git a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs index e843eae835..621110b164 100644 --- a/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs +++ b/src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs @@ -32,7 +32,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [HostNameIsReachable] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7267")] + [QuarantinedTest] public async Task RegisterAddresses_HostName_Success() { var hostName = Dns.GetHostName(); @@ -344,7 +344,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests [ConditionalFact] [HostNameIsReachable] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7267")] + [QuarantinedTest] public async Task ListenAnyIP_HostName_Success() { var hostName = Dns.GetHostName(); diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs index 950a304ecb..59af852469 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/TlsTests.cs @@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests.Http2 private static X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate(); [ConditionalFact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/7000")] + [QuarantinedTest] public async Task TlsHandshakeRejectsTlsLessThan12() { using (var server = new TestServer(context =>