From 211bc40384f35b74e70fd383b6f93097f352bb99 Mon Sep 17 00:00:00 2001 From: Ryan Brandenburg Date: Tue, 18 Feb 2020 09:26:51 -0800 Subject: [PATCH] Revert flaky tests that seems to have been fixed (#19065) --- .azure/pipelines/ci.yml | 1 + .../Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs | 8 -------- .../Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs | 3 --- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index dee7ba6985..19a90ec662 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -591,6 +591,7 @@ stages: - template: jobs/default-build.yml parameters: + condition: ne(variables['Build.Reason'], 'PullRequest') jobName: Helix_x64_daily jobDisplayName: 'Tests: Helix x64 Daily' agentOs: Windows diff --git a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs index 8af04058c0..c277df763d 100644 --- a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs +++ b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs @@ -28,7 +28,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public void OpenApi_NoProjectExists() { var app = GetApplication(); @@ -40,7 +39,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public void OpenApi_ExplicitProject_Missing() { var app = GetApplication(); @@ -75,7 +73,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Add_ReuseItemGroup() { var project = CreateBasicProject(withOpenApi: true); @@ -105,7 +102,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public void OpenApi_Add_File_EquivilentPaths() { var project = CreateBasicProject(withOpenApi: true); @@ -131,7 +127,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Add_NSwagTypeScript() { var project = CreateBasicProject(withOpenApi: true); @@ -152,7 +147,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Add_FromJson() { var project = CreateBasicProject(withOpenApi: true); @@ -173,7 +167,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Add_File_UseProjectOption() { var project = CreateBasicProject(withOpenApi: true); @@ -194,7 +187,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Add_MultipleTimes_OnlyOneReference() { var project = CreateBasicProject(withOpenApi: true); diff --git a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs index b48b7f688c..a8db61e99a 100644 --- a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs +++ b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs @@ -16,7 +16,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests public OpenApiRemoveTests(ITestOutputHelper output) : base(output) { } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Remove_File() { var nswagJsonFile = "openapi.json"; @@ -62,7 +61,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Remove_ViaUrl() { _tempDir @@ -151,7 +149,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests } [Fact] - [Flaky("", FlakyOn.All)] public async Task OpenApi_Remove_Multiple() { var nswagJsonFile = "openapi.json";