From 206b7b91130760f025cc948acbc531724c3456e3 Mon Sep 17 00:00:00 2001 From: Brennan Date: Mon, 30 Nov 2015 14:39:01 -0800 Subject: [PATCH] Dispose FileWatcher in tests --- .../DeveloperExceptionPageMiddlewareTest.cs | 46 ++++++++++--------- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/test/Microsoft.AspNet.Diagnostics.Tests/DeveloperExceptionPageMiddlewareTest.cs b/test/Microsoft.AspNet.Diagnostics.Tests/DeveloperExceptionPageMiddlewareTest.cs index bab6220d0e..530d65f332 100644 --- a/test/Microsoft.AspNet.Diagnostics.Tests/DeveloperExceptionPageMiddlewareTest.cs +++ b/test/Microsoft.AspNet.Diagnostics.Tests/DeveloperExceptionPageMiddlewareTest.cs @@ -87,18 +87,19 @@ namespace Microsoft.AspNet.Diagnostics // Arrange var rootPath = Directory.GetCurrentDirectory(); // PhysicalFileProvider handles only relative paths but we fall back to work with absolute paths too - var provider = new PhysicalFileProvider(rootPath); + using (var provider = new PhysicalFileProvider(rootPath)) + { + // Act + var middleware = GetErrorPageMiddleware(provider); + var stackFrame = middleware.GetStackFrame("func1", absoluteFilePath, lineNumber: 10); - // Act - var middleware = GetErrorPageMiddleware(provider); - var stackFrame = middleware.GetStackFrame("func1", absoluteFilePath, lineNumber: 10); - - // Assert - // Lines 4-16 (inclusive) is the code block - Assert.Equal(4, stackFrame.PreContextLine); - Assert.Equal(GetCodeLines(4, 9), stackFrame.PreContextCode); - Assert.Equal(GetCodeLines(10, 10), stackFrame.ContextCode); - Assert.Equal(GetCodeLines(11, 16), stackFrame.PostContextCode); + // Assert + // Lines 4-16 (inclusive) is the code block + Assert.Equal(4, stackFrame.PreContextLine); + Assert.Equal(GetCodeLines(4, 9), stackFrame.PreContextCode); + Assert.Equal(GetCodeLines(10, 10), stackFrame.ContextCode); + Assert.Equal(GetCodeLines(11, 16), stackFrame.PostContextCode); + } } [Theory] @@ -107,18 +108,19 @@ namespace Microsoft.AspNet.Diagnostics { // Arrange var rootPath = Directory.GetCurrentDirectory(); - var provider = new PhysicalFileProvider(rootPath); + using (var provider = new PhysicalFileProvider(rootPath)) + { + // Act + var middleware = GetErrorPageMiddleware(provider); + var stackFrame = middleware.GetStackFrame("func1", relativePath, lineNumber: 10); - // Act - var middleware = GetErrorPageMiddleware(provider); - var stackFrame = middleware.GetStackFrame("func1", relativePath, lineNumber: 10); - - // Assert - // Lines 4-16 (inclusive) is the code block - Assert.Equal(4, stackFrame.PreContextLine); - Assert.Equal(GetCodeLines(4, 9), stackFrame.PreContextCode); - Assert.Equal(GetCodeLines(10, 10), stackFrame.ContextCode); - Assert.Equal(GetCodeLines(11, 16), stackFrame.PostContextCode); + // Assert + // Lines 4-16 (inclusive) is the code block + Assert.Equal(4, stackFrame.PreContextLine); + Assert.Equal(GetCodeLines(4, 9), stackFrame.PreContextCode); + Assert.Equal(GetCodeLines(10, 10), stackFrame.ContextCode); + Assert.Equal(GetCodeLines(11, 16), stackFrame.PostContextCode); + } } [Theory]