From 1b6ee846ede5abe13ee22922cb471e296fcec179 Mon Sep 17 00:00:00 2001 From: Praburaj Date: Thu, 4 Sep 2014 13:13:17 -0700 Subject: [PATCH] Some cleanup 1. Removing a bug # from code which is fixed. 2. Removing a piece of test that was added while testing. --- .../Views/Account/_ExternalLoginsListPartial.cshtml | 5 +++-- .../Views/Shared/Components/Announcement/Default.cshtml | 3 ++- test/E2ETests/DeploymentUtility.cs | 1 - 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/MusicStore/Views/Account/_ExternalLoginsListPartial.cshtml b/src/MusicStore/Views/Account/_ExternalLoginsListPartial.cshtml index 3a2ad1d25b..d830b9446c 100644 --- a/src/MusicStore/Views/Account/_ExternalLoginsListPartial.cshtml +++ b/src/MusicStore/Views/Account/_ExternalLoginsListPartial.cshtml @@ -4,6 +4,7 @@

Use another service to log in.


@{ + //TODO: Need to replace with the helper that filters non external ones. GetExternalAuthenticationTypes() var loginProviders = Context.GetAuthenticationTypes(); if (loginProviders.Count() == 0) { @@ -16,13 +17,13 @@ } else { -

asdfasdf

using (Html.BeginForm("ExternalLogin", "Account", new { ReturnUrl = Model.ReturnUrl })) { @Html.AntiForgeryToken()

- @foreach (AuthenticationDescription p in loginProviders) + @*TODO: Temporary hack for the above issue. Needs to be removed once GetExternalAuthenticationTypes() is available*@ + @foreach (AuthenticationDescription p in loginProviders.Where(a => a.Caption != null)) { } diff --git a/src/MusicStore/Views/Shared/Components/Announcement/Default.cshtml b/src/MusicStore/Views/Shared/Components/Announcement/Default.cshtml index e19126bbed..f764aaa5d0 100644 --- a/src/MusicStore/Views/Shared/Components/Announcement/Default.cshtml +++ b/src/MusicStore/Views/Shared/Components/Announcement/Default.cshtml @@ -3,7 +3,8 @@ @if (Model != null) {

  • - @Html.Label(null, "New!", new { style = "color: red" }) +
    + @Html.Label(null, "New Arrivals!", new { style = "color: red" }) @Html.ActionLink(Model.Title, "Details", "Store", new { id = Model.AlbumId }, new { id = "NewArrivalsPanel" })
  • } \ No newline at end of file diff --git a/test/E2ETests/DeploymentUtility.cs b/test/E2ETests/DeploymentUtility.cs index d751707a26..3fbe375038 100644 --- a/test/E2ETests/DeploymentUtility.cs +++ b/test/E2ETests/DeploymentUtility.cs @@ -95,7 +95,6 @@ namespace E2ETests applicationPath = Path.GetFullPath(applicationPath.Replace('\\', '/')); //Mono does not have a way to pass in a --appbase switch. So it will be an environment variable. - //https://github.com/aspnet/KRuntime/issues/580 Environment.SetEnvironmentVariable("KRE_APPBASE", applicationPath); Console.WriteLine("Setting the KRE_APPBASE to {0}", applicationPath);