From 1b1bd34b8d1e42f74a2a438b2ed87af28b5dd016 Mon Sep 17 00:00:00 2001 From: Chris R Date: Wed, 21 Sep 2016 16:03:04 -0700 Subject: [PATCH] Add new dependnecy and test for UTF-8 BOM fix in views --- src/Microsoft.AspNetCore.Diagnostics.Elm/project.json | 1 + .../project.json | 1 + .../WelcomePageSampleTest.cs | 7 ++++--- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.AspNetCore.Diagnostics.Elm/project.json b/src/Microsoft.AspNetCore.Diagnostics.Elm/project.json index 7cf9b82cea..6b76c5b2f8 100644 --- a/src/Microsoft.AspNetCore.Diagnostics.Elm/project.json +++ b/src/Microsoft.AspNetCore.Diagnostics.Elm/project.json @@ -43,6 +43,7 @@ }, "netstandard1.3": { "dependencies": { + "System.Text.Encoding.Extensions": "4.0.11-*", "System.Threading": "4.0.11-*" } } diff --git a/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore/project.json b/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore/project.json index 27235651f4..6376b386a7 100644 --- a/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore/project.json +++ b/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore/project.json @@ -44,6 +44,7 @@ }, "netstandard1.3": { "dependencies": { + "System.Text.Encoding.Extensions": "4.0.11-*", "System.Threading": "4.0.11-*" } } diff --git a/test/Microsoft.AspNetCore.Diagnostics.FunctionalTests/WelcomePageSampleTest.cs b/test/Microsoft.AspNetCore.Diagnostics.FunctionalTests/WelcomePageSampleTest.cs index a7dce13727..e20fa6fdf4 100644 --- a/test/Microsoft.AspNetCore.Diagnostics.FunctionalTests/WelcomePageSampleTest.cs +++ b/test/Microsoft.AspNetCore.Diagnostics.FunctionalTests/WelcomePageSampleTest.cs @@ -20,13 +20,14 @@ namespace Microsoft.AspNetCore.Diagnostics.FunctionalTests [Fact] public async Task WelcomePage_ShowsWelcome() { - // Arrange var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost/"); - // Act var response = await Client.SendAsync(request); - // Assert + var bytes = await response.Content.ReadAsByteArrayAsync(); + Assert.True(bytes.Length > 1); + Assert.NotEqual(0xEF, bytes[0]); // No leading UTF-8 BOM + var body = await response.Content.ReadAsStringAsync(); Assert.Equal(HttpStatusCode.OK, response.StatusCode); Assert.Contains("Your ASP.NET Core application has been successfully started", body);