huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Optimize allocations in UrlResolutionTagHelper 

Fixes #3534
This commit is contained in:
Pranav K 2015-12-28 17:02:16 -08:00
parent 264e8447d4
commit 1a8d20fee5
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/Microsoft.AspNet.Mvc.Razor/TagHelpers/UrlResolutionTagHelper.cs
View File

@ -56,8 +56,8 @@ namespace Microsoft.AspNet.Mvc.Razor.TagHelpers
// Valid whitespace characters defined by the HTML5 spec. // Valid whitespace characters defined by the HTML5 spec.
private static readonly char[] ValidAttributeWhitespaceChars = private static readonly char[] ValidAttributeWhitespaceChars =
new[] { '\t', '\n', '\u000C', '\r', ' ' }; new[] { '\t', '\n', '\u000C', '\r', ' ' };
private static readonly IReadOnlyDictionary<string, IEnumerable<string>> ElementAttributeLookups = private static readonly Dictionary<string, string[]> ElementAttributeLookups =
new Dictionary<string, IEnumerable<string>>(StringComparer.OrdinalIgnoreCase) new Dictionary<string, string[]>(StringComparer.OrdinalIgnoreCase)
{ {
{ "a", new[] { "href" } }, { "a", new[] { "href" } },
{ "applet", new[] { "archive" } }, { "applet", new[] { "archive" } },
@ -125,12 +125,12 @@ namespace Microsoft.AspNet.Mvc.Razor.TagHelpers
throw new ArgumentNullException(nameof(output)); throw new ArgumentNullException(nameof(output));
} }
IEnumerable<string> attributeNames; string[] attributeNames;
if (ElementAttributeLookups.TryGetValue(output.TagName, out attributeNames)) if (ElementAttributeLookups.TryGetValue(output.TagName, out attributeNames))
{ {
foreach (var attributeName in attributeNames) for (var i = 0; i < attributeNames.Length; i++)
{ {
ProcessUrlAttribute(attributeName, output); ProcessUrlAttribute(attributeNames[i], output);
} }
} }
@ -157,11 +157,12 @@ namespace Microsoft.AspNet.Mvc.Razor.TagHelpers
throw new ArgumentNullException(nameof(output)); throw new ArgumentNullException(nameof(output));
} }
IEnumerable<TagHelperAttribute> attributes; IReadOnlyList<TagHelperAttribute> attributes;
if (output.Attributes.TryGetAttributes(attributeName, out attributes)) if (output.Attributes.TryGetAttributes(attributeName, out attributes))
{ {
foreach (var attribute in attributes) for (var i = 0; i < attributes.Count; i++)
{ {
var attribute = attributes[i];
var stringValue = attribute.Value as string; var stringValue = attribute.Value as string;
if (stringValue != null) if (stringValue != null)
{ {