Contributing: fixed some typos (#18494)
* Contributing: fixed some typos * Spotted another typo * this will cause a breaking change * made DefaultDisconetTimout readonly * made ConnectionOptionsSetup class internal * Revert "made ConnectionOptionsSetup class internal" This reverts commit 90f94d257bf5c953415c2f581f0a24a6f9bd51f6. * Update HttpConnectionDispatcher.Log.cs * Apply suggestions from code review Co-authored-by: Brennan <brecon@microsoft.com>
This commit is contained in:
parent
d8b6823111
commit
1a4dbb7cc5
|
|
@ -237,7 +237,7 @@ namespace Microsoft.AspNetCore.Builder
|
||||||
|
|
||||||
// NOTE: we explicitly don't use Map here because it's really common for multiple health
|
// NOTE: we explicitly don't use Map here because it's really common for multiple health
|
||||||
// check middleware to overlap in paths. Ex: `/health`, `/health/detailed` - this is order
|
// check middleware to overlap in paths. Ex: `/health`, `/health/detailed` - this is order
|
||||||
// sensititive with Map, and it's really surprising to people.
|
// sensitive with Map, and it's really surprising to people.
|
||||||
//
|
//
|
||||||
// See:
|
// See:
|
||||||
// https://github.com/aspnet/Diagnostics/issues/511
|
// https://github.com/aspnet/Diagnostics/issues/511
|
||||||
|
|
|
||||||
|
|
@ -7,7 +7,7 @@ using Microsoft.AspNetCore.HttpOverrides;
|
||||||
namespace Microsoft.AspNetCore.Builder
|
namespace Microsoft.AspNetCore.Builder
|
||||||
{
|
{
|
||||||
/// <summary>
|
/// <summary>
|
||||||
/// Extension methods for using certificate fowarding.
|
/// Extension methods for using certificate forwarding.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
public static class CertificateForwardingBuilderExtensions
|
public static class CertificateForwardingBuilderExtensions
|
||||||
{
|
{
|
||||||
|
|
|
||||||
|
|
@ -113,7 +113,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
|
||||||
_receivedDeleteRequestForUnsupportedTransport(logger, transportType, null);
|
_receivedDeleteRequestForUnsupportedTransport(logger, transportType, null);
|
||||||
}
|
}
|
||||||
|
|
||||||
public static void TerminatingConection(ILogger logger)
|
public static void TerminatingConnection(ILogger logger)
|
||||||
{
|
{
|
||||||
_terminatingConnection(logger, null);
|
_terminatingConnection(logger, null);
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -489,7 +489,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
Log.TerminatingConection(_logger);
|
Log.TerminatingConnection(_logger);
|
||||||
|
|
||||||
// Dispose the connection, but don't wait for it. We assign it here so we can wait in tests
|
// Dispose the connection, but don't wait for it. We assign it here so we can wait in tests
|
||||||
connection.DisposeAndRemoveTask = _manager.DisposeAndRemoveAsync(connection, closeGracefully: false);
|
connection.DisposeAndRemoveTask = _manager.DisposeAndRemoveAsync(connection, closeGracefully: false);
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue