huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Contributing: fixed some typos (#18494) 

* Contributing: fixed some typos

* Spotted another typo

* this will cause a breaking change

* made DefaultDisconetTimout readonly

* made ConnectionOptionsSetup class internal

* Revert "made ConnectionOptionsSetup class internal"

This reverts commit 90f94d257bf5c953415c2f581f0a24a6f9bd51f6.

* Update HttpConnectionDispatcher.Log.cs

* Apply suggestions from code review

Co-authored-by: Brennan <brecon@microsoft.com>
This commit is contained in:
Maher Jendoubi 2020-02-25 03:11:17 +01:00 committed by GitHub
parent d8b6823111
commit 1a4dbb7cc5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Middleware/HealthChecks/src/Builder/HealthCheckApplicationBuilderExtensions.cs
View File

@ -85,8 +85,8 @@ namespace Microsoft.AspNetCore.Builder
/// <para>
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// character.
/// </para>
/// <para>
@ -115,8 +115,8 @@ namespace Microsoft.AspNetCore.Builder
/// <para>
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// character.
/// </para>
/// <para>
@ -156,8 +156,8 @@ namespace Microsoft.AspNetCore.Builder
/// <para>
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// character.
/// </para>
/// </remarks>
@ -189,8 +189,8 @@ namespace Microsoft.AspNetCore.Builder
/// <para>
/// If <paramref name="path"/> is set to <c>null</c> or the empty string then the health check middleware
/// will ignore the URL path and process all requests on the specified port. If <paramref name="path"/> is
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// set to a non-empty value, the health check middleware will process requests with a URL that matches the
/// provided value of <paramref name="path"/> case-insensitively, allowing for an extra trailing slash ('/')
/// character.
/// </para>
/// </remarks>
@ -237,7 +237,7 @@ namespace Microsoft.AspNetCore.Builder
// NOTE: we explicitly don't use Map here because it's really common for multiple health
// check middleware to overlap in paths. Ex: `/health`, `/health/detailed` - this is order
// sensititive with Map, and it's really surprising to people.
// sensitive with Map, and it's really surprising to people.
//
// See:
// https://github.com/aspnet/Diagnostics/issues/511
@ -254,7 +254,7 @@ namespace Microsoft.AspNetCore.Builder
// We allow you to listen on all URLs by providing the empty PathString.
(!path.HasValue ||
// If you do provide a PathString, want to handle all of the special cases that
// If you do provide a PathString, want to handle all of the special cases that
// StartsWithSegments handles, but we also want it to have exact match semantics.
//
// Ex: /Foo/ == /Foo (true)

2
src/Middleware/HttpOverrides/src/CertificateForwardingBuilderExtensions.cs
View File

@ -7,7 +7,7 @@ using Microsoft.AspNetCore.HttpOverrides;
namespace Microsoft.AspNetCore.Builder
{
/// <summary>
/// Extension methods for using certificate fowarding.
/// Extension methods for using certificate forwarding.
/// </summary>
public static class CertificateForwardingBuilderExtensions
{

2
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.Log.cs
View File

@ -113,7 +113,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
_receivedDeleteRequestForUnsupportedTransport(logger, transportType, null);
}
public static void TerminatingConection(ILogger logger)
public static void TerminatingConnection(ILogger logger)
{
_terminatingConnection(logger, null);
}

2
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
View File

@ -489,7 +489,7 @@ namespace Microsoft.AspNetCore.Http.Connections.Internal
return;
}
Log.TerminatingConection(_logger);
Log.TerminatingConnection(_logger);
// Dispose the connection, but don't wait for it. We assign it here so we can wait in tests
connection.DisposeAndRemoveTask = _manager.DisposeAndRemoveAsync(connection, closeGracefully: false);