[Blazor][Fixes #15155] Clarifies the message to turn on detailed erro… (#15156)

Fixes https://github.com/aspnet/AspNetCore/issues/15155
This commit is contained in:
Javier Calvarro Nelson 2019-10-18 22:03:52 +02:00 committed by Pranav K
parent c298c94fe1
commit 19718f6011
4 changed files with 15 additions and 14 deletions

View File

@ -225,7 +225,7 @@ namespace Microsoft.AspNetCore.Components.Server.Circuits
Log.ConnectionUp(_logger, CircuitId, Client.ConnectionId); Log.ConnectionUp(_logger, CircuitId, Client.ConnectionId);
Renderer.Dispatcher.AssertAccess(); Renderer.Dispatcher.AssertAccess();
List<Exception> exceptions = null; List<Exception> exceptions = null;
for (var i = 0; i < _circuitHandlers.Length; i++) for (var i = 0; i < _circuitHandlers.Length; i++)
@ -254,7 +254,7 @@ namespace Microsoft.AspNetCore.Components.Server.Circuits
Log.ConnectionDown(_logger, CircuitId, Client.ConnectionId); Log.ConnectionDown(_logger, CircuitId, Client.ConnectionId);
Renderer.Dispatcher.AssertAccess(); Renderer.Dispatcher.AssertAccess();
List<Exception> exceptions = null; List<Exception> exceptions = null;
for (var i = 0; i < _circuitHandlers.Length; i++) for (var i = 0; i < _circuitHandlers.Length; i++)
@ -545,7 +545,7 @@ namespace Microsoft.AspNetCore.Components.Server.Circuits
else else
{ {
return $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " + return $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in '{typeof(CircuitOptions).Name}.{nameof(CircuitOptions.DetailedErrors)}'. {additionalInformation}"; $"detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set '{typeof(CircuitOptions).Name}.{nameof(CircuitOptions.DetailedErrors)}'. {additionalInformation}";
} }
} }

View File

@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
// Arrange // Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " + var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Bad input data."; $"detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Bad input data.";
var eventDescriptor = Serialize(new WebEventDescriptor() var eventDescriptor = Serialize(new WebEventDescriptor()
{ {
@ -65,7 +65,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
// Arrange // Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " + var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Failed to dispatch event."; $"detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Failed to dispatch event.";
var eventDescriptor = Serialize(new WebEventDescriptor() var eventDescriptor = Serialize(new WebEventDescriptor()
{ {
@ -105,7 +105,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
// Arrange // Arrange
var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " + var expectedError = $"There was an unhandled exception on the current circuit, so this circuit will be terminated. For more details turn on " +
$"detailed exceptions in 'CircuitOptions.DetailedErrors'. Failed to complete render batch '1846'."; $"detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. Failed to complete render batch '1846'.";
Client.ConfirmRenderBatch = false; Client.ConfirmRenderBatch = false;

View File

@ -216,7 +216,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
// Arrange // Arrange
var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " + var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " +
"For more details turn on detailed exceptions in 'CircuitOptions.DetailedErrors'. " + "For more details turn on detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. " +
"Location change to 'http://example.com' failed."; "Location change to 'http://example.com' failed.";
var rootUri = ServerFixture.RootUri; var rootUri = ServerFixture.RootUri;
@ -245,7 +245,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest.ServerExecutionTests
{ {
// Arrange // Arrange
var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " + var expectedError = "There was an unhandled exception on the current circuit, so this circuit will be terminated. " +
"For more details turn on detailed exceptions in 'CircuitOptions.DetailedErrors'. " + "For more details turn on detailed exceptions by setting 'DetailedErrors: true' in 'appSettings.Development.json' or set 'CircuitOptions.DetailedErrors'. " +
"Location change failed."; "Location change failed.";
var rootUri = ServerFixture.RootUri; var rootUri = ServerFixture.RootUri;

View File

@ -1,9 +1,10 @@
{ {
"Logging": { "DetailedErrors": true,
"LogLevel": { "Logging": {
"LogLevel": {
"Default": "Information", "Default": "Information",
"Microsoft": "Warning", "Microsoft": "Warning",
"Microsoft.Hosting.Lifetime": "Information" "Microsoft.Hosting.Lifetime": "Information"
} }
} }
} }