huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Work around `CryptographicException`s thrown in some full framework test runs 

- always skip affected tests on full framework
This commit is contained in:
Doug Bunting 2018-06-28 15:06:48 -07:00
parent 13585f711f
commit 192e8073ee
No known key found for this signature in database
GPG Key ID: 888B4EB7822B32E9
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/Microsoft.AspNetCore.Mvc.FunctionalTests/BasicApiTest.cs
View File

@ -5,6 +5,7 @@ using System.Net;
using System.Net.Http; using System.Net.Http;
using System.Text; using System.Text;
using System.Threading.Tasks; using System.Threading.Tasks;
using Microsoft.AspNetCore.Testing.xunit;
using Microsoft.Net.Http.Headers; using Microsoft.Net.Http.Headers;
using Xunit; using Xunit;
@ -56,7 +57,9 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode); Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode);
} }
[Fact] // Tests are conditional to avoid occasional CI failures on Windows 8 and Windows 2012 under full framework.
[ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
public async Task Token_WithKnownUser_ReturnsOkAndToken() public async Task Token_WithKnownUser_ReturnsOkAndToken()
{ {
// Arrange & Act // Arrange & Act
@ -81,7 +84,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode); Assert.Equal(HttpStatusCode.Unauthorized, response.StatusCode);
} }
[Theory] [ConditionalTheory]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
[InlineData("reader@example.com")] [InlineData("reader@example.com")]
[InlineData("writer@example.com")] [InlineData("writer@example.com")]
public async Task FindByStatus_WithToken_ReturnsOkAndPet(string username) public async Task FindByStatus_WithToken_ReturnsOkAndPet(string username)
@ -108,7 +112,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.NotEmpty(json); Assert.NotEmpty(json);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
public async Task FindById_WithInvalidPetId_ReturnsNotFound() public async Task FindById_WithInvalidPetId_ReturnsNotFound()
{ {
// Arrange & Act 1 // Arrange & Act 1
@ -128,7 +133,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.NotFound, response.StatusCode); Assert.Equal(HttpStatusCode.NotFound, response.StatusCode);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
public async Task FindById_WithValidPetId_ReturnsOkAndPet() public async Task FindById_WithValidPetId_ReturnsOkAndPet()
{ {
// Arrange & Act 1 // Arrange & Act 1
@ -153,7 +159,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.NotEmpty(json); Assert.NotEmpty(json);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
public async Task AddPet_WithInsufficientClaims_ReturnsForbidden() public async Task AddPet_WithInsufficientClaims_ReturnsForbidden()
{ {
// Arrange & Act 1 // Arrange & Act 1
@ -185,7 +192,8 @@ namespace Microsoft.AspNetCore.Mvc.FunctionalTests
Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode); Assert.Equal(HttpStatusCode.Forbidden, response.StatusCode);
} }
[Fact] [ConditionalFact]
[FrameworkSkipCondition(RuntimeFrameworks.CLR, SkipReason = "See aspnet/Identity#1630")]
public async Task AddPet_WithValidClaims_ReturnsCreated() public async Task AddPet_WithValidClaims_ReturnsCreated()
{ {
// Arrange & Act 1 // Arrange & Act 1