From 18dee25eb96af5faa30f959f0b165193ea7bdf04 Mon Sep 17 00:00:00 2001 From: Steve Sanderson Date: Wed, 30 Aug 2017 22:02:11 +0100 Subject: [PATCH] In tests, use dynamic port binding to avoid need for any coordination across simultaneous tests --- test/Helpers/AspNetProcess.cs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/Helpers/AspNetProcess.cs b/test/Helpers/AspNetProcess.cs index 087b35bec9..705f009ef8 100644 --- a/test/Helpers/AspNetProcess.cs +++ b/test/Helpers/AspNetProcess.cs @@ -14,8 +14,6 @@ namespace Templates.Test.Helpers private const string DefaultFramework = "netcoreapp2.0"; private const string ListeningMessagePrefix = "Now listening on: "; - private static int NextKestrelPort = 5000; - private readonly ProcessEx _process; private readonly Uri _listeningUri; private readonly HttpClient _httpClient; @@ -27,10 +25,9 @@ namespace Templates.Test.Helpers var buildProcess = ProcessEx.Run(workingDirectory, "dotnet", "build --no-restore -c Debug"); buildProcess.WaitForExit(assertSuccess: true); - var port = Interlocked.Increment(ref NextKestrelPort); var envVars = new Dictionary { - { "ASPNETCORE_URLS", "http://localhost:" + port } + { "ASPNETCORE_URLS", "http://127.0.0.1:0" } }; var framework = string.IsNullOrEmpty(targetFrameworkOverride) ? DefaultFramework : targetFrameworkOverride;