From 188c45965a9677af9aa725e2f9eddfef7e211767 Mon Sep 17 00:00:00 2001 From: Andrew Stanton-Nurse Date: Fri, 19 Apr 2019 10:19:59 -0700 Subject: [PATCH] skip flaky attribute tests, they're just too annoying (dotnet/extensions#1476) \n\nCommit migrated from https://github.com/dotnet/extensions/commit/97bd3149886d12fad88c1405f5abf5a993ede996 --- src/Testing/test/FlakyAttributeTest.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/Testing/test/FlakyAttributeTest.cs b/src/Testing/test/FlakyAttributeTest.cs index 7837bd8711..1b9a122d93 100644 --- a/src/Testing/test/FlakyAttributeTest.cs +++ b/src/Testing/test/FlakyAttributeTest.cs @@ -7,7 +7,7 @@ namespace Microsoft.AspNetCore.Testing.Tests { public class FlakyAttributeTest { - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.All)] public void AlwaysFlakyInCI() { @@ -17,7 +17,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.Helix.All)] public void FlakyInHelixOnly() { @@ -27,7 +27,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.Helix.macOS1012Amd64, FlakyOn.Helix.Fedora28Amd64)] public void FlakyInSpecificHelixQueue() { @@ -43,7 +43,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.AzP.All)] public void FlakyInAzPOnly() { @@ -53,7 +53,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.AzP.Windows)] public void FlakyInAzPWindowsOnly() { @@ -63,7 +63,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.AzP.macOS)] public void FlakyInAzPmacOSOnly() { @@ -73,7 +73,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.AzP.Linux)] public void FlakyInAzPLinuxOnly() { @@ -83,7 +83,7 @@ namespace Microsoft.AspNetCore.Testing.Tests } } - [Fact] + [Fact(Skip = "These tests are nice when you need them but annoying when on all the time.")] [Flaky("http://example.com", FlakyOn.AzP.Linux, FlakyOn.AzP.macOS)] public void FlakyInAzPNonWindowsOnly() {