From 186c411f4385b9d37d80f6882b38db950631e257 Mon Sep 17 00:00:00 2001 From: Mikael Mengistu Date: Fri, 28 Apr 2017 14:37:09 -0700 Subject: [PATCH] Clean up (#427) --- .../LongPollingTransport.cs | 5 +---- src/Microsoft.AspNetCore.Sockets.Client/SendUtils.cs | 2 +- .../ServerSentEventsTransport.cs | 3 --- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/Microsoft.AspNetCore.Sockets.Client/LongPollingTransport.cs b/src/Microsoft.AspNetCore.Sockets.Client/LongPollingTransport.cs index 872c4ca820..6d69d094ed 100644 --- a/src/Microsoft.AspNetCore.Sockets.Client/LongPollingTransport.cs +++ b/src/Microsoft.AspNetCore.Sockets.Client/LongPollingTransport.cs @@ -18,9 +18,6 @@ namespace Microsoft.AspNetCore.Sockets.Client { public class LongPollingTransport : ITransport { - private static readonly string DefaultUserAgent = "Microsoft.AspNetCore.SignalR.Client/0.0.0"; - private static readonly ProductInfoHeaderValue DefaultUserAgentHeader = ProductInfoHeaderValue.Parse(DefaultUserAgent); - private readonly HttpClient _httpClient; private readonly ILogger _logger; private IChannelConnection _application; @@ -90,7 +87,7 @@ namespace Microsoft.AspNetCore.Sockets.Client while (!cancellationToken.IsCancellationRequested) { var request = new HttpRequestMessage(HttpMethod.Get, pollUrl); - request.Headers.UserAgent.Add(DefaultUserAgentHeader); + request.Headers.UserAgent.Add(SendUtils.DefaultUserAgentHeader); var response = await _httpClient.SendAsync(request, cancellationToken); response.EnsureSuccessStatusCode(); diff --git a/src/Microsoft.AspNetCore.Sockets.Client/SendUtils.cs b/src/Microsoft.AspNetCore.Sockets.Client/SendUtils.cs index 21a0f2773a..6181915aae 100644 --- a/src/Microsoft.AspNetCore.Sockets.Client/SendUtils.cs +++ b/src/Microsoft.AspNetCore.Sockets.Client/SendUtils.cs @@ -20,7 +20,7 @@ namespace Microsoft.AspNetCore.Sockets.Client internal static class SendUtils { private static readonly string DefaultUserAgent = "Microsoft.AspNetCore.SignalR.Client/0.0.0"; - private static readonly ProductInfoHeaderValue DefaultUserAgentHeader = ProductInfoHeaderValue.Parse(DefaultUserAgent); + public static readonly ProductInfoHeaderValue DefaultUserAgentHeader = ProductInfoHeaderValue.Parse(DefaultUserAgent); public static async Task SendMessages(Uri sendUrl, IChannelConnection application, HttpClient httpClient, CancellationTokenSource transportCts, ILogger logger) { diff --git a/src/Microsoft.AspNetCore.Sockets.Client/ServerSentEventsTransport.cs b/src/Microsoft.AspNetCore.Sockets.Client/ServerSentEventsTransport.cs index 33d309e583..981247100b 100644 --- a/src/Microsoft.AspNetCore.Sockets.Client/ServerSentEventsTransport.cs +++ b/src/Microsoft.AspNetCore.Sockets.Client/ServerSentEventsTransport.cs @@ -16,9 +16,6 @@ namespace Microsoft.AspNetCore.Sockets.Client { public class ServerSentEventsTransport : ITransport { - private static readonly string DefaultUserAgent = "Microsoft.AspNetCore.SignalR.Client/0.0.0"; - private static readonly ProductInfoHeaderValue DefaultUserAgentHeader = ProductInfoHeaderValue.Parse(DefaultUserAgent); - private readonly HttpClient _httpClient; private readonly ILogger _logger; private readonly CancellationTokenSource _transportCts = new CancellationTokenSource();