From 17ed44c86816e0011f736a67b4e3be9ede73dda5 Mon Sep 17 00:00:00 2001 From: Pranav K Date: Wed, 31 Oct 2018 15:38:22 -0700 Subject: [PATCH] React to Razor.Design package removal (#8680) * React to Razor.Design package removal * Remove references to packages (Razor.Design, Razor.Extensions) solely used to bring in compiler \ targets * Target netcoreapp3.0 in samples and tests to allow Sdk to infer values --- benchmarkapps/BasicApi/BasicApi.csproj | 2 +- benchmarkapps/BasicViews/BasicViews.csproj | 2 +- .../RazorRendering/RazorRendering.csproj | 6 +- build/dependencies.props | 146 +++++++++--------- build/repo.props | 2 +- global.json | 4 +- korebuild-lock.txt | 4 +- samples/MvcSandbox/MvcSandbox.csproj | 5 +- .../Microsoft.AspNetCore.Mvc.csproj | 7 - ...ft.Extensions.ApiDescription.Design.csproj | 5 + test/Directory.Build.props | 2 +- .../ModelBinding/RouteValueProviderTests.cs | 5 +- test/WebSites/Directory.Build.props | 4 +- .../RazorBuildWebSite.csproj | 7 - .../RazorPagesClassLibrary.csproj | 4 + 15 files changed, 98 insertions(+), 107 deletions(-) diff --git a/benchmarkapps/BasicApi/BasicApi.csproj b/benchmarkapps/BasicApi/BasicApi.csproj index ec6e654069..e83f2de5d4 100644 --- a/benchmarkapps/BasicApi/BasicApi.csproj +++ b/benchmarkapps/BasicApi/BasicApi.csproj @@ -1,6 +1,6 @@  - netcoreapp2.2 + netcoreapp3.0 $(TargetFrameworks);net461 $(BenchmarksTargetFramework) diff --git a/benchmarkapps/BasicViews/BasicViews.csproj b/benchmarkapps/BasicViews/BasicViews.csproj index 6e62f39598..f434f76649 100644 --- a/benchmarkapps/BasicViews/BasicViews.csproj +++ b/benchmarkapps/BasicViews/BasicViews.csproj @@ -1,6 +1,6 @@  - netcoreapp2.2 + netcoreapp3.0 $(TargetFrameworks);net461 $(BenchmarksTargetFramework) diff --git a/benchmarkapps/RazorRendering/RazorRendering.csproj b/benchmarkapps/RazorRendering/RazorRendering.csproj index dc531b3fdf..aa45268afa 100644 --- a/benchmarkapps/RazorRendering/RazorRendering.csproj +++ b/benchmarkapps/RazorRendering/RazorRendering.csproj @@ -1,6 +1,6 @@  - netcoreapp2.2 + netcoreapp3.0 @@ -16,8 +16,8 @@ These references are used when running on the Benchmarks Server. --> - - + + diff --git a/build/dependencies.props b/build/dependencies.props index 189943f524..778259b129 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -16,88 +16,88 @@ 0.43.0 2.1.1.1 2.1.1 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-a-alpha1-w-m-16569 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 2.0.0 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-a-alpha1-master-builder-17095 - 3.0.0-a-alpha1-master-builder-17095 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 2.2.0-rtm-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 5.2.6 15.8.166 2.8.0 2.8.0 - 3.0.0-alpha1-10654 + 3.0.0-alpha1-10670 1.7.0 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 3.0.0-preview1-26907-05 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10670 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10657 + 3.0.0-alpha1-10670 2.0.9 2.1.3 - 2.2.0-preview3-27014-02 - 3.0.0-alpha1-10654 - 3.0.0-alpha1-10654 + 3.0.0-preview1-26907-05 + 3.0.0-alpha1-10670 + 3.0.0-a-alpha1-sdk-31823 15.6.1 4.10.0 2.0.3 diff --git a/build/repo.props b/build/repo.props index d1a3039193..e4fbe154d6 100644 --- a/build/repo.props +++ b/build/repo.props @@ -20,6 +20,6 @@ - + diff --git a/global.json b/global.json index ffa7db4c53..1b16120cd5 100644 --- a/global.json +++ b/global.json @@ -1,8 +1,8 @@ { "sdk": { - "version": "2.2.100-preview2-009404" + "version": "3.0.100-alpha1-009708" }, "msbuild-sdks": { - "Internal.AspNetCore.Sdk": "3.0.0-alpha1-20181011.11" + "Internal.AspNetCore.Sdk": "3.0.0-alpha1-20181031.3" } } diff --git a/korebuild-lock.txt b/korebuild-lock.txt index 27b605e3c6..8494b2123e 100644 --- a/korebuild-lock.txt +++ b/korebuild-lock.txt @@ -1,2 +1,2 @@ -version:3.0.0-alpha1-20181011.11 -commithash:f57aa8ddda0abdd74ada55853587bedb4f364065 +version:3.0.0-alpha1-20181031.3 +commithash:93e5628f435045e3f2a766933dc5062048ac0426 diff --git a/samples/MvcSandbox/MvcSandbox.csproj b/samples/MvcSandbox/MvcSandbox.csproj index d9e021ff7a..a19fea70be 100644 --- a/samples/MvcSandbox/MvcSandbox.csproj +++ b/samples/MvcSandbox/MvcSandbox.csproj @@ -1,7 +1,7 @@ - netcoreapp2.2 + netcoreapp3.0 $(TargetFrameworks);net461 @@ -11,10 +11,7 @@ - - - diff --git a/src/Microsoft.AspNetCore.Mvc/Microsoft.AspNetCore.Mvc.csproj b/src/Microsoft.AspNetCore.Mvc/Microsoft.AspNetCore.Mvc.csproj index 9b21543c20..3b47528415 100644 --- a/src/Microsoft.AspNetCore.Mvc/Microsoft.AspNetCore.Mvc.csproj +++ b/src/Microsoft.AspNetCore.Mvc/Microsoft.AspNetCore.Mvc.csproj @@ -19,13 +19,6 @@ - - - None - - - None - diff --git a/src/Microsoft.Extensions.ApiDescription.Design/Microsoft.Extensions.ApiDescription.Design.csproj b/src/Microsoft.Extensions.ApiDescription.Design/Microsoft.Extensions.ApiDescription.Design.csproj index 7809b19970..4eb5d5afad 100644 --- a/src/Microsoft.Extensions.ApiDescription.Design/Microsoft.Extensions.ApiDescription.Design.csproj +++ b/src/Microsoft.Extensions.ApiDescription.Design/Microsoft.Extensions.ApiDescription.Design.csproj @@ -42,6 +42,11 @@ tools/dotnet-getdocument.dll $(AssemblySigningStrongName) + + $(AssemblySigningCertName) + tools/dotnet-getdocument.exe + $(AssemblySigningStrongName) + $(AssemblySigningCertName) tools/net461/GetDocument.Insider.exe diff --git a/test/Directory.Build.props b/test/Directory.Build.props index ff13641a43..163935b303 100644 --- a/test/Directory.Build.props +++ b/test/Directory.Build.props @@ -2,7 +2,7 @@ - netcoreapp2.2 + netcoreapp3.0 $(DeveloperBuildTestTfms) $(StandardTestTfms);net461 diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/ModelBinding/RouteValueProviderTests.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/ModelBinding/RouteValueProviderTests.cs index a013595eac..631a6a4f94 100644 --- a/test/Microsoft.AspNetCore.Mvc.Core.Test/ModelBinding/RouteValueProviderTests.cs +++ b/test/Microsoft.AspNetCore.Mvc.Core.Test/ModelBinding/RouteValueProviderTests.cs @@ -73,9 +73,8 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding { "test-key", new DateTimeOffset(2018, 10, 31, 7, 37, 38, TimeSpan.FromHours(-7)) }, }); var provider = new RouteValueProvider(BindingSource.Query, values, new CultureInfo("de-CH")); - - // de-CH culture is slightly different on Windows versus other platforms. - var expected = TestPlatformHelper.IsWindows ? "31.10.2018 07:37:38 -07:00" : "31.10.18 07:37:38 -07:00"; + // The formatting was changed in netcoreapp3.0 to be consistent across platforms. + var expected = "31.10.2018 07:37:38 -07:00"; // Act var result = provider.GetValue("test-key"); diff --git a/test/WebSites/Directory.Build.props b/test/WebSites/Directory.Build.props index 2ff6b1fb54..c556bd5eab 100644 --- a/test/WebSites/Directory.Build.props +++ b/test/WebSites/Directory.Build.props @@ -3,9 +3,9 @@ - netcoreapp2.2 + netcoreapp3.0 $(DeveloperBuildTestWebsiteTfms) - netcoreapp2.2 + netcoreapp3.0 $(StandardTestWebsiteTfms);net461 diff --git a/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj b/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj index c2307238bc..6298eca2df 100644 --- a/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj +++ b/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj @@ -18,13 +18,6 @@ - - - - diff --git a/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj b/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj index 8fa786d637..6d4cba0c10 100644 --- a/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj +++ b/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj @@ -4,6 +4,10 @@ netstandard2.0 false + + <_EnableAllInclusiveRazorSdk>true + 2.1 + MVC-2.1