From 14679a78ee91838637dc0d517ff9eb517fbefd47 Mon Sep 17 00:00:00 2001 From: Louis DeJardin Date: Mon, 10 Feb 2014 18:18:10 -0800 Subject: [PATCH] Implementing code review feedback --- src/Microsoft.AspNet.Hosting/HostingServices.cs | 8 ++++---- src/Microsoft.AspNet.Hosting/Server/ServerManager.cs | 6 ++++-- src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs | 2 +- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/Microsoft.AspNet.Hosting/HostingServices.cs b/src/Microsoft.AspNet.Hosting/HostingServices.cs index 2c8a9437c9..298b187a71 100644 --- a/src/Microsoft.AspNet.Hosting/HostingServices.cs +++ b/src/Microsoft.AspNet.Hosting/HostingServices.cs @@ -40,16 +40,16 @@ namespace Microsoft.AspNet.Hosting LifecycleKind lifecycle) { var serviceTypeName = serviceType.FullName; - var implemenationTypeName = configuration.Get(serviceTypeName); - if (!String.IsNullOrEmpty(implemenationTypeName)) + var implementationTypeName = configuration.Get(serviceTypeName); + if (!String.IsNullOrEmpty(implementationTypeName)) { try { - implementationType = Type.GetType(implemenationTypeName); + implementationType = Type.GetType(implementationTypeName); } catch (Exception ex) { - throw new Exception(string.Format("TODO: unable to locate implementation {0} for service {1}", implemenationTypeName, serviceTypeName), ex); + throw new Exception(string.Format("TODO: unable to locate implementation {0} for service {1}", implementationTypeName, serviceTypeName), ex); } } return new ServiceTypeDescriptor(serviceType, implementationType, lifecycle); diff --git a/src/Microsoft.AspNet.Hosting/Server/ServerManager.cs b/src/Microsoft.AspNet.Hosting/Server/ServerManager.cs index b8bf9cf6b5..a6b91be91d 100644 --- a/src/Microsoft.AspNet.Hosting/Server/ServerManager.cs +++ b/src/Microsoft.AspNet.Hosting/Server/ServerManager.cs @@ -1,10 +1,12 @@ +using System; + namespace Microsoft.AspNet.Hosting.Server { public class ServerManager : IServerManager { public IServerFactory GetServer(string serverName) { - throw new System.NotImplementedException(); + throw new NotImplementedException(); } } -} +} \ No newline at end of file diff --git a/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs b/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs index c0949b178f..da13ebfff9 100644 --- a/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs +++ b/src/Microsoft.AspNet.Hosting/Startup/StartupLoader.cs @@ -20,7 +20,7 @@ namespace Microsoft.AspNet.Hosting.Startup public Action LoadStartup(string applicationName, IList diagnosticMessages) { - if (String.IsNullOrWhiteSpace(applicationName)) + if (String.IsNullOrEmpty(applicationName)) { return _next.LoadStartup(applicationName, diagnosticMessages); }