huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Be smarter about stringbuilder usage

This commit is contained in:
Ryan Nowak 2016-02-01 11:26:19 -08:00
parent 8189d852d1
commit 1142c7dfc0
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/JQueryFormValueProviderFactory.cs
View File

@ -25,7 +25,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
{ {
throw new ArgumentNullException(nameof(context)); throw new ArgumentNullException(nameof(context));
} }
var request = context.HttpContext.Request; var request = context.HttpContext.Request;
if (request.HasFormContentType) if (request.HasFormContentType)
{ {
@ -47,10 +47,15 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
{ {
var formCollection = await request.ReadFormAsync(); var formCollection = await request.ReadFormAsync();
var dictionary = new Dictionary<string, StringValues>(StringComparer.OrdinalIgnoreCase); var builder = new StringBuilder();
var dictionary = new Dictionary<string, StringValues>(
formCollection.Count,
StringComparer.OrdinalIgnoreCase);
foreach (var entry in formCollection) foreach (var entry in formCollection)
{ {
var key = NormalizeJQueryToMvc(entry.Key); var key = NormalizeJQueryToMvc(builder, entry.Key);
builder.Clear();
dictionary[key] = entry.Value; dictionary[key] = entry.Value;
} }
@ -63,7 +68,7 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
// [] --> "" // [] --> ""
// x[12] --> x[12] // x[12] --> x[12]
// x[field] --> x.field, where field is not a number // x[field] --> x.field, where field is not a number
private static string NormalizeJQueryToMvc(string key) private static string NormalizeJQueryToMvc(StringBuilder builder, string key)
{ {
if (string.IsNullOrEmpty(key)) if (string.IsNullOrEmpty(key))
{ {
@ -79,7 +84,6 @@ namespace Microsoft.AspNetCore.Mvc.ModelBinding
return key; return key;
} }
var builder = new StringBuilder();
var position = 0; var position = 0;
while (position < key.Length) while (position < key.Length)
{ {