From 102bcf6739957d772833d20a78f751a63719a4b8 Mon Sep 17 00:00:00 2001
From: Justin Robb <reptarsrage@gmail.com>
Date: Thu, 1 Aug 2019 12:13:37 -0700
Subject: [PATCH] Reverting breaking changes with npmScript parameter name

---
 .../src/AngularCli/AngularCliBuilder.cs                | 10 +++++-----
 .../src/AngularCli/AngularCliMiddlewareExtensions.cs   |  6 +++---
 .../ReactDevelopmentServerMiddlewareExtensions.cs      |  6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliBuilder.cs b/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliBuilder.cs
index df19fa76d9..c78e194726 100644
--- a/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliBuilder.cs
+++ b/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliBuilder.cs
@@ -26,15 +26,15 @@ namespace Microsoft.AspNetCore.SpaServices.AngularCli
         /// <summary>
         /// Constructs an instance of <see cref="AngularCliBuilder"/>.
         /// </summary>
-        /// <param name="scriptName">The name of the script in your package.json file that builds the server-side bundle for your Angular application.</param>
-        public AngularCliBuilder(string scriptName)
+        /// <param name="npmScript">The name of the script in your package.json file that builds the server-side bundle for your Angular application.</param>
+        public AngularCliBuilder(string npmScript)
         {
-            if (string.IsNullOrEmpty(scriptName))
+            if (string.IsNullOrEmpty(npmScript))
             {
-                throw new ArgumentException("Cannot be null or empty.", nameof(scriptName));
+                throw new ArgumentException("Cannot be null or empty.", nameof(npmScript));
             }
 
-            _scriptName = scriptName;
+            _scriptName = npmScript;
         }
 
         /// <inheritdoc />
diff --git a/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliMiddlewareExtensions.cs b/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliMiddlewareExtensions.cs
index 59f8ee5046..8f8176447b 100644
--- a/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliMiddlewareExtensions.cs
+++ b/src/Middleware/SpaServices.Extensions/src/AngularCli/AngularCliMiddlewareExtensions.cs
@@ -20,10 +20,10 @@ namespace Microsoft.AspNetCore.SpaServices.AngularCli
         /// sure not to enable the Angular CLI server.
         /// </summary>
         /// <param name="spaBuilder">The <see cref="ISpaBuilder"/>.</param>
-        /// <param name="scriptName">The name of the script in your package.json file that launches the Angular CLI process.</param>
+        /// <param name="npmScript">The name of the script in your package.json file that launches the Angular CLI process.</param>
         public static void UseAngularCliServer(
             this ISpaBuilder spaBuilder,
-            string scriptName)
+            string npmScript)
         {
             if (spaBuilder == null)
             {
@@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.SpaServices.AngularCli
                 throw new InvalidOperationException($"To use {nameof(UseAngularCliServer)}, you must supply a non-empty value for the {nameof(SpaOptions.SourcePath)} property of {nameof(SpaOptions)} when calling {nameof(SpaApplicationBuilderExtensions.UseSpa)}.");
             }
 
-            AngularCliMiddleware.Attach(spaBuilder, scriptName);
+            AngularCliMiddleware.Attach(spaBuilder, npmScript);
         }
     }
 }
diff --git a/src/Middleware/SpaServices.Extensions/src/ReactDevelopmentServer/ReactDevelopmentServerMiddlewareExtensions.cs b/src/Middleware/SpaServices.Extensions/src/ReactDevelopmentServer/ReactDevelopmentServerMiddlewareExtensions.cs
index 37532329ee..346e839046 100644
--- a/src/Middleware/SpaServices.Extensions/src/ReactDevelopmentServer/ReactDevelopmentServerMiddlewareExtensions.cs
+++ b/src/Middleware/SpaServices.Extensions/src/ReactDevelopmentServer/ReactDevelopmentServerMiddlewareExtensions.cs
@@ -20,10 +20,10 @@ namespace Microsoft.AspNetCore.SpaServices.ReactDevelopmentServer
         /// sure not to enable the create-react-app server.
         /// </summary>
         /// <param name="spaBuilder">The <see cref="ISpaBuilder"/>.</param>
-        /// <param name="scriptName">The name of the script in your package.json file that launches the create-react-app server.</param>
+        /// <param name="npmScript">The name of the script in your package.json file that launches the create-react-app server.</param>
         public static void UseReactDevelopmentServer(
             this ISpaBuilder spaBuilder,
-            string scriptName)
+            string npmScript)
         {
             if (spaBuilder == null)
             {
@@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.SpaServices.ReactDevelopmentServer
                 throw new InvalidOperationException($"To use {nameof(UseReactDevelopmentServer)}, you must supply a non-empty value for the {nameof(SpaOptions.SourcePath)} property of {nameof(SpaOptions)} when calling {nameof(SpaApplicationBuilderExtensions.UseSpa)}.");
             }
 
-            ReactDevelopmentServerMiddleware.Attach(spaBuilder, scriptName);
+            ReactDevelopmentServerMiddleware.Attach(spaBuilder, npmScript);
         }
     }
 }