From 0f74187a81802a6b81366f1ea5b4d6d97cdd11e8 Mon Sep 17 00:00:00 2001 From: Eilon Lipton Date: Thu, 10 Mar 2016 23:11:30 -0800 Subject: [PATCH] Fix package dependencies Removed some extraneous dependencies and instead made all the diagnostics packages be independent packages that happen to share some concepts/source code. The common Razor base class code was moved to a shared source file. Then the Diagnostics page, ELM page, and EF database page all use that. Also updated the page generator to use the new shared code. See #257 --- DiagnosticsPages.sln | 15 ++++++ NuGetPackageVerifier.json | 1 + samples/DatabaseErrorPageSample/project.json | 3 +- .../Views/DetailsPage.cs | 18 +++---- .../Views/DetailsPage.cshtml | 2 +- .../Views/LogPage.cs | 48 +++++++++---------- .../Views/LogPage.cshtml | 4 +- .../project.json | 15 ++++-- .../Views/DatabaseErrorPage.cs | 2 +- .../project.json | 12 +++-- .../Views/CompilationErrorPage.cs | 2 +- .../DeveloperExceptionPage/Views/ErrorPage.cs | 2 +- .../RuntimeInfo/Views/RuntimeInfoPage.cs | 2 +- .../WelcomePage/Views/WelcomePage.cs | 2 +- .../project.json | 4 ++ .../AttributeValue.cs | 5 +- .../BaseView.cs | 3 +- .../HelperResult.cs | 2 +- ...pNetCore.DiagnosticsViewPage.Sources.xproj | 19 ++++++++ .../project.json | 8 ++++ src/PageGenerator/Program.cs | 2 +- .../project.json | 1 + 22 files changed, 117 insertions(+), 55 deletions(-) rename src/{Microsoft.AspNetCore.Diagnostics/Views => Microsoft.AspNetCore.DiagnosticsViewPage.Sources}/AttributeValue.cs (79%) rename src/{Microsoft.AspNetCore.Diagnostics/Views => Microsoft.AspNetCore.DiagnosticsViewPage.Sources}/BaseView.cs (99%) rename src/{Microsoft.AspNetCore.Diagnostics/Views => Microsoft.AspNetCore.DiagnosticsViewPage.Sources}/HelperResult.cs (94%) create mode 100644 src/Microsoft.AspNetCore.DiagnosticsViewPage.Sources/Microsoft.AspNetCore.DiagnosticsViewPage.Sources.xproj create mode 100644 src/Microsoft.AspNetCore.DiagnosticsViewPage.Sources/project.json diff --git a/DiagnosticsPages.sln b/DiagnosticsPages.sln index 167961a120..04ef092fbe 100644 --- a/DiagnosticsPages.sln +++ b/DiagnosticsPages.sln @@ -51,6 +51,8 @@ Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.AspNetCore.Middle EndProject Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.AspNetCore.Diagnostics.FunctionalTests", "test\Microsoft.AspNetCore.Diagnostics.FunctionalTests\Microsoft.AspNetCore.Diagnostics.FunctionalTests.xproj", "{BFDFE1E3-A6A9-4DAB-8939-1DA306FC69C8}" EndProject +Project("{8BB2217D-0F2D-49D1-97BC-3654ED321F3B}") = "Microsoft.AspNetCore.DiagnosticsViewPage.Sources", "src\Microsoft.AspNetCore.DiagnosticsViewPage.Sources\Microsoft.AspNetCore.DiagnosticsViewPage.Sources.xproj", "{B9F08060-621F-4E1F-BDA8-9C4EA107E08A}" +EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|Any CPU = Debug|Any CPU @@ -275,6 +277,18 @@ Global {BFDFE1E3-A6A9-4DAB-8939-1DA306FC69C8}.Release|Mixed Platforms.Build.0 = Release|Any CPU {BFDFE1E3-A6A9-4DAB-8939-1DA306FC69C8}.Release|x86.ActiveCfg = Release|Any CPU {BFDFE1E3-A6A9-4DAB-8939-1DA306FC69C8}.Release|x86.Build.0 = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|Any CPU.ActiveCfg = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|Any CPU.Build.0 = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|Mixed Platforms.ActiveCfg = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|Mixed Platforms.Build.0 = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|x86.ActiveCfg = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Debug|x86.Build.0 = Debug|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|Any CPU.ActiveCfg = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|Any CPU.Build.0 = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|Mixed Platforms.ActiveCfg = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|Mixed Platforms.Build.0 = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|x86.ActiveCfg = Release|Any CPU + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A}.Release|x86.Build.0 = Release|Any CPU EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE @@ -299,5 +313,6 @@ Global {95981429-F212-44E1-83AA-32DA9E2A517C} = {ACAA0157-A8C4-4152-93DE-90CCDF304087} {B0166AED-738F-42EE-AF4D-C487C8B21521} = {2AF90579-B118-4583-AE88-672EFACB5BC4} {BFDFE1E3-A6A9-4DAB-8939-1DA306FC69C8} = {2AF90579-B118-4583-AE88-672EFACB5BC4} + {B9F08060-621F-4E1F-BDA8-9C4EA107E08A} = {509A6F36-AD80-4A18-B5B1-717D38DFF29D} EndGlobalSection EndGlobal diff --git a/NuGetPackageVerifier.json b/NuGetPackageVerifier.json index aedb97d440..ae74aea159 100644 --- a/NuGetPackageVerifier.json +++ b/NuGetPackageVerifier.json @@ -14,6 +14,7 @@ "adx-nonshipping": { "rules": [], "packages": { + "Microsoft.AspNetCore.DiagnosticsViewPage.Sources": { }, "PageGenerator": { } } }, diff --git a/samples/DatabaseErrorPageSample/project.json b/samples/DatabaseErrorPageSample/project.json index 5f13d10767..218cd36c31 100644 --- a/samples/DatabaseErrorPageSample/project.json +++ b/samples/DatabaseErrorPageSample/project.json @@ -1,10 +1,11 @@ { "dependencies": { + "Microsoft.AspNetCore.Diagnostics": "1.0.0-*", "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.0.0-*", "Microsoft.AspNetCore.IISPlatformHandler": "1.0.0-*", + "Microsoft.AspNetCore.Server.Kestrel": "1.0.0-*", "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0-*", "Microsoft.EntityFrameworkCore.Commands": "1.0.0-*", - "Microsoft.AspNetCore.Server.Kestrel": "1.0.0-*", "Microsoft.NETCore.Platforms": "1.0.1-*" }, "compilationOptions": { diff --git a/src/Microsoft.AspNetCore.Diagnostics.Elm/Views/DetailsPage.cs b/src/Microsoft.AspNetCore.Diagnostics.Elm/Views/DetailsPage.cs index 4bb45d35d6..dc0085f892 100644 --- a/src/Microsoft.AspNetCore.Diagnostics.Elm/Views/DetailsPage.cs +++ b/src/Microsoft.AspNetCore.Diagnostics.Elm/Views/DetailsPage.cs @@ -25,13 +25,13 @@ using Microsoft.AspNetCore.Diagnostics.Elm #line hidden ; #line 5 "DetailsPage.cshtml" -using Microsoft.AspNetCore.Diagnostics.Views +using Microsoft.AspNetCore.Diagnostics.Elm.Views #line default #line hidden ; #line 6 "DetailsPage.cshtml" -using Microsoft.AspNetCore.Diagnostics.Elm.Views +using Microsoft.AspNetCore.DiagnosticsViewPage.Views #line default #line hidden @@ -44,7 +44,7 @@ using Microsoft.Extensions.Logging ; using System.Threading.Tasks; - public class DetailsPage : Microsoft.AspNetCore.Diagnostics.Views.BaseView + public class DetailsPage : Microsoft.AspNetCore.DiagnosticsViewPage.Views.BaseView { #line 10 "DetailsPage.cshtml" @@ -423,9 +423,9 @@ using Microsoft.Extensions.Logging #line hidden WriteLiteral("