huahaofeng
/
aspnetcore
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make TagHelperOutput.Attributes case insensitive. 

- Changed the Attributes dictionary to utilize a StringComparer.OrdinalIgnoreCase comparer.
- Changed TagHelperExecutionContext to ignore attribute casing.
- Updated the AllAttributes and HtmlAttributes dictionaries to ignore attribute casing.
- Added tests to validate their new behavior.

#186
This commit is contained in:
N. Taylor Mullen 2014-10-20 14:08:21 -07:00 committed by NTaylorMullen
parent 21d64b4ae2
commit 0dba621965
4 changed files with 68 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperExecutionContext.cs
View File

@ -19,8 +19,8 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers
/// <param name="tagName">The HTML tag name in the Razor source.</param>
public TagHelperExecutionContext([NotNull] string tagName)
{
AllAttributes = new Dictionary<string, object>(StringComparer.Ordinal);
HTMLAttributes = new Dictionary<string, string>(StringComparer.Ordinal);
AllAttributes = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase);
HTMLAttributes = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
_tagHelpers = new List<ITagHelper>();
TagName = tagName;
}

4
src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperOutput.cs
View File

@ -21,7 +21,7 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers
internal TagHelperOutput(string tagName)
{
TagName = tagName;
Attributes = new Dictionary<string, string>(StringComparer.Ordinal);
Attributes = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
}
// Internal for testing
@ -42,7 +42,7 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers
{
TagName = tagName;
Content = content;
Attributes = new Dictionary<string, string>(attributes, StringComparer.Ordinal);
Attributes = new Dictionary<string, string>(attributes, StringComparer.OrdinalIgnoreCase);
}
/// <summary>

43
test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperExecutionContextTest.cs
View File

@ -9,6 +9,49 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers
{
public class TagHelperExecutionContextTest
{
public static TheoryData<string, string> DictionaryCaseTestingData
{
get
{
return new TheoryData<string, string>
{
{ "class", "CLaSS" },
{ "Class", "class" },
{ "Class", "claSS" }
};
}
}
[MemberData(nameof(DictionaryCaseTestingData))]
public void HtmlAttributes_IgnoresCase(string originalName, string updatedName)
{
// Arrange
var executionContext = new TagHelperExecutionContext("p");
executionContext.HTMLAttributes[originalName] = "hello";
// Act
executionContext.HTMLAttributes[updatedName] = "something else";
// Assert
var attribute = Assert.Single(executionContext.HTMLAttributes);
Assert.Equal(new KeyValuePair<string, string>(originalName, "something else"), attribute);
}
[MemberData(nameof(DictionaryCaseTestingData))]
public void AllAttributes_IgnoresCase(string originalName, string updatedName)
{
// Arrange
var executionContext = new TagHelperExecutionContext("p");
executionContext.AllAttributes[originalName] = false;
// Act
executionContext.AllAttributes[updatedName] = true;
// Assert
var attribute = Assert.Single(executionContext.AllAttributes);
Assert.Equal(new KeyValuePair<string, object>(originalName, true), attribute);
}
[Fact]
public void AddHtmlAttribute_MaintainsHTMLAttributes()
{

21
test/Microsoft.AspNet.Razor.Runtime.Test/TagHelpers/TagHelperOutputTest.cs
View File

@ -208,5 +208,26 @@ namespace Microsoft.AspNet.Razor.Runtime.TagHelpers
// Assert
Assert.Empty(output);
}
[Theory]
[InlineData("class", "ClASs")]
[InlineData("CLaSs", "class")]
[InlineData("cLaSs", "cLasS")]
public void Attributes_IgnoresCase(string originalName, string updateName)
{
// Arrange
var tagHelperOutput = new TagHelperOutput("p",
attributes: new Dictionary<string, string>
{
{ originalName, "btn" },
});
// Act
tagHelperOutput.Attributes[updateName] = "super button";
// Assert
var attribute = Assert.Single(tagHelperOutput.Attributes);
Assert.Equal(new KeyValuePair<string, string>(originalName, "super button"), attribute);
}
}
}