From 1564b1e83ae7d336e424fd2877d0f4d099beaf9f Mon Sep 17 00:00:00 2001 From: Pranav K Date: Mon, 19 Mar 2018 16:07:30 -0700 Subject: [PATCH] React to Sdk changes to assembly metadata Fixes https://github.com/aspnet/MvcPrecompilation/issues/248 --- korebuild-lock.txt | 4 ++-- samples/MusicStore/MusicStore.csproj | 1 - .../MusicStore.E2ETests/Implementation/Validator.cs | 13 +------------ 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/korebuild-lock.txt b/korebuild-lock.txt index e40ef6651b..f531e7b0f7 100644 --- a/korebuild-lock.txt +++ b/korebuild-lock.txt @@ -1,2 +1,2 @@ -version:2.1.0-preview2-15742 -commithash:21fbb0f2c3fe4a9216e2d59632b98cfd7d685962 +version:2.1.0-preview2-15744 +commithash:9e15cb6062ab5b9790d3fa699e018543a6950713 diff --git a/samples/MusicStore/MusicStore.csproj b/samples/MusicStore/MusicStore.csproj index 07dc732828..67c02e8564 100644 --- a/samples/MusicStore/MusicStore.csproj +++ b/samples/MusicStore/MusicStore.csproj @@ -4,7 +4,6 @@ Music store application on ASP.NET Core netcoreapp2.1;netcoreapp2.0;net461 $(DefineConstants);DEMO - true true win7-x86;win7-x64;linux-x64;osx-x64 Debug;Release;RuntimeStore diff --git a/test/MusicStore.E2ETests/Implementation/Validator.cs b/test/MusicStore.E2ETests/Implementation/Validator.cs index e1f3be3ea9..dfe425b2a6 100644 --- a/test/MusicStore.E2ETests/Implementation/Validator.cs +++ b/test/MusicStore.E2ETests/Implementation/Validator.cs @@ -116,7 +116,7 @@ namespace E2ETests } // Verify the app is using precompiled views - Assert.Contains("MusicStore.Views, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent); + Assert.Contains("MusicStore.Views, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent); } public async Task VerifyNtlmHomePage(HttpResponseMessage response) @@ -148,17 +148,6 @@ namespace E2ETests Assert.Contains("
  • ", responseContent, StringComparison.OrdinalIgnoreCase); } - public async Task VerifyRuntimeCompiledHomePage(HttpResponseMessage response) - { - var responseContent = await response.Content.ReadAsStringAsync(); - - // Smoke test to make sure the page is served correctly. - Assert.Contains("Home Page – ASP.NET MVC Music Store", responseContent); - - // Verify the app is using a runtime compiled view - Assert.DoesNotContain("MusicStore.Views, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null", responseContent); - } - public async Task VerifyStaticContentServed() { _logger.LogInformation("Validating if static contents are served..");