diff --git a/samples/IdentitySample.Mvc/Startup.cs b/samples/IdentitySample.Mvc/Startup.cs index 6b5351727f..916969aa4e 100644 --- a/samples/IdentitySample.Mvc/Startup.cs +++ b/samples/IdentitySample.Mvc/Startup.cs @@ -115,7 +115,7 @@ namespace IdentitySamples options.Password.RequireLowercase = false; options.Password.RequireUppercase = false; options.Password.RequireNonLetterOrDigit = false; - options.SecurityStampValidationInterval = TimeSpan.FromMinutes(1); + options.SecurityStampValidationInterval = TimeSpan.Zero; }); services.SetupOptions(options => { diff --git a/src/Microsoft.AspNet.Identity/BuilderExtensions.cs b/src/Microsoft.AspNet.Identity/BuilderExtensions.cs index d8caba9028..86b95d2a99 100644 --- a/src/Microsoft.AspNet.Identity/BuilderExtensions.cs +++ b/src/Microsoft.AspNet.Identity/BuilderExtensions.cs @@ -20,9 +20,9 @@ namespace Microsoft.AspNet.Builder throw new ArgumentNullException("app"); } var options = app.ApplicationServices.GetService>().Options; - app.UseCookieAuthentication(options.ApplicationCookie); app.SetDefaultSignInAsAuthenticationType(options.DefaultSignInAsAuthenticationType); app.UseCookieAuthentication(options.ExternalCookie); + app.UseCookieAuthentication(options.ApplicationCookie); app.UseCookieAuthentication(options.TwoFactorRememberMeCookie); app.UseCookieAuthentication(options.TwoFactorUserIdCookie); return app; diff --git a/src/Microsoft.AspNet.Identity/SignInManager.cs b/src/Microsoft.AspNet.Identity/SignInManager.cs index 2920a2799a..21f655a0f9 100644 --- a/src/Microsoft.AspNet.Identity/SignInManager.cs +++ b/src/Microsoft.AspNet.Identity/SignInManager.cs @@ -75,8 +75,7 @@ namespace Microsoft.AspNet.Identity { var userIdentity = await CreateUserIdentityAsync(user); // Should always clear any external login cookies when signing in for real - // BUG: SignOut currently throws if auth type was not signed in - //Context.Response.SignOut(Options.ExternalCookie.AuthenticationType); + Context.Response.SignOut(Options.ExternalCookie.AuthenticationType); if (authenticationMethod != null) { userIdentity.AddClaim(new Claim(ClaimTypes.AuthenticationMethod, authenticationMethod)); diff --git a/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs b/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs index b2a831e9ce..17275cae00 100644 --- a/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs +++ b/test/Microsoft.AspNet.Identity.Test/SignInManagerTest.cs @@ -280,7 +280,7 @@ namespace Microsoft.AspNet.Identity.Test contextAccessor.Setup(a => a.Value).Returns(context.Object); var roleManager = MockHelpers.MockRoleManager(); var identityOptions = new IdentityOptions(); - //response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); + response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); var options = new Mock>(); options.Setup(a => a.Options).Returns(identityOptions); var claimsFactory = new Mock>(manager.Object, roleManager.Object, options.Object); @@ -365,7 +365,7 @@ namespace Microsoft.AspNet.Identity.Test It.Is(i => i.FindFirstValue(ClaimTypes.Name) == user.Id && i.AuthenticationType == ClaimsIdentityOptions.DefaultTwoFactorRememberMeAuthenticationType))).Verifiable(); } - //response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); + response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); context.Setup(c => c.Response).Returns(response.Object).Verifiable(); context.Setup(c => c.AuthenticateAsync(ClaimsIdentityOptions.DefaultTwoFactorUserIdAuthenticationType)).ReturnsAsync(authResult).Verifiable(); contextAccessor.Setup(a => a.Value).Returns(context.Object); @@ -449,7 +449,7 @@ namespace Microsoft.AspNet.Identity.Test contextAccessor.Setup(a => a.Value).Returns(context.Object); var roleManager = MockHelpers.MockRoleManager(); var identityOptions = new IdentityOptions(); - //response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); + response.Setup(r => r.SignOut(identityOptions.ExternalCookie.AuthenticationType)).Verifiable(); var options = new Mock>(); options.Setup(a => a.Options).Returns(identityOptions); var claimsFactory = new Mock>(manager.Object, roleManager.Object, options.Object);