From 66613b194d0df398506249ff581957323c73b80e Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Fri, 22 Nov 2019 00:04:16 -0500
Subject: [PATCH 1/9] Updating descriptions for HTTP classes

#17204
---
 src/Http/Http.Abstractions/src/HttpMethods.cs | 34 +++++++++-
 src/Http/Http/src/DefaultHttpContext.cs       | 66 +++++++++++++++++++
 src/Http/Http/src/HttpContextAccessor.cs      |  6 ++
 .../src/HttpsRedirectionMiddleware.cs         |  7 +-
 .../src/HttpsRedirectionOptions.cs            |  2 +-
 .../src/WebHostBuilderHttpSysExtensions.cs    |  3 +
 6 files changed, 113 insertions(+), 5 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index 05a5f2e834..6a3fc6aff3 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -5,12 +5,15 @@ using System;
 
 namespace Microsoft.AspNetCore.Http
 {
+    /// <summary>
+    /// Contains methods to verify the request method of an HTTP request. 
+    /// <summary/>
     public static class HttpMethods
     {
         // We are intentionally using 'static readonly' here instead of 'const'.
-        // 'const' values would be embedded in to each assembly that used them
+        // 'const' values would be embedded into each assembly that used them
         // and each consuming assembly would have a different 'string' instance.
-        // Using .'static readonly' means that all consumers get thee exact same
+        // Using .'static readonly' means that all consumers get these exact same
         // 'string' instance, which means the 'ReferenceEquals' checks below work
         // and allow us to optimize comparisons when these constants are used.
         
@@ -25,46 +28,73 @@ namespace Microsoft.AspNetCore.Http
         public static readonly string Put = "PUT";
         public static readonly string Trace = "TRACE";
 
+        /// <summary>
+        /// Verifies the HTTP request method is CONNECT. 
+        /// <summary/>
         public static bool IsConnect(string method)
         {
             return object.ReferenceEquals(Connect, method) || StringComparer.OrdinalIgnoreCase.Equals(Connect, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is DELETE. 
+        /// <summary/>
         public static bool IsDelete(string method)
         {
             return object.ReferenceEquals(Delete, method) || StringComparer.OrdinalIgnoreCase.Equals(Delete, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is GET. 
+        /// <summary/>
         public static bool IsGet(string method)
         {
             return object.ReferenceEquals(Get, method) || StringComparer.OrdinalIgnoreCase.Equals(Get, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is HEAD. 
+        /// <summary/>
         public static bool IsHead(string method)
         {
             return object.ReferenceEquals(Head, method) || StringComparer.OrdinalIgnoreCase.Equals(Head, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is OPTIONS. 
+        /// <summary/>
         public static bool IsOptions(string method)
         {
             return object.ReferenceEquals(Options, method) || StringComparer.OrdinalIgnoreCase.Equals(Options, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is PATCH. 
+        /// <summary/>
         public static bool IsPatch(string method)
         {
             return object.ReferenceEquals(Patch, method) || StringComparer.OrdinalIgnoreCase.Equals(Patch, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is POST. 
+        /// <summary/>
         public static bool IsPost(string method)
         {
             return object.ReferenceEquals(Post, method) || StringComparer.OrdinalIgnoreCase.Equals(Post, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is PUT. 
+        /// <summary/>
         public static bool IsPut(string method)
         {
             return object.ReferenceEquals(Put, method) || StringComparer.OrdinalIgnoreCase.Equals(Put, method);
         }
 
+        /// <summary>
+        /// Verifies the HTTP request method is TRACE. 
+        /// <summary/>
         public static bool IsTrace(string method)
         {
             return object.ReferenceEquals(Trace, method) || StringComparer.OrdinalIgnoreCase.Equals(Trace, method);
diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index 7d096f186a..73f932746e 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -13,6 +13,9 @@ using Microsoft.Extensions.DependencyInjection;
 
 namespace Microsoft.AspNetCore.Http
 {
+    /// <summary>
+    /// Represents an implementation of the HTTP Context class with HTTP-specific information for a request. 
+    /// <summary/>
     public sealed class DefaultHttpContext : HttpContext
     {
         // Lambdas hoisted to static readonly fields to improve inlining https://github.com/dotnet/roslyn/issues/13624
@@ -32,6 +35,9 @@ namespace Microsoft.AspNetCore.Http
         private DefaultConnectionInfo _connection;
         private DefaultWebSocketManager _websockets;
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class.
+        /// <summary/>
         public DefaultHttpContext()
             : this(new FeatureCollection())
         {
@@ -40,6 +46,9 @@ namespace Microsoft.AspNetCore.Http
             Features.Set<IHttpResponseBodyFeature>(new StreamResponseBodyFeature(Stream.Null));
         }
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class with the using a collection of AspNetCore.Http.Features.
+        /// <summary/>
         public DefaultHttpContext(IFeatureCollection features)
         {
             _features.Initalize(features);
@@ -47,6 +56,9 @@ namespace Microsoft.AspNetCore.Http
             _response = new DefaultHttpResponse(this);
         }
 
+        /// <summary>
+        /// Initialize the current instant of the class with the using a collection of AspNetCore.Http.Features.
+        /// <summary/>
         public void Initialize(IFeatureCollection features)
         {
             var revision = features.Revision;
@@ -57,6 +69,9 @@ namespace Microsoft.AspNetCore.Http
             _websockets?.Initialize(features, revision);
         }
 
+        /// <summary>
+        /// Uninitialize the child request, response, connection and websocket object features and reset the class instance features.
+        /// <summary/>
         public void Uninitialize()
         {
             _features = default;
@@ -66,8 +81,14 @@ namespace Microsoft.AspNetCore.Http
             _websockets?.Uninitialize();
         }
 
+        /// <summary>
+        /// Gets or set the FormOptions for this instance.
+        /// <summary/>
         public FormOptions FormOptions { get; set; }
 
+        /// <summary>
+        /// Gets or sets the IServiceScopeFactory for this instance.
+        /// <summary/>
         public IServiceScopeFactory ServiceScopeFactory { get; set; }
 
         private IItemsFeature ItemsFeature =>
@@ -92,16 +113,43 @@ namespace Microsoft.AspNetCore.Http
         private IHttpRequestIdentifierFeature RequestIdentifierFeature =>
             _features.Fetch(ref _features.Cache.RequestIdentifier, _newHttpRequestIdentifierFeature);
 
+        /// <summary>
+        /// Returns the Features for this instance. If null, an ObjectDisposedException Exceptioon is thrown.
+        /// <summary/>
         public override IFeatureCollection Features => _features.Collection ?? ContextDisposed();
 
+        /// <summary>
+        /// Returns the HttpRequest of this instance.
+        /// <summary/>
         public override HttpRequest Request => _request;
 
+        /// <summary>
+        /// Returns the HttpResponse of this instance.
+        /// <summary/>
         public override HttpResponse Response => _response;
 
+        /// <summary>
+        /// Returns the connection information of this instance. 
+        /// <summary/>
+        /// <remarks>
+        /// If the Connection is null, a new DefaultConnectionInfo object is instantiated using the Features collection of this instance. 
+        /// <remarks/>
         public override ConnectionInfo Connection => _connection ?? (_connection = new DefaultConnectionInfo(Features));
 
+        /// <summary>
+        /// Returns the Web Socket Manager of this instance. 
+        /// <summary/>
+        /// <remarks>
+        /// If the Connection is null, a new DefaultWebSocketManager object is instantiated using the Features collection of this instance. 
+        /// <remarks/>
         public override WebSocketManager WebSockets => _websockets ?? (_websockets = new DefaultWebSocketManager(Features));
 
+        /// <summary>
+        /// Gets or sets the claims principal of this instance. 
+        /// <summary/>
+        /// <remarks>
+        /// If the ClaimsPrincipal object is null, a new ClaimsPrincipal object is instantiated. 
+        /// <remarks/>
         public override ClaimsPrincipal User
         {
             get
@@ -117,30 +165,48 @@ namespace Microsoft.AspNetCore.Http
             set { HttpAuthenticationFeature.User = value; }
         }
 
+        /// <summary>
+        /// Gets or sets the item feature object(s) of this instance. 
+        /// <summary/>
         public override IDictionary<object, object> Items
         {
             get { return ItemsFeature.Items; }
             set { ItemsFeature.Items = value; }
         }
 
+        /// <summary>
+        /// Gets or sets the service provider feature object of this instance. 
+        /// <summary/>
         public override IServiceProvider RequestServices
         {
             get { return ServiceProvidersFeature.RequestServices; }
             set { ServiceProvidersFeature.RequestServices = value; }
         }
 
+        /// <summary>
+        /// Gets or sets the cancellation token object of this instance. 
+        /// <summary/>
         public override CancellationToken RequestAborted
         {
             get { return LifetimeFeature.RequestAborted; }
             set { LifetimeFeature.RequestAborted = value; }
         }
 
+        /// <summary>
+        /// Gets or sets the trace identifier of this instance. 
+        /// <summary/>
         public override string TraceIdentifier
         {
             get { return RequestIdentifierFeature.TraceIdentifier; }
             set { RequestIdentifierFeature.TraceIdentifier = value; }
         }
 
+        /// <summary>
+        /// Gets or sets the session of this instance. 
+        /// <summary/>
+        /// <remarks>
+        /// If session feature has not been set, an Invalid Operation Exception is thrown. 
+        /// <remarks/>
         public override ISession Session
         {
             get
diff --git a/src/Http/Http/src/HttpContextAccessor.cs b/src/Http/Http/src/HttpContextAccessor.cs
index 286151029c..d99e02ef88 100644
--- a/src/Http/Http/src/HttpContextAccessor.cs
+++ b/src/Http/Http/src/HttpContextAccessor.cs
@@ -5,10 +5,16 @@ using System.Threading;
 
 namespace Microsoft.AspNetCore.Http
 {
+    /// <summary>
+    /// Represents the properties and methods used to keep access the current HTTP context. 
+    /// <summary/>
     public class HttpContextAccessor : IHttpContextAccessor
     {
         private static AsyncLocal<HttpContextHolder> _httpContextCurrent = new AsyncLocal<HttpContextHolder>();
 
+        /// <summary>
+        /// Gets or sets the HTTP context. 
+        /// <summary/>
         public HttpContext HttpContext
         {
             get
diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
index e20e8b8a33..e2926593e2 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
@@ -13,6 +13,9 @@ using Microsoft.Net.Http.Headers;
 
 namespace Microsoft.AspNetCore.HttpsPolicy
 {
+    /// <summary>
+    /// Provides functionality to redirect client requests to an address that uses the HTTPS protocol.
+    /// </summary>
     public class HttpsRedirectionMiddleware
     {
         private const int PortNotFound = -1;
@@ -26,7 +29,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         private readonly ILogger _logger;
 
         /// <summary>
-        /// Initializes the HttpsRedirectionMiddleware
+        /// Initializes the HttpsRedirectionMiddleware.
         /// </summary>
         /// <param name="next"></param>
         /// <param name="options"></param>
@@ -56,7 +59,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         }
 
         /// <summary>
-        /// Initializes the HttpsRedirectionMiddleware
+        /// Initializes the HttpsRedirectionMiddleware.
         /// </summary>
         /// <param name="next"></param>
         /// <param name="options"></param>
diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
index 07a166c162..85e177ec25 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Http;
 namespace Microsoft.AspNetCore.HttpsPolicy
 {
     /// <summary>
-    /// Options for the HttpsRedirection middleware
+    /// Options for the HttpsRedirection middleware.
     /// </summary>
     public class HttpsRedirectionOptions
     {
diff --git a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
index 7b4caaef62..f62a0982b6 100644
--- a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
+++ b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
@@ -9,6 +9,9 @@ using Microsoft.Extensions.Options;
 
 namespace Microsoft.AspNetCore.Hosting
 {
+    /// <summary>
+    /// Provides extensions method to use Http.sys as the server for the web host.
+    /// </summary>    
     public static class WebHostBuilderHttpSysExtensions
     {
         /// <summary>

From 5dcb568df026e4d9fdc50450180a4e670590defa Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Fri, 22 Nov 2019 22:27:55 -0500
Subject: [PATCH 2/9] Updating descriptions to add parameters

#17204
---
 src/Http/Http.Abstractions/src/HttpMethods.cs |  9 ++++++
 src/Http/Http/src/DefaultHttpContext.cs       |  8 +++--
 src/Http/Http/src/HttpContextAccessor.cs      |  2 +-
 src/Http/Http/src/HttpContextFactory.cs       | 31 +++++++++++++++++++
 4 files changed, 46 insertions(+), 4 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index 6a3fc6aff3..9e4b94949a 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -31,6 +31,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is CONNECT. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsConnect(string method)
         {
             return object.ReferenceEquals(Connect, method) || StringComparer.OrdinalIgnoreCase.Equals(Connect, method);
@@ -39,6 +40,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is DELETE. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsDelete(string method)
         {
             return object.ReferenceEquals(Delete, method) || StringComparer.OrdinalIgnoreCase.Equals(Delete, method);
@@ -47,6 +49,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is GET. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsGet(string method)
         {
             return object.ReferenceEquals(Get, method) || StringComparer.OrdinalIgnoreCase.Equals(Get, method);
@@ -55,6 +58,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is HEAD. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsHead(string method)
         {
             return object.ReferenceEquals(Head, method) || StringComparer.OrdinalIgnoreCase.Equals(Head, method);
@@ -63,6 +67,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is OPTIONS. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsOptions(string method)
         {
             return object.ReferenceEquals(Options, method) || StringComparer.OrdinalIgnoreCase.Equals(Options, method);
@@ -71,6 +76,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is PATCH. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsPatch(string method)
         {
             return object.ReferenceEquals(Patch, method) || StringComparer.OrdinalIgnoreCase.Equals(Patch, method);
@@ -79,6 +85,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is POST. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsPost(string method)
         {
             return object.ReferenceEquals(Post, method) || StringComparer.OrdinalIgnoreCase.Equals(Post, method);
@@ -87,6 +94,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is PUT. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsPut(string method)
         {
             return object.ReferenceEquals(Put, method) || StringComparer.OrdinalIgnoreCase.Equals(Put, method);
@@ -95,6 +103,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Verifies the HTTP request method is TRACE. 
         /// <summary/>
+        /// <param name="method">HTTP request method.</param>
         public static bool IsTrace(string method)
         {
             return object.ReferenceEquals(Trace, method) || StringComparer.OrdinalIgnoreCase.Equals(Trace, method);
diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index 73f932746e..70c1b0d29c 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -14,7 +14,7 @@ using Microsoft.Extensions.DependencyInjection;
 namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
-    /// Represents an implementation of the HTTP Context class with HTTP-specific information for a request. 
+    /// Represents an implementation of the HTTP Context class. 
     /// <summary/>
     public sealed class DefaultHttpContext : HttpContext
     {
@@ -47,8 +47,9 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Initializes a new instance of the DefaultHttpContext class with the using a collection of AspNetCore.Http.Features.
+        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
         /// <summary/>
+        /// <param name="features">Options to set when instantianting the Default HTTP context object.</param>
         public DefaultHttpContext(IFeatureCollection features)
         {
             _features.Initalize(features);
@@ -57,8 +58,9 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Initialize the current instant of the class with the using a collection of AspNetCore.Http.Features.
+        /// Initialize the current instant of the class with options passed in.
         /// <summary/>
+        /// <param name="features">Options to initialize the Default HTTP context object.</param>
         public void Initialize(IFeatureCollection features)
         {
             var revision = features.Revision;
diff --git a/src/Http/Http/src/HttpContextAccessor.cs b/src/Http/Http/src/HttpContextAccessor.cs
index d99e02ef88..e910dcdfbb 100644
--- a/src/Http/Http/src/HttpContextAccessor.cs
+++ b/src/Http/Http/src/HttpContextAccessor.cs
@@ -6,7 +6,7 @@ using System.Threading;
 namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
-    /// Represents the properties and methods used to keep access the current HTTP context. 
+    /// Represents the properties and methods used to access the current HTTP context. 
     /// <summary/>
     public class HttpContextAccessor : IHttpContextAccessor
     {
diff --git a/src/Http/Http/src/HttpContextFactory.cs b/src/Http/Http/src/HttpContextFactory.cs
index 3121c1704b..10688b0572 100644
--- a/src/Http/Http/src/HttpContextFactory.cs
+++ b/src/Http/Http/src/HttpContextFactory.cs
@@ -8,6 +8,9 @@ using Microsoft.Extensions.Options;
 
 namespace Microsoft.AspNetCore.Http
 {
+    /// <summary>
+    /// Represents methods used to create an HTTP context object. 
+    /// <summary/>
     [Obsolete("This is obsolete and will be removed in a future version. Use DefaultHttpContextFactory instead.")]
     public class HttpContextFactory : IHttpContextFactory
     {
@@ -15,21 +18,41 @@ namespace Microsoft.AspNetCore.Http
         private readonly FormOptions _formOptions;
         private readonly IServiceScopeFactory _serviceScopeFactory;
 
+        /// <summary>
+        /// Initializes a new instance of the HttpContext class with options passed in.
+        /// <summary/>
+        /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions)
             : this(formOptions, serviceScopeFactory: null)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
+        /// <summary/>
+        /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
+        /// <param name="serviceScopeFactory">Factory object used to create the service scope for the HTTP context.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions, IServiceScopeFactory serviceScopeFactory)
             : this(formOptions, serviceScopeFactory, httpContextAccessor: null)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
+        /// <summary/>
+        /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
+        /// <param name="httpContextAccessor">Object to be used to access the HTTP context instance.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions, IHttpContextAccessor httpContextAccessor)
             : this(formOptions, serviceScopeFactory: null, httpContextAccessor: httpContextAccessor)
         {
         }
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
+        /// <summary/>
+        /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
+        /// <param name="serviceScopeFactory">Factory object used to create the service scope for the HTTP context.</param>
+        /// <param name="httpContextAccessor">Options to set when instantianting the Default HTTP context object.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions, IServiceScopeFactory serviceScopeFactory, IHttpContextAccessor httpContextAccessor)
         {
             if (formOptions == null)
@@ -47,6 +70,10 @@ namespace Microsoft.AspNetCore.Http
             _httpContextAccessor = httpContextAccessor;
         }
 
+        /// <summary>
+        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
+        /// <summary/>
+        /// <param name="featureCollection">Options to set when instantianting the Default HTTP context object.</param>
         public HttpContext Create(IFeatureCollection featureCollection)
         {
             if (featureCollection == null)
@@ -66,6 +93,10 @@ namespace Microsoft.AspNetCore.Http
             return httpContext;
         }
 
+        /// <summary>
+        /// Sets the HTTP context object to null for garbage collection. 
+        /// <summary/>
+        /// <param name="httpContext">HTTP context to dispose.</param>
         public void Dispose(HttpContext httpContext)
         {
             if (_httpContextAccessor != null)

From d2f2ed99fc24508ce4efd4d7b491dbc3f33e32fb Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Sat, 23 Nov 2019 17:23:18 -0500
Subject: [PATCH 3/9] Updating method descriptions as per review suggestions

#17349
---
 src/Http/Http.Abstractions/src/HttpMethods.cs  | 18 +++++++++---------
 .../src/HttpsRedirectionMiddleware.cs          |  2 +-
 .../HttpsPolicy/src/HttpsRedirectionOptions.cs |  2 +-
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index 9e4b94949a..07a6a15a51 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Http
         public static readonly string Trace = "TRACE";
 
         /// <summary>
-        /// Verifies the HTTP request method is CONNECT. 
+        /// Returns a value that indicates if the HTTP request method is CONNECT. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsConnect(string method)
@@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is DELETE. 
+        /// Returns a value that indicates if the HTTP request method is DELETE. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsDelete(string method)
@@ -47,7 +47,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is GET. 
+        /// Returns a value that indicates if the HTTP request method is GET. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsGet(string method)
@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is HEAD. 
+        /// Returns a value that indicates if the HTTP request method is HEAD. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsHead(string method)
@@ -65,7 +65,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is OPTIONS. 
+        /// Returns a value that indicates if the HTTP request method is OPTIONS. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsOptions(string method)
@@ -74,7 +74,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is PATCH. 
+        /// Returns a value that indicates if the HTTP request method is PATCH. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsPatch(string method)
@@ -83,7 +83,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is POST. 
+        /// Returns a value that indicates if the HTTP request method is POST. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsPost(string method)
@@ -92,7 +92,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is PUT. 
+        /// Returns a value that indicates if the HTTP request method is PUT. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsPut(string method)
@@ -101,7 +101,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Verifies the HTTP request method is TRACE. 
+        /// Returns a value that indicates if the HTTP request method is TRACE. 
         /// <summary/>
         /// <param name="method">HTTP request method.</param>
         public static bool IsTrace(string method)
diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
index e2926593e2..51925f22ff 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
@@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         private readonly ILogger _logger;
 
         /// <summary>
-        /// Initializes the HttpsRedirectionMiddleware.
+        /// Initializes <see cref="HttpsRedirectionMiddleware" />.
         /// </summary>
         /// <param name="next"></param>
         /// <param name="options"></param>
diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
index 85e177ec25..0e1c625bd7 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionOptions.cs
@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Http;
 namespace Microsoft.AspNetCore.HttpsPolicy
 {
     /// <summary>
-    /// Options for the HttpsRedirection middleware.
+    /// Options for the HTTPS Redirection Middleware.
     /// </summary>
     public class HttpsRedirectionOptions
     {

From aeb8ab554a6c3febba66aea330090f270c4ea9c7 Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Sat, 23 Nov 2019 17:26:22 -0500
Subject: [PATCH 4/9] Updating the Http.sys server name in method descriptions

#17349
---
 src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
index f62a0982b6..46b9eb8b4c 100644
--- a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
+++ b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
@@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Hosting
     public static class WebHostBuilderHttpSysExtensions
     {
         /// <summary>
-        /// Specify HttpSys as the server to be used by the web host.
+        /// Specify Http.sys as the server to be used by the web host.
         /// </summary>
         /// <param name="hostBuilder">
         /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder to configure.
@@ -41,13 +41,13 @@ namespace Microsoft.AspNetCore.Hosting
         }
 
         /// <summary>
-        /// Specify HttpSys as the server to be used by the web host.
+        /// Specify Http.sys as the server to be used by the web host.
         /// </summary>
         /// <param name="hostBuilder">
         /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder to configure.
         /// </param>
         /// <param name="options">
-        /// A callback to configure HttpSys options.
+        /// A callback to configure Http.sys options.
         /// </param>
         /// <returns>
         /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder.

From 7c8d0f89f83119b7671152cfd6af68c2419517a6 Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Sat, 23 Nov 2019 18:27:12 -0500
Subject: [PATCH 5/9] Additional class and methods description changes
 including adding class references and inheriting docs

#17349
---
 src/Http/Http.Abstractions/src/HttpMethods.cs | 45 ++++++++--
 src/Http/Http/src/DefaultHttpContext.cs       | 82 +++++++------------
 src/Http/Http/src/HttpContextAccessor.cs      |  6 +-
 .../src/HttpsRedirectionMiddleware.cs         |  6 +-
 4 files changed, 70 insertions(+), 69 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index 07a6a15a51..89f96a73fe 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -31,7 +31,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is CONNECT. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsConnect(string method)
         {
             return object.ReferenceEquals(Connect, method) || StringComparer.OrdinalIgnoreCase.Equals(Connect, method);
@@ -40,7 +43,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is DELETE. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsDelete(string method)
         {
             return object.ReferenceEquals(Delete, method) || StringComparer.OrdinalIgnoreCase.Equals(Delete, method);
@@ -49,7 +55,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is GET. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The  HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsGet(string method)
         {
             return object.ReferenceEquals(Get, method) || StringComparer.OrdinalIgnoreCase.Equals(Get, method);
@@ -58,7 +67,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is HEAD. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsHead(string method)
         {
             return object.ReferenceEquals(Head, method) || StringComparer.OrdinalIgnoreCase.Equals(Head, method);
@@ -67,7 +79,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is OPTIONS. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsOptions(string method)
         {
             return object.ReferenceEquals(Options, method) || StringComparer.OrdinalIgnoreCase.Equals(Options, method);
@@ -76,7 +91,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is PATCH. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsPatch(string method)
         {
             return object.ReferenceEquals(Patch, method) || StringComparer.OrdinalIgnoreCase.Equals(Patch, method);
@@ -85,7 +103,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is POST. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsPost(string method)
         {
             return object.ReferenceEquals(Post, method) || StringComparer.OrdinalIgnoreCase.Equals(Post, method);
@@ -94,7 +115,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is PUT. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsPut(string method)
         {
             return object.ReferenceEquals(Put, method) || StringComparer.OrdinalIgnoreCase.Equals(Put, method);
@@ -103,7 +127,10 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is TRACE. 
         /// <summary/>
-        /// <param name="method">HTTP request method.</param>
+        /// <param name="method">The HTTP request method.</param>
+        /// <returns>
+        /// The System.Boolean.
+        /// </returns>
         public static bool IsTrace(string method)
         {
             return object.ReferenceEquals(Trace, method) || StringComparer.OrdinalIgnoreCase.Equals(Trace, method);
diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index 70c1b0d29c..303dfbb3bc 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -36,7 +36,7 @@ namespace Microsoft.AspNetCore.Http
         private DefaultWebSocketManager _websockets;
 
         /// <summary>
-        /// Initializes a new instance of the DefaultHttpContext class.
+        /// Initializes a new instance of the <see cref="DefaultHttpContext"/> class.
         /// <summary/>
         public DefaultHttpContext()
             : this(new FeatureCollection())
@@ -47,9 +47,9 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Initializes a new instance of the DefaultHttpContext class with options passed in.
+        /// Initializes a new instance of the <see cref="DefaultHttpContext"/> class with provided features.
         /// <summary/>
-        /// <param name="features">Options to set when instantianting the Default HTTP context object.</param>
+        /// <param name="features">Initial set of features for the <see cref="DefaultHttpContext"/>.</param>
         public DefaultHttpContext(IFeatureCollection features)
         {
             _features.Initalize(features);
@@ -58,9 +58,12 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Initialize the current instant of the class with options passed in.
+        /// Reinitialize  the current instant of the class with features passed in.
         /// <summary/>
-        /// <param name="features">Options to initialize the Default HTTP context object.</param>
+        /// <remarks>
+        /// This method allows the consumer to re-use the <see cref="DefaultHttpContext" /> for another request, rather than having to allocate a new instance.
+        /// <remarks>
+        /// <param name="features">The new set of features for the <see cref="DefaultHttpContext" />.</param>
         public void Initialize(IFeatureCollection features)
         {
             var revision = features.Revision;
@@ -72,7 +75,7 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Uninitialize the child request, response, connection and websocket object features and reset the class instance features.
+        /// Uninitialize all the features in the <see cref="DefaultHttpContext" />.
         /// <summary/>
         public void Uninitialize()
         {
@@ -84,13 +87,19 @@ namespace Microsoft.AspNetCore.Http
         }
 
         /// <summary>
-        /// Gets or set the FormOptions for this instance.
+        /// Gets or set the <see cref="FormOptions" /> for this instance.
         /// <summary/>
+        /// <returns>        
+        /// The Microsoft.AspNetCore.Http.Features.FormOptions.
+        /// </returns>
         public FormOptions FormOptions { get; set; }
 
         /// <summary>
-        /// Gets or sets the IServiceScopeFactory for this instance.
+        /// Gets or sets the <see cref="IServiceScopeFactory" /> for this instance.
         /// <summary/>
+        /// <returns>        
+        /// The Microsoft.Extensions.DependencyInjection.IServiceScopeFactory.
+        /// </returns>
         public IServiceScopeFactory ServiceScopeFactory { get; set; }
 
         private IItemsFeature ItemsFeature =>
@@ -115,43 +124,22 @@ namespace Microsoft.AspNetCore.Http
         private IHttpRequestIdentifierFeature RequestIdentifierFeature =>
             _features.Fetch(ref _features.Cache.RequestIdentifier, _newHttpRequestIdentifierFeature);
 
-        /// <summary>
-        /// Returns the Features for this instance. If null, an ObjectDisposedException Exceptioon is thrown.
-        /// <summary/>
+        /// <inheritdoc/>
         public override IFeatureCollection Features => _features.Collection ?? ContextDisposed();
 
-        /// <summary>
-        /// Returns the HttpRequest of this instance.
-        /// <summary/>
+        /// <inheritdoc/>
         public override HttpRequest Request => _request;
 
-        /// <summary>
-        /// Returns the HttpResponse of this instance.
-        /// <summary/>
+        /// <inheritdoc/>
         public override HttpResponse Response => _response;
 
-        /// <summary>
-        /// Returns the connection information of this instance. 
-        /// <summary/>
-        /// <remarks>
-        /// If the Connection is null, a new DefaultConnectionInfo object is instantiated using the Features collection of this instance. 
-        /// <remarks/>
+        /// <inheritdoc/>
         public override ConnectionInfo Connection => _connection ?? (_connection = new DefaultConnectionInfo(Features));
 
-        /// <summary>
-        /// Returns the Web Socket Manager of this instance. 
-        /// <summary/>
-        /// <remarks>
-        /// If the Connection is null, a new DefaultWebSocketManager object is instantiated using the Features collection of this instance. 
-        /// <remarks/>
+        /// <inheritdoc/>
         public override WebSocketManager WebSockets => _websockets ?? (_websockets = new DefaultWebSocketManager(Features));
 
-        /// <summary>
-        /// Gets or sets the claims principal of this instance. 
-        /// <summary/>
-        /// <remarks>
-        /// If the ClaimsPrincipal object is null, a new ClaimsPrincipal object is instantiated. 
-        /// <remarks/>
+        /// <inheritdoc/>
         public override ClaimsPrincipal User
         {
             get
@@ -167,48 +155,35 @@ namespace Microsoft.AspNetCore.Http
             set { HttpAuthenticationFeature.User = value; }
         }
 
-        /// <summary>
-        /// Gets or sets the item feature object(s) of this instance. 
-        /// <summary/>
+        /// <inheritdoc/>
         public override IDictionary<object, object> Items
         {
             get { return ItemsFeature.Items; }
             set { ItemsFeature.Items = value; }
         }
 
-        /// <summary>
-        /// Gets or sets the service provider feature object of this instance. 
-        /// <summary/>
+        /// <inheritdoc/>
         public override IServiceProvider RequestServices
         {
             get { return ServiceProvidersFeature.RequestServices; }
             set { ServiceProvidersFeature.RequestServices = value; }
         }
 
-        /// <summary>
-        /// Gets or sets the cancellation token object of this instance. 
-        /// <summary/>
+        /// <inheritdoc/>
         public override CancellationToken RequestAborted
         {
             get { return LifetimeFeature.RequestAborted; }
             set { LifetimeFeature.RequestAborted = value; }
         }
 
-        /// <summary>
-        /// Gets or sets the trace identifier of this instance. 
-        /// <summary/>
+        /// <inheritdoc/>
         public override string TraceIdentifier
         {
             get { return RequestIdentifierFeature.TraceIdentifier; }
             set { RequestIdentifierFeature.TraceIdentifier = value; }
         }
 
-        /// <summary>
-        /// Gets or sets the session of this instance. 
-        /// <summary/>
-        /// <remarks>
-        /// If session feature has not been set, an Invalid Operation Exception is thrown. 
-        /// <remarks/>
+        /// <inheritdoc/>
         public override ISession Session
         {
             get
@@ -234,6 +209,7 @@ namespace Microsoft.AspNetCore.Http
         [EditorBrowsable(EditorBrowsableState.Never)]
         public HttpContext HttpContext => this;
 
+        /// <inheritdoc/>
         public override void Abort()
         {
             LifetimeFeature.Abort();
diff --git a/src/Http/Http/src/HttpContextAccessor.cs b/src/Http/Http/src/HttpContextAccessor.cs
index e910dcdfbb..deea3c266e 100644
--- a/src/Http/Http/src/HttpContextAccessor.cs
+++ b/src/Http/Http/src/HttpContextAccessor.cs
@@ -6,15 +6,13 @@ using System.Threading;
 namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
-    /// Represents the properties and methods used to access the current HTTP context. 
+    /// Provides an implementation of <see cref="IHttpContextAccessor" /> based on the current execution context. 
     /// <summary/>
     public class HttpContextAccessor : IHttpContextAccessor
     {
         private static AsyncLocal<HttpContextHolder> _httpContextCurrent = new AsyncLocal<HttpContextHolder>();
 
-        /// <summary>
-        /// Gets or sets the HTTP context. 
-        /// <summary/>
+        /// <inheritdoc/>
         public HttpContext HttpContext
         {
             get
diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
index 51925f22ff..9d0778bf6d 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
@@ -14,7 +14,7 @@ using Microsoft.Net.Http.Headers;
 namespace Microsoft.AspNetCore.HttpsPolicy
 {
     /// <summary>
-    /// Provides functionality to redirect client requests to an address that uses the HTTPS protocol.
+    /// Middleware that redirects non-HTTPS requests to an HTTPS URL.
     /// </summary>
     public class HttpsRedirectionMiddleware
     {
@@ -59,7 +59,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         }
 
         /// <summary>
-        /// Initializes the HttpsRedirectionMiddleware.
+        /// Initializes <see cref="HttpsRedirectionMiddleware" />.
         /// </summary>
         /// <param name="next"></param>
         /// <param name="options"></param>
@@ -74,7 +74,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         }
 
         /// <summary>
-        /// Invokes the HttpsRedirectionMiddleware
+        /// Invokes the HttpsRedirectionMiddleware.
         /// </summary>
         /// <param name="context"></param>
         /// <returns></returns>

From ed5a43d5adde8048aed9118ceed64976d9c2e138 Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Mon, 25 Nov 2019 22:20:29 -0500
Subject: [PATCH 6/9] updating the return statements for specific methods

#17349
---
 src/Http/Http.Abstractions/src/HttpMethods.cs  | 18 +++++++++---------
 src/Http/Http/src/DefaultHttpContext.cs        |  8 ++++----
 .../src/WebHostBuilderHttpSysExtensions.cs     |  4 ++--
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index 89f96a73fe..a921ea0a84 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -33,7 +33,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is CONNECT; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsConnect(string method)
         {
@@ -45,7 +45,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is DELETE; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsDelete(string method)
         {
@@ -57,7 +57,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The  HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+         /// <see langword="true" /> if the method is GET; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsGet(string method)
         {
@@ -69,7 +69,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+         /// <see langword="true" /> if the method is HEAD; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsHead(string method)
         {
@@ -81,7 +81,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+         /// <see langword="true" /> if the method is OPTIONS; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsOptions(string method)
         {
@@ -93,7 +93,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is PATCH; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsPatch(string method)
         {
@@ -105,7 +105,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is POST; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsPost(string method)
         {
@@ -117,7 +117,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is PUT; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsPut(string method)
         {
@@ -129,7 +129,7 @@ namespace Microsoft.AspNetCore.Http
         /// <summary/>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
-        /// The System.Boolean.
+        /// <see langword="true" /> if the method is TRACE; otherwise, <see langword="false" />.
         /// </returns>
         public static bool IsTrace(string method)
         {
diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index 303dfbb3bc..06f4299191 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -89,16 +89,16 @@ namespace Microsoft.AspNetCore.Http
         /// <summary>
         /// Gets or set the <see cref="FormOptions" /> for this instance.
         /// <summary/>
-        /// <returns>        
-        /// The Microsoft.AspNetCore.Http.Features.FormOptions.
+        /// <returns>
+        /// <see cref="FormOptions"/>        
         /// </returns>
         public FormOptions FormOptions { get; set; }
 
         /// <summary>
         /// Gets or sets the <see cref="IServiceScopeFactory" /> for this instance.
         /// <summary/>
-        /// <returns>        
-        /// The Microsoft.Extensions.DependencyInjection.IServiceScopeFactory.
+        /// <returns>   
+        /// <see cref="IServiceScopeFactory"/>      
         /// </returns>
         public IServiceScopeFactory ServiceScopeFactory { get; set; }
 
diff --git a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
index 46b9eb8b4c..d8a9deb8c3 100644
--- a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
+++ b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
@@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Hosting
         /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder to configure.
         /// </param>
         /// <returns>
-        /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder.
+        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.</param>
         /// </returns>
         public static IWebHostBuilder UseHttpSys(this IWebHostBuilder hostBuilder)
         {
@@ -50,7 +50,7 @@ namespace Microsoft.AspNetCore.Hosting
         /// A callback to configure Http.sys options.
         /// </param>
         /// <returns>
-        /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder.
+        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.</param>
         /// </returns>
         public static IWebHostBuilder UseHttpSys(this IWebHostBuilder hostBuilder, Action<HttpSysOptions> options)
         {

From 10d5a0ba62626fc69bafa6a81181fb367da8ff7a Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Wed, 4 Dec 2019 20:07:14 -0500
Subject: [PATCH 7/9] Correcting XML closing tags

#17349
---
 src/Http/Http.Abstractions/src/HttpMethods.cs | 20 +++++++++----------
 src/Http/Http/src/DefaultHttpContext.cs       | 14 ++++++-------
 src/Http/Http/src/HttpContextAccessor.cs      |  2 +-
 src/Http/Http/src/HttpContextFactory.cs       | 14 ++++++-------
 4 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/src/Http/Http.Abstractions/src/HttpMethods.cs b/src/Http/Http.Abstractions/src/HttpMethods.cs
index a921ea0a84..350b98faf2 100644
--- a/src/Http/Http.Abstractions/src/HttpMethods.cs
+++ b/src/Http/Http.Abstractions/src/HttpMethods.cs
@@ -7,7 +7,7 @@ namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
     /// Contains methods to verify the request method of an HTTP request. 
-    /// <summary/>
+    /// </summary>
     public static class HttpMethods
     {
         // We are intentionally using 'static readonly' here instead of 'const'.
@@ -30,7 +30,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is CONNECT. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is CONNECT; otherwise, <see langword="false" />.
@@ -42,7 +42,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is DELETE. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is DELETE; otherwise, <see langword="false" />.
@@ -54,7 +54,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is GET. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The  HTTP request method.</param>
         /// <returns>
          /// <see langword="true" /> if the method is GET; otherwise, <see langword="false" />.
@@ -66,7 +66,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is HEAD. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
          /// <see langword="true" /> if the method is HEAD; otherwise, <see langword="false" />.
@@ -78,7 +78,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is OPTIONS. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
          /// <see langword="true" /> if the method is OPTIONS; otherwise, <see langword="false" />.
@@ -90,7 +90,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is PATCH. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is PATCH; otherwise, <see langword="false" />.
@@ -102,7 +102,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is POST. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is POST; otherwise, <see langword="false" />.
@@ -114,7 +114,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is PUT. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is PUT; otherwise, <see langword="false" />.
@@ -126,7 +126,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Returns a value that indicates if the HTTP request method is TRACE. 
-        /// <summary/>
+        /// </summary>
         /// <param name="method">The HTTP request method.</param>
         /// <returns>
         /// <see langword="true" /> if the method is TRACE; otherwise, <see langword="false" />.
diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index 06f4299191..ebe0816633 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -15,7 +15,7 @@ namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
     /// Represents an implementation of the HTTP Context class. 
-    /// <summary/>
+    /// </summary>
     public sealed class DefaultHttpContext : HttpContext
     {
         // Lambdas hoisted to static readonly fields to improve inlining https://github.com/dotnet/roslyn/issues/13624
@@ -37,7 +37,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the <see cref="DefaultHttpContext"/> class.
-        /// <summary/>
+        /// </summary>
         public DefaultHttpContext()
             : this(new FeatureCollection())
         {
@@ -48,7 +48,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the <see cref="DefaultHttpContext"/> class with provided features.
-        /// <summary/>
+        /// </summary>
         /// <param name="features">Initial set of features for the <see cref="DefaultHttpContext"/>.</param>
         public DefaultHttpContext(IFeatureCollection features)
         {
@@ -59,7 +59,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Reinitialize  the current instant of the class with features passed in.
-        /// <summary/>
+        /// </summary>
         /// <remarks>
         /// This method allows the consumer to re-use the <see cref="DefaultHttpContext" /> for another request, rather than having to allocate a new instance.
         /// <remarks>
@@ -76,7 +76,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Uninitialize all the features in the <see cref="DefaultHttpContext" />.
-        /// <summary/>
+        /// </summary>
         public void Uninitialize()
         {
             _features = default;
@@ -88,7 +88,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Gets or set the <see cref="FormOptions" /> for this instance.
-        /// <summary/>
+        /// </summary>
         /// <returns>
         /// <see cref="FormOptions"/>        
         /// </returns>
@@ -96,7 +96,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Gets or sets the <see cref="IServiceScopeFactory" /> for this instance.
-        /// <summary/>
+        /// </summary>
         /// <returns>   
         /// <see cref="IServiceScopeFactory"/>      
         /// </returns>
diff --git a/src/Http/Http/src/HttpContextAccessor.cs b/src/Http/Http/src/HttpContextAccessor.cs
index deea3c266e..762e454c42 100644
--- a/src/Http/Http/src/HttpContextAccessor.cs
+++ b/src/Http/Http/src/HttpContextAccessor.cs
@@ -7,7 +7,7 @@ namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
     /// Provides an implementation of <see cref="IHttpContextAccessor" /> based on the current execution context. 
-    /// <summary/>
+    /// </summary>
     public class HttpContextAccessor : IHttpContextAccessor
     {
         private static AsyncLocal<HttpContextHolder> _httpContextCurrent = new AsyncLocal<HttpContextHolder>();
diff --git a/src/Http/Http/src/HttpContextFactory.cs b/src/Http/Http/src/HttpContextFactory.cs
index 10688b0572..edddc658d3 100644
--- a/src/Http/Http/src/HttpContextFactory.cs
+++ b/src/Http/Http/src/HttpContextFactory.cs
@@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.Http
 {
     /// <summary>
     /// Represents methods used to create an HTTP context object. 
-    /// <summary/>
+    /// </summary>
     [Obsolete("This is obsolete and will be removed in a future version. Use DefaultHttpContextFactory instead.")]
     public class HttpContextFactory : IHttpContextFactory
     {
@@ -20,7 +20,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the HttpContext class with options passed in.
-        /// <summary/>
+        /// </summary>
         /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions)
             : this(formOptions, serviceScopeFactory: null)
@@ -29,7 +29,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the DefaultHttpContext class with options passed in.
-        /// <summary/>
+        /// </summary>
         /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
         /// <param name="serviceScopeFactory">Factory object used to create the service scope for the HTTP context.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions, IServiceScopeFactory serviceScopeFactory)
@@ -39,7 +39,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the DefaultHttpContext class with options passed in.
-        /// <summary/>
+        /// </summary>
         /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
         /// <param name="httpContextAccessor">Object to be used to access the HTTP context instance.</param>
         public HttpContextFactory(IOptions<FormOptions> formOptions, IHttpContextAccessor httpContextAccessor)
@@ -49,7 +49,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the DefaultHttpContext class with options passed in.
-        /// <summary/>
+        /// </summary>
         /// <param name="formOptions">Options to set when instantianting the HTTP context object.</param>
         /// <param name="serviceScopeFactory">Factory object used to create the service scope for the HTTP context.</param>
         /// <param name="httpContextAccessor">Options to set when instantianting the Default HTTP context object.</param>
@@ -72,7 +72,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Initializes a new instance of the DefaultHttpContext class with options passed in.
-        /// <summary/>
+        /// </summary>
         /// <param name="featureCollection">Options to set when instantianting the Default HTTP context object.</param>
         public HttpContext Create(IFeatureCollection featureCollection)
         {
@@ -95,7 +95,7 @@ namespace Microsoft.AspNetCore.Http
 
         /// <summary>
         /// Sets the HTTP context object to null for garbage collection. 
-        /// <summary/>
+        /// </summary>
         /// <param name="httpContext">HTTP context to dispose.</param>
         public void Dispose(HttpContext httpContext)
         {

From a71aa8a5bc3950b8ff8abb7365051d7958023c2f Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Wed, 4 Dec 2019 22:54:00 -0500
Subject: [PATCH 8/9] Correcting closing XML remark tag

#17349
---
 src/Http/Http/src/DefaultHttpContext.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Http/Http/src/DefaultHttpContext.cs b/src/Http/Http/src/DefaultHttpContext.cs
index ebe0816633..59c7739e86 100644
--- a/src/Http/Http/src/DefaultHttpContext.cs
+++ b/src/Http/Http/src/DefaultHttpContext.cs
@@ -62,7 +62,7 @@ namespace Microsoft.AspNetCore.Http
         /// </summary>
         /// <remarks>
         /// This method allows the consumer to re-use the <see cref="DefaultHttpContext" /> for another request, rather than having to allocate a new instance.
-        /// <remarks>
+        /// </remarks>
         /// <param name="features">The new set of features for the <see cref="DefaultHttpContext" />.</param>
         public void Initialize(IFeatureCollection features)
         {

From d4f380f67a6e61521f33872e4850c95c7a298ad9 Mon Sep 17 00:00:00 2001
From: Dairai Nyabando <dnyabando@g.harvard.edu>
Date: Wed, 4 Dec 2019 23:04:39 -0500
Subject: [PATCH 9/9] Removing unnecessary param tags and words

#17349
---
 src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs | 2 +-
 src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
index 9d0778bf6d..1a67121215 100644
--- a/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
+++ b/src/Middleware/HttpsPolicy/src/HttpsRedirectionMiddleware.cs
@@ -65,7 +65,7 @@ namespace Microsoft.AspNetCore.HttpsPolicy
         /// <param name="options"></param>
         /// <param name="config"></param>
         /// <param name="loggerFactory"></param>
-        /// <param name="serverAddressesFeature">The</param>
+        /// <param name="serverAddressesFeature"></param>
         public HttpsRedirectionMiddleware(RequestDelegate next, IOptions<HttpsRedirectionOptions> options, IConfiguration config, ILoggerFactory loggerFactory,
             IServerAddressesFeature serverAddressesFeature)
             : this(next, options, config, loggerFactory)
diff --git a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
index d8a9deb8c3..f7c2b9445f 100644
--- a/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
+++ b/src/Servers/HttpSys/src/WebHostBuilderHttpSysExtensions.cs
@@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Hosting
         /// The Microsoft.AspNetCore.Hosting.IWebHostBuilder to configure.
         /// </param>
         /// <returns>
-        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.</param>
+        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.
         /// </returns>
         public static IWebHostBuilder UseHttpSys(this IWebHostBuilder hostBuilder)
         {
@@ -50,7 +50,7 @@ namespace Microsoft.AspNetCore.Hosting
         /// A callback to configure Http.sys options.
         /// </param>
         /// <returns>
-        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.</param>
+        /// A reference to the <see cref="IWebHostBuilder" /> parameter object.
         /// </returns>
         public static IWebHostBuilder UseHttpSys(this IWebHostBuilder hostBuilder, Action<HttpSysOptions> options)
         {