Don't re-use requests (#15389)

This commit is contained in:
Ryan Brandenburg 2019-10-30 09:50:07 -07:00 committed by GitHub
parent 8e3075d391
commit 0540ec259d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 13 deletions

View File

@ -104,11 +104,13 @@ namespace Templates.Test.Helpers
public async Task ContainsLinks(Page page) public async Task ContainsLinks(Page page)
{ {
var request = new HttpRequestMessage( var response = await RequestWithRetries(client =>
HttpMethod.Get, {
new Uri(ListeningUri, page.Url)); var request = new HttpRequestMessage(
HttpMethod.Get,
var response = await RequestWithRetries(client => client.SendAsync(request), _httpClient); new Uri(ListeningUri, page.Url));
return client.SendAsync(request);
}, _httpClient);
Assert.Equal(HttpStatusCode.OK, response.StatusCode); Assert.Equal(HttpStatusCode.OK, response.StatusCode);
var parser = new HtmlParser(); var parser = new HtmlParser();
@ -235,16 +237,18 @@ namespace Templates.Test.Helpers
public async Task AssertStatusCode(string requestUrl, HttpStatusCode statusCode, string acceptContentType = null) public async Task AssertStatusCode(string requestUrl, HttpStatusCode statusCode, string acceptContentType = null)
{ {
var request = new HttpRequestMessage( var response = await RequestWithRetries(client => {
HttpMethod.Get, var request = new HttpRequestMessage(
new Uri(ListeningUri, requestUrl)); HttpMethod.Get,
new Uri(ListeningUri, requestUrl));
if (!string.IsNullOrEmpty(acceptContentType)) if (!string.IsNullOrEmpty(acceptContentType))
{ {
request.Headers.Add("Accept", acceptContentType); request.Headers.Add("Accept", acceptContentType);
} }
var response = await RequestWithRetries(client => client.SendAsync(request), _httpClient); return client.SendAsync(request);
}, _httpClient);
Assert.True(statusCode == response.StatusCode, $"Expected {requestUrl} to have status '{statusCode}' but it was '{response.StatusCode}'."); Assert.True(statusCode == response.StatusCode, $"Expected {requestUrl} to have status '{statusCode}' but it was '{response.StatusCode}'.");
} }