Don't re-use requests (#15389)

This commit is contained in:
Ryan Brandenburg 2019-10-30 09:50:07 -07:00 committed by GitHub
parent 8e3075d391
commit 0540ec259d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 13 deletions

View File

@ -103,12 +103,14 @@ namespace Templates.Test.Helpers
} }
public async Task ContainsLinks(Page page) public async Task ContainsLinks(Page page)
{
var response = await RequestWithRetries(client =>
{ {
var request = new HttpRequestMessage( var request = new HttpRequestMessage(
HttpMethod.Get, HttpMethod.Get,
new Uri(ListeningUri, page.Url)); new Uri(ListeningUri, page.Url));
return client.SendAsync(request);
var response = await RequestWithRetries(client => client.SendAsync(request), _httpClient); }, _httpClient);
Assert.Equal(HttpStatusCode.OK, response.StatusCode); Assert.Equal(HttpStatusCode.OK, response.StatusCode);
var parser = new HtmlParser(); var parser = new HtmlParser();
@ -235,6 +237,7 @@ namespace Templates.Test.Helpers
public async Task AssertStatusCode(string requestUrl, HttpStatusCode statusCode, string acceptContentType = null) public async Task AssertStatusCode(string requestUrl, HttpStatusCode statusCode, string acceptContentType = null)
{ {
var response = await RequestWithRetries(client => {
var request = new HttpRequestMessage( var request = new HttpRequestMessage(
HttpMethod.Get, HttpMethod.Get,
new Uri(ListeningUri, requestUrl)); new Uri(ListeningUri, requestUrl));
@ -244,7 +247,8 @@ namespace Templates.Test.Helpers
request.Headers.Add("Accept", acceptContentType); request.Headers.Add("Accept", acceptContentType);
} }
var response = await RequestWithRetries(client => client.SendAsync(request), _httpClient); return client.SendAsync(request);
}, _httpClient);
Assert.True(statusCode == response.StatusCode, $"Expected {requestUrl} to have status '{statusCode}' but it was '{response.StatusCode}'."); Assert.True(statusCode == response.StatusCode, $"Expected {requestUrl} to have status '{statusCode}' but it was '{response.StatusCode}'.");
} }