Added tests to cover ResourceManagerStringLocalizerFactory caching behavior

test/Microsoft.Extensions.Localization.Tests/ResourceManagerStringLocalizerFactoryTest.cs

@@ -0,0 +1,117 @@
+// Copyright (c) .NET Foundation. All rights reserved. 
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Threading.Tasks;
+using Xunit;
+using Moq;
+using Microsoft.Extensions.PlatformAbstractions;
+using Microsoft.Extensions.OptionsModel;
+using System.Reflection;
+
+namespace Microsoft.Extensions.Localization.Test
+{
+    public class ResourceManagerStringLocalizerFactoryTest
+    {
+        [Fact]
+        public void Create_FromType_ReturnsCachedResultForSameType()
+        {
+            // Arrange
+            var appEnv = new Mock<IApplicationEnvironment>();
+            appEnv.SetupGet(a => a.ApplicationName).Returns("TestApplication");
+            var locOptions = new LocalizationOptions();
+            var options = new Mock<IOptions<LocalizationOptions>>();
+            options.Setup(o => o.Value).Returns(locOptions);
+            var factory = new ResourceManagerStringLocalizerFactory(appEnv.Object, localizationOptions: options.Object);
+
+            // Act
+            var result1 = factory.Create(typeof(ResourceManagerStringLocalizerFactoryTest));
+            var result2 = factory.Create(typeof(ResourceManagerStringLocalizerFactoryTest));
+
+            // Assert
+            Assert.Same(result1, result2);
+        }
+
+        [Fact]
+        public void Create_FromType_ReturnsNewResultForDifferentType()
+        {
+            // Arrange
+            var appEnv = new Mock<IApplicationEnvironment>();
+            appEnv.SetupGet(a => a.ApplicationName).Returns("TestApplication");
+            var locOptions = new LocalizationOptions();
+            var options = new Mock<IOptions<LocalizationOptions>>();
+            options.Setup(o => o.Value).Returns(locOptions);
+            var factory = new ResourceManagerStringLocalizerFactory(appEnv.Object, localizationOptions: options.Object);
+
+            // Act
+            var result1 = factory.Create(typeof(ResourceManagerStringLocalizerFactoryTest));
+            var result2 = factory.Create(typeof(LocalizationOptions));
+
+            // Assert
+            Assert.NotSame(result1, result2);
+        }
+
+        [Fact]
+        public void Create_FromNameLocation_ReturnsCachedResultForSameNameLocation()
+        {
+            // Arrange
+            var appEnv = new Mock<IApplicationEnvironment>();
+            appEnv.SetupGet(a => a.ApplicationName).Returns("TestApplication");
+            var locOptions = new LocalizationOptions();
+            var options = new Mock<IOptions<LocalizationOptions>>();
+            options.Setup(o => o.Value).Returns(locOptions);
+            var factory = new ResourceManagerStringLocalizerFactory(appEnv.Object, localizationOptions: options.Object);
+            var location = typeof(ResourceManagerStringLocalizer).GetTypeInfo().Assembly.FullName;
+
+            // Act
+            var result1 = factory.Create("baseName", location);
+            var result2 = factory.Create("baseName", location);
+
+            // Assert
+            Assert.Same(result1, result2);
+        }
+
+        [Fact]
+        public void Create_FromNameLocation_ReturnsNewResultForDifferentName()
+        {
+            // Arrange
+            var appEnv = new Mock<IApplicationEnvironment>();
+            appEnv.SetupGet(a => a.ApplicationName).Returns("TestApplication");
+            var locOptions = new LocalizationOptions();
+            var options = new Mock<IOptions<LocalizationOptions>>();
+            options.Setup(o => o.Value).Returns(locOptions);
+            var factory = new ResourceManagerStringLocalizerFactory(appEnv.Object, localizationOptions: options.Object);
+            var location = typeof(ResourceManagerStringLocalizer).GetTypeInfo().Assembly.FullName;
+
+            // Act
+            var result1 = factory.Create("baseName1", location);
+            var result2 = factory.Create("baseName2", location);
+
+            // Assert
+            Assert.NotSame(result1, result2);
+        }
+
+        [Fact]
+        public void Create_FromNameLocation_ReturnsNewResultForDifferentLocation()
+        {
+            // Arrange
+            var appEnv = new Mock<IApplicationEnvironment>();
+            appEnv.SetupGet(a => a.ApplicationName).Returns("TestApplication");
+            var locOptions = new LocalizationOptions();
+            var options = new Mock<IOptions<LocalizationOptions>>();
+            options.Setup(o => o.Value).Returns(locOptions);
+            var factory = new ResourceManagerStringLocalizerFactory(appEnv.Object, localizationOptions: options.Object);
+            var location1 = typeof(ResourceManagerStringLocalizer).GetTypeInfo().Assembly.FullName;
+            var location2 = typeof(ResourceManagerStringLocalizerFactoryTest).GetTypeInfo().Assembly.FullName;
+
+            // Act
+            var result1 = factory.Create("baseName", location1);
+            var result2 = factory.Create("baseName", location2);
+
+            // Assert
+            Assert.NotSame(result1, result2);
+        }
+    }
+}

test/Microsoft.Extensions.Localization.Tests/project.json

@@ -10,8 +10,16 @@
     "xunit.runner.aspnet": "2.0.0-aspnet-*"
   },
   "frameworks": {
-    "dnx451": { },
+    "dnx451": {
-    "dnxcore50": {}
+      "dependencies": {
+        "Moq": "4.2.1312.1622"
+      }
+    },
+    "dnxcore50": {
+      "dependencies": {
+        "moq.netcore": "4.4.0-beta8"
+      }
+    }
   },
   "commands": {
     "test": "xunit.runner.aspnet"