From 9d570d791fd964a6d3bfad8efb5c468911e3d69c Mon Sep 17 00:00:00 2001 From: Pavel Krymets Date: Tue, 6 Nov 2018 14:50:35 -0800 Subject: [PATCH 1/3] Remove obsolete logging API usage (#3953) --- src/DataProtection/samples/AzureKeyVault/Program.cs | 3 +-- src/WebSockets/samples/EchoApp/Startup.cs | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/DataProtection/samples/AzureKeyVault/Program.cs b/src/DataProtection/samples/AzureKeyVault/Program.cs index 7d6299f3e5..7da515fa95 100644 --- a/src/DataProtection/samples/AzureKeyVault/Program.cs +++ b/src/DataProtection/samples/AzureKeyVault/Program.cs @@ -26,7 +26,7 @@ namespace ConsoleApplication var cert = store.Certificates.Find(X509FindType.FindByThumbprint, config["CertificateThumbprint"], false); var serviceCollection = new ServiceCollection(); - serviceCollection.AddLogging(); + serviceCollection.AddLogging(loggingBuilder => loggingBuilder.AddConsole()); serviceCollection.AddDataProtection() .PersistKeysToFileSystem(new DirectoryInfo(".")) .ProtectKeysWithAzureKeyVault(config["KeyId"], config["ClientId"], cert.OfType().Single()); @@ -34,7 +34,6 @@ namespace ConsoleApplication var serviceProvider = serviceCollection.BuildServiceProvider(); var loggerFactory = serviceProvider.GetService(); - loggerFactory.AddConsole(); var protector = serviceProvider.GetDataProtector("Test"); diff --git a/src/WebSockets/samples/EchoApp/Startup.cs b/src/WebSockets/samples/EchoApp/Startup.cs index 729716693c..1fc4caafb4 100644 --- a/src/WebSockets/samples/EchoApp/Startup.cs +++ b/src/WebSockets/samples/EchoApp/Startup.cs @@ -1,4 +1,4 @@ -using System; +using System; using System.Collections.Generic; using System.Linq; using System.Net.WebSockets; @@ -19,13 +19,12 @@ namespace EchoApp // For more information on how to configure your application, visit http://go.microsoft.com/fwlink/?LinkID=398940 public void ConfigureServices(IServiceCollection services) { + services.AddLogging(builder => builder.AddConsole()); } // This method gets called by the runtime. Use this method to configure the HTTP request pipeline. public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory) { - loggerFactory.AddConsole(LogLevel.Debug); - if (env.IsDevelopment()) { app.UseDeveloperExceptionPage(); From 3cf8a41e4a1d4b6705e8024be2aaa5248ad5a7bc Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 6 Nov 2018 17:30:26 -0800 Subject: [PATCH 2/3] Remove the aspnet/Logging submodule --- .gitmodules | 4 ---- build/CodeSign.props | 8 ++++++++ build/artifacts.props | 11 ----------- build/buildorder.props | 1 - build/dependencies.props | 9 +++++++++ build/external-dependencies.props | 15 ++++++++++++--- build/submodules.props | 1 - modules/Logging | 1 - 8 files changed, 29 insertions(+), 21 deletions(-) delete mode 160000 modules/Logging diff --git a/.gitmodules b/.gitmodules index b328994a6b..55b650c605 100644 --- a/.gitmodules +++ b/.gitmodules @@ -82,10 +82,6 @@ path = modules/Localization url = https://github.com/aspnet/Localization.git branch = release/2.2 -[submodule "modules/Logging"] - path = modules/Logging - url = https://github.com/aspnet/Logging.git - branch = release/2.2 [submodule "modules/MetaPackages"] path = modules/MetaPackages url = https://github.com/aspnet/MetaPackages.git diff --git a/build/CodeSign.props b/build/CodeSign.props index 55b5a7cfe4..dc6b600893 100644 --- a/build/CodeSign.props +++ b/build/CodeSign.props @@ -19,6 +19,7 @@ + @@ -39,6 +40,13 @@ + + + + + + + diff --git a/build/artifacts.props b/build/artifacts.props index e176e35291..a404466e78 100644 --- a/build/artifacts.props +++ b/build/artifacts.props @@ -204,17 +204,6 @@ - - - - - - - - - - - diff --git a/build/buildorder.props b/build/buildorder.props index 766161e0e4..a29d0cb8f6 100644 --- a/build/buildorder.props +++ b/build/buildorder.props @@ -11,7 +11,6 @@ - diff --git a/build/dependencies.props b/build/dependencies.props index d42cc5589c..f557bb9f2c 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -37,6 +37,15 @@ 2.2.0-rtm-35636 2.2.0-rtm-35636 2.2.0-rtm-181105-01 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 + 2.2.0-rtm-35636 2.2.0-rtm-181105-01 2.2.0-rtm-181105-01 2.2.0-rtm-181105-01 diff --git a/build/external-dependencies.props b/build/external-dependencies.props index b3fae958f2..48e6241288 100644 --- a/build/external-dependencies.props +++ b/build/external-dependencies.props @@ -42,9 +42,21 @@ + + + + + + + + + + + + @@ -56,9 +68,6 @@ - - - diff --git a/build/submodules.props b/build/submodules.props index f5fd966f7f..5d02446138 100644 --- a/build/submodules.props +++ b/build/submodules.props @@ -58,7 +58,6 @@ - diff --git a/modules/Logging b/modules/Logging deleted file mode 160000 index d39ac3492d..0000000000 --- a/modules/Logging +++ /dev/null @@ -1 +0,0 @@ -Subproject commit d39ac3492dc075a13580419b698960fe084a7c00 From 17ee447d26b14641f8b8e65c8bfcdc8723782f58 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 6 Nov 2018 17:32:06 -0800 Subject: [PATCH 3/3] Upgrade to Extensions 2.2.0-rtm-181106-10 --- build/dependencies.props | 114 +++++++++++++++++++-------------------- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/build/dependencies.props b/build/dependencies.props index f557bb9f2c..261d8515e9 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -6,63 +6,63 @@ 2.2.0-rtm-27105-02 4.6.0-rtm-27105-02 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-35646 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-35636 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 - 2.2.0-rtm-181105-01 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10 + 2.2.0-rtm-181106-10